E2E test: remove unnecessary login mr from fork test

What does this MR do and why?

Fixes #409194 (closed)

The merge_merge_request_from_fork_spec.rb E2E test has been recently de-quarantined and it has been occasionally failing when switching users immediately after creating an MR. There seems to be requests still running when the sign out button is clicked which means the token isn't cleared and then we get a 422, this seems to only occur due the speed of the actions of the automated test.

This MR waits for requests to complete before signing out. (Similar fix has been done here and here this fix greatly reduced the number of failures, but occasionally it still can occur)

It was also noticed that the test was logging out and in with the same user, so now we check that if the user is currently signed in, don't sign in again.

How to set up and validate locally

bundle exec rspec qa/specs/features/browser_ui/3_create/merge_request/suggestions/merge_merge_request_from_fork_spec.rb

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

assigned to @jay_mccure

added QA label

	1 Warning
	Please add a merge request subtype to this merge request.

	1 Message
	CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog. If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message. If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
QA	Edgars Brālītis (@ebralitis) (UTC+3, 7 hours behind @jay_mccure)	Sanad Liaquat (@sliaquat) (UTC+5, 5 hours behind @jay_mccure)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

@jay_mccure - please see the following guidance and update this merge request.

	1 Error
	Please add typebug typefeature, or typemaintenance label to this merge request.

added typemaintenance label

resolved all threads

changed milestone to %16.0

Setting label(s) Quality based on QA.

added Quality label

Allure report

allure-report-publisher generated test report!

e2e-review-qa: test report for fbf9bdb0

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Create           | 27     | 0      | 1       | 0     | 28    | ✅     |
| Plan             | 50     | 0      | 1       | 0     | 51    | ✅     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
| Govern           | 24     | 0      | 0       | 0     | 24    | ✅     |
| Manage           | 8      | 0      | 3       | 0     | 11    | ✅     |
| Verify           | 10     | 0      | 0       | 0     | 10    | ✅     |
| Data Stores      | 22     | 0      | 0       | 0     | 22    | ✅     |
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
| Framework sanity | 9      | 0      | 1       | 0     | 10    | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 154    | 0      | 7       | 0     | 161   | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: test report for fbf9bdb0

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Plan             | 377    | 0      | 3       | 33    | 380   | ❗     |
| Package          | 126    | 0      | 59      | 0     | 185   | ✅     |
| Create           | 662    | 0      | 110     | 21    | 772   | ❗     |
| Analytics        | 11     | 0      | 0       | 10    | 11    | ❗     |
| Verify           | 265    | 0      | 20      | 0     | 285   | ✅     |
| Data Stores      | 181    | 0      | 3       | 5     | 184   | ❗     |
| Manage           | 217    | 2      | 15      | 42    | 234   | ❌     |
| Govern           | 231    | 0      | 0       | 30    | 231   | ❗     |
| Configure        | 1      | 0      | 15      | 0     | 16    | ✅     |
| Fulfillment      | 12     | 0      | 125     | 0     | 137   | ✅     |
| Monitor          | 44     | 0      | 11      | 0     | 55    | ✅     |
| Release          | 30     | 0      | 0       | 5     | 30    | ❗     |
| Systems          | 19     | 0      | 0       | 0     | 19    | ✅     |
| Secure           | 10     | 0      | 45      | 0     | 55    | ✅     |
| Framework sanity | 0      | 0      | 5       | 0     | 5     | ➖     |
| Growth           | 0      | 0      | 10      | 0     | 10    | ➖     |
| ModelOps         | 0      | 0      | 5       | 0     | 5     | ➖     |
| GitLab Metrics   | 2      | 0      | 1       | 0     | 3     | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 2188   | 2      | 427     | 146   | 2617  | ❌     |
+------------------+--------+--------+---------+-------+-------+--------+

marked this merge request as ready

changed the description

marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

Hi @ebralitis would you be able to review this fix to improve the reliability of this test. Thanks!

requested review from @ebralitis

changed the description

mentioned in issue #409194 (closed)

approved this merge request

requested review from @at.ramya

removed review request for @ebralitis

mentioned in issue gitlab-org/quality/pipeline-triage#197 (closed)

approved this merge request

resolved all threads

merged

mentioned in commit d6f169d7

added workflowstaging-canary label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

added workflowpost-deploy-db-staging label and removed workflowproduction label

added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label

added releasedcandidate label