Enable SSO and ensure trial registrations perform onboarding steps
All threads resolved!
All threads resolved!
Compare changes
@@ -35,10 +35,10 @@ def after_sign_up_path
Let SSO sign ups experience the new user onboarding as we have this on normal sign ups for growth reasons in SaaS and want to add to the SSO experience as well. Before, due to the verification loop, the user is dropped out of the onboarding loop. This MR will address
This will also address trial registrations through regular signup being able to exit the specific trial onboarding and defaulting back to non-trial on welcome page redirection.
This should not affect Group Saml, LDAP or other Oauth strategies. Only the social sign ons for SaaS.
This feature is behind the ensure_onboarding
feature flag.
Screen_Recording_2023-05-08_at_2.01.35_PM
Screen_Recording_2023-05-08_at_2.14.12_PM
Screen_Recording_2023-05-09_at_3.33.22_PM
Screen_Recording_2023-05-09_at_3.28.58_PM
note basically trying to emulate feature spec steps in ee/spec/features/registrations/saas/standard_flow_just_me_creating_project_spec.rb
check_namespace_plan
in rails console
Feature.enable(:ensure_onboarding)
ApplicationSetting.first.update(check_namespace_plan: true)
/-/trial_registrations/new
path) and notice differences in screenshots above.rails console
Rails.application.routes.url_helpers.user_confirmation_path(confirmation_token: User.last.confirmation_token)
development
gitlab.yml
config values - mine looked like the below, setup for github by going on github under developer settings for my profile, redacted my info:development:
<<: *base
omniauth:
block_auto_created_users: false
allow_single_sign_on: true
providers:
- { name: 'google_oauth2',
app_id: '',
app_secret: '',
args: { access_type: 'offline', approval_prompt: '' } }
- { name: 'github',
app_id: 'xxxx',
app_secret: 'xxxxx',
args: { scope: "user:email" } }
/-/trial_registrations/new
path) and notice differences in screenshots above.This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #404926