Clean up use_invoice_preview_api_in_saas_purchase feature flag

changed milestone to %16.0

added Category:Purchase devopsfulfillment feature flag featureaddition frontend grouppurchase [DEPRECATED] quad-planningcomplete-action sectionfulfillment typefeature workflowin dev labels

assigned to @vvempati

added backend label

1 Warning

featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.

For more information, see:

The Handbook page on merge request types.
The definition of done documentation.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Jay Montal (`@jmontal`) (UTC-6, 18 hours behind `@vvempati`)	Tetiana Chupryna (`@brytannia`) (UTC+2, 10 hours behind `@vvempati`)
frontend	Rudy Crespo (`@rcrespo3`) (UTC-4, 16 hours behind `@vvempati`)	Jose Ivan Vargas (`@jivanvl`) (UTC-6, 18 hours behind `@vvempati`)
test for `spec/features/*`	Valerie Burton (`@vburton`) (UTC-5, 17 hours behind `@vvempati`)	Maintainer review is optional for test for `spec/features/*`

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

removed backend label

changed title from Use invoice preview API to calculate plan pricing for SaaS purchase to Clean up use_invoice_preview_api_in_saas_purchase feature flag

changed the description

mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@0441e96b

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 9eb3f6e0 and 5a0d8df3

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	4.04 MB	4.04 MB	-	-0.0 %
mainChunk	2.89 MB	2.89 MB	-	0.0 %

Note: We do not have exact data for 9eb3f6e0. So we have used data from: ccfefb14.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.

Please look at the full report for more details

Allure report

allure-report-publisher generated test report!

e2e-review-qa: test report for eebe78b2

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Verify           | 10     | 0      | 0       | 0     | 10    | ✅     |
| Create           | 28     | 0      | 1       | 0     | 29    | ✅     |
| Plan             | 49     | 0      | 1       | 0     | 50    | ✅     |
| Data Stores      | 22     | 0      | 0       | 0     | 22    | ✅     |
| Govern           | 24     | 0      | 0       | 0     | 24    | ✅     |
| Manage           | 8      | 0      | 3       | 0     | 11    | ✅     |
| Framework sanity | 9      | 0      | 1       | 0     | 10    | ✅     |
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 154    | 0      | 7       | 0     | 161   | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: test report for eebe78b2

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Create           | 731    | 0      | 105     | 125   | 836   | ❗     |
| Monitor          | 50     | 0      | 0       | 50    | 50    | ❗     |
| Plan             | 303    | 0      | 0       | 165   | 303   | ❗     |
| Data Stores      | 170    | 0      | 0       | 40    | 170   | ❗     |
| Verify           | 270    | 0      | 20      | 220   | 290   | ❗     |
| Analytics        | 10     | 0      | 0       | 10    | 10    | ❗     |
| ModelOps         | 0      | 0      | 5       | 0     | 5     | ➖     |
| Secure           | 35     | 0      | 25      | 35    | 60    | ❗     |
| Manage           | 160    | 5      | 15      | 40    | 180   | ❌     |
| Govern           | 230    | 0      | 0       | 230   | 230   | ❗     |
| Release          | 30     | 0      | 0       | 20    | 30    | ❗     |
| Package          | 125    | 0      | 23      | 0     | 148   | ✅     |
| Systems          | 2      | 0      | 0       | 0     | 2     | ✅     |
| Configure        | 0      | 0      | 15      | 0     | 15    | ➖     |
| Growth           | 0      | 0      | 10      | 0     | 10    | ➖     |
| Fulfillment      | 12     | 0      | 120     | 0     | 132   | ✅     |
| Framework sanity | 0      | 0      | 5       | 0     | 5     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 2128   | 5      | 343     | 935   | 2476  | ❌     |
+------------------+--------+--------+---------+-------+-------+--------+

marked this merge request as draft

Hey @mtan-gitlab , heads up that downstream needs updating for feature flag removal in this MR. Jest failure here. We should probably also update the spec file for the same subscription_flow_paid_plan_spec.rb.

Hey @mhamda, would you have time to do an initial backend review for this please?

Thank you

requested review from @mhamda

Hey @dzubova, would you have time to do an initial frontend review for this please?

Thank you

requested review from @dzubova

Hey @ddavison, would you have time to do test review for this please?

I couldn't find e2e:package-and-test job in the pipeline, I can see e2e:package-and-test-ce, e2e:package-and-test-ee and e2e:test-on-gdk but not sure if they run the Fulfilment E2E tests

Thank you