Remove refactor_code_quality_inline_findings feature-flag
What does this MR do and why?
This MR removes the refactor_code_quality_inline_findings since the feature was enabled by default in 15.9 and is now save to remove.
Issue: #388249 (closed)
Screenshots or screen recordings
no visual changes
Demo |
---|
![]() |
How to set up and validate locally
- Clone this project in your GDK https://gitlab.com/jannik_lehmann/code-quality-test
- Recreate this MR or open up a MR with code Quality Issues yourself
- go visit the changes tab on the MR and hover/click the CodeQuality indicator to see the changes in action
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @jannik_lehmann
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Halil Coban (
@halilcoban
) (UTC+2, same timezone as@jannik_lehmann
)Stan Hu (
@stanhu
) (UTC-7, 9 hours behind@jannik_lehmann
)frontend Paulina Sedlak-Jakubowska (
@psjakubowska
) (UTC+2, same timezone as@jannik_lehmann
)Vitaly Slobodin (
@vitallium
) (UTC+2, same timezone as@jannik_lehmann
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@jannik_lehmann - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@edf4a224
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 4c54992d and 5e4595ee
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.64 MB 3.64 MB - -0.0 % mainChunk 2.08 MB 2.08 MB - 0.0 %
Note: We do not have exact data for 4c54992d. So we have used data from: e42cee03.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 5e4595eeexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Govern | 24 | 0 | 0 | 0 | 24 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Manage | 8 | 0 | 3 | 0 | 11 | ✅ | | Verify | 10 | 0 | 0 | 0 | 10 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 154 | 0 | 7 | 0 | 161 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 5e4595eeexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 739 | 0 | 106 | 153 | 845 | ❗ | | Plan | 307 | 0 | 0 | 161 | 307 | ❗ | | Monitor | 54 | 0 | 0 | 54 | 54 | ❗ | | Verify | 270 | 0 | 20 | 225 | 290 | ❗ | | Manage | 166 | 0 | 15 | 75 | 181 | ❗ | | Package | 125 | 0 | 23 | 0 | 148 | ✅ | | Data Stores | 172 | 0 | 0 | 55 | 172 | ❗ | | Fulfillment | 10 | 0 | 110 | 0 | 120 | ✅ | | Govern | 232 | 0 | 0 | 232 | 232 | ❗ | | Growth | 0 | 0 | 10 | 0 | 10 | ➖ | | Release | 30 | 0 | 0 | 20 | 30 | ❗ | | Analytics | 10 | 0 | 0 | 10 | 10 | ❗ | | Configure | 0 | 0 | 15 | 0 | 15 | ➖ | | Framework sanity | 0 | 0 | 6 | 0 | 6 | ➖ | | ModelOps | 0 | 0 | 5 | 0 | 5 | ➖ | | Systems | 2 | 0 | 0 | 0 | 2 | ✅ | | Secure | 20 | 0 | 40 | 20 | 60 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 2137 | 0 | 350 | 1005 | 2487 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
Setting label groupstatic analysis based on
@jannik_lehmann
's group.added groupstatic analysis label
Setting label(s) devopssecure sectionsec based on groupstatic analysis.
added devopssecure sectionsec labels
- Resolved by Jacques Erasmus
@djadmin Can I ask you to do the initial review on this? Thank you!
requested review from @djadmin
changed milestone to %16.0
added typefeature + 1 deleted label
- Resolved by Jannik Lehmann
removed review request for @djadmin
@djadmin
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@81d74a9c
- Resolved by Jacques Erasmus
@jerasmus Could you maintainer review this MR? Thanks for looking in!
requested review from @jerasmus
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@9ef09ad2
enabled an automatic merge when the pipeline for 9ef09ad2 succeeds
mentioned in commit b9992ad7
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
mentioned in issue #388249 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2061 (merged)
added typemaintenance label and removed typefeature label