Skip to content
Snippets Groups Projects

Remove refactor_code_quality_inline_findings feature-flag

Merged Jannik Lehmann requested to merge jnnkl-remove-codequality-inline-indicator-flag into master
All threads resolved!

What does this MR do and why?

This MR removes the refactor_code_quality_inline_findings since the feature was enabled by default in 15.9 and is now save to remove.

Issue: #388249 (closed)

Screenshots or screen recordings

no visual changes

Demo
Screenshot_2023-04-18_at_15.39.04

How to set up and validate locally

  1. Clone this project in your GDK https://gitlab.com/jannik_lehmann/code-quality-test
  2. Recreate this MR or open up a MR with code Quality Issues yourself
  3. go visit the changes tab on the MR and hover/click the CodeQuality indicator to see the changes in action

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jannik Lehmann

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Dheeraj Joshi approved this merge request

    approved this merge request

  • Dheeraj Joshi removed review request for @djadmin

    removed review request for @djadmin

  • :wave: @djadmin, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Jannik Lehmann added 1 commit

    added 1 commit

    Compare with previous version

  • Jannik Lehmann requested review from @jerasmus

    requested review from @jerasmus

  • Jacques Erasmus approved this merge request

    approved this merge request

  • Jacques Erasmus resolved all threads

    resolved all threads

  • Jacques Erasmus enabled an automatic merge when the pipeline for 9ef09ad2 succeeds

    enabled an automatic merge when the pipeline for 9ef09ad2 succeeds

  • Jacques Erasmus mentioned in commit b9992ad7

    mentioned in commit b9992ad7

  • added workflowstaging label and removed workflowcanary label

  • mentioned in issue #388249 (closed)

  • Donald Cook added typemaintenance label and removed typefeature label

    added typemaintenance label and removed typefeature label

  • 🤖 GitLab Bot 🤖 removed 1 deleted label

    removed 1 deleted label

  • Please register or sign in to reply
    Loading