Add admin_parent_link permission to hide Add button in issue
What does this MR do and why?
The user permission admin_parent_link
will help to hide the add button on an issue in case of guest user.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #387303 (closed)
Merge request reports
Activity
changed milestone to %15.11
assigned to @ramistry
- A deleted user
added backend label
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/api/graphql/reference/index.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Zamir Martins Filho (
@zmartins
) (UTC+0)Rajendra Kadam (
@rkadam3
) (UTC+5.5)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 28943cbd and 15063673
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.62 MB 3.62 MB - 0.0 % mainChunk 2.08 MB 2.08 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
Dangermentioned in issue #387303 (closed)
added 1 commit
- 2a9987a9 - Add admin_parent_link permission to hide Add button in issue
added 1 commit
- 15063673 - Add admin_parent_link permission to hide Add button in issue
mentioned in merge request !117030 (merged)
added 1 commit
- 43b1a124 - Add admin_parent_link permission to hide Add button in issue
added 1 commit
- bb332210 - Add admin_parent_link permission to hide Add button in issue
requested review from @egrieff
Thanks @ramistry LGTM
I've tested it with the following query and I get
true
for reporter andfalse
for guest (as expected)query workItemPermissions { workItem(id: "gid://gitlab/WorkItem/$WORK_ITEM_ID") { title userPermissions { adminParentLink } } }
@jprovaznik would you mind taking the next review, please?
requested review from @jprovaznik and removed review request for @egrieff
@egrieff
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
enabled an automatic merge when the pipeline for 9ab1332f succeeds
mentioned in commit a2be4be7
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in issue gitlab-com/www-gitlab-com#13936 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2061 (merged)