Fix spec violations in group_select_spec
What does this MR do and why?
In regards of epic &5102, this MR fixes the following spec violations in ee/spec/frontend/boards/components/group_select_spec.js
#390960 (closed):
How to set up and validate locally
Run tests:
yarn jest ee/spec/frontend/boards/components/group_select_spec.js
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.11
assigned to @lorenzvanherwaarden
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Andrei Zubov (
@andrei.zubov
) (UTC+2)Anna Vovchenko (
@anna_vovchenko
) (UTC+3)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerHi @deepika.guliani, could you do the initial review? If there are no blockers, please pass along to
@anna_vovchenko
for maintainer review. Thank you!requested review from @deepika.guliani
removed workflowin dev label
added groupproject management label
added devopsplan sectiondev labels
removed devopsplan sectiondev labels
added devopsplan sectiondev labels
- Resolved by Anna Vovchenko
added 1 commit
- 8b4e43f3 - Remove setTimeout in favor of promiseResolve
- Resolved by Anna Vovchenko
Thank you for working on this @lorenzvanherwaarden
LGTM@anna_vovchenko hey
Can you please maintainer-ize this MR ?
requested review from @anna_vovchenko and removed review request for @deepika.guliani
@deepika.guliani
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
- Resolved by Anna Vovchenko
- Resolved by Anna Vovchenko
- Resolved by Anna Vovchenko
enabled an automatic merge when the pipeline for 59f18d8c succeeds
mentioned in commit 236128a8
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label