Skip to content
Snippets Groups Projects

Fix spec violations in group_select_spec

Merged Lorenz van Herwaarden requested to merge fix-spec-violations-group-select-spec into master
All threads resolved!

What does this MR do and why?

In regards of epic &5102, this MR fixes the following spec violations in ee/spec/frontend/boards/components/group_select_spec.js #390960 (closed):

How to set up and validate locally

Run tests:

yarn jest ee/spec/frontend/boards/components/group_select_spec.js

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 8b4e43f3 - Remove setTimeout in favor of promiseResolve

    Compare with previous version

  • Deepika Guliani approved this merge request

    approved this merge request

  • Deepika Guliani requested review from @anna_vovchenko and removed review request for @deepika.guliani

    requested review from @anna_vovchenko and removed review request for @deepika.guliani

  • :wave: @deepika.guliani, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Anna Vovchenko resolved all threads

    resolved all threads

  • added 1 commit

    • ca1724e9 - Apply suggestions regarding default params

    Compare with previous version

  • Anna Vovchenko approved this merge request

    approved this merge request

  • Anna Vovchenko resolved all threads

    resolved all threads

  • Anna Vovchenko enabled an automatic merge when the pipeline for 59f18d8c succeeds

    enabled an automatic merge when the pipeline for 59f18d8c succeeds

  • merged

  • Anna Vovchenko mentioned in commit 236128a8

    mentioned in commit 236128a8

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading