Match the file list impacting assets
What does this MR do and why?
In !115011 (merged) we update the list impacting assets, and we also need to update the rules so when changes apply to Gemfile
we do have updated cached assets from the default branch.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.11
added Engineering Productivity maintenancepipelines labels
assigned to @godfat-gitlab
added typemaintenance label
- A deleted user
added backend label
Pipeline Changes
This merge request contains changes to the pipeline configuration for the GitLab project.
Please consider the effect of the changes in this merge request on the following:
- Effects on different pipeline types
- Effects on non-canonical projects:
gitlab-foss
security
dev
- personal forks
- Effects on pipeline performance
Please consider communicating these changes to the broader team following the communication guideline for pipeline changes
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Pedro Pombeiro (
@pedropombeiro
) (UTC+2, 6 hours behind@godfat-gitlab
)Thong Kuah (
@tkuah
) (UTC+13, 5 hours ahead of@godfat-gitlab
)maintenanceworkflow / maintenancepipelines for CI, Danger Ravi Kumar (
@rkumar555
) (UTC+2, 6 hours behind@godfat-gitlab
)Rémy Coutable (
@rymai
) (UTC+2, 6 hours behind@godfat-gitlab
)Engineering Productivity Reviewer review is optional for Engineering Productivity Ash McKenzie (
@ashmckenzie
) (UTC+11, 3 hours ahead of@godfat-gitlab
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger@ddieulivol Please review? Thank you! /cc @leipert
@godfat-gitlab Looks good to me, thanks!
@godfat-gitlab / @ddieulivol Wonder if we should parse the
rules
from the yaml:see_no_evil:
@leipert I think that'll be fine. I took a quick check, the only thing which is more complex is probably that we need to make sure we respect
FOSS_ONLY
, so that when::Gitlab.ee?
is false, it did not include files underee/
even if the directory does exist with tons of files under it. The same goes to::Gitlab.jh?
. This means we would have a special case for"{,ee/,jh/}app/assets/**/*"
.I don't have anything other than "if it's not breaking, don't touch it" to say :P So sure if it's working I think.
Sounds reasonable. Was just a thought, thanks for checking, @godfat-gitlab!
requested review from @ddieulivol
@ddieulivol
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
enabled an automatic merge when the pipeline for 0d17fa76 succeeds
mentioned in commit 543c538f
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label