Quarantine E2E specs
What does this MR do?
Quarantining multiple specs to make QA pipeline more stable:
-
qa/qa/specs/features/api/1_manage/migration/gitlab_migration_project_spec.rb
- bug Move ProcessScanResultPolicyWorker for multiple... (#403001 - closed), qurantine only on Staging and Production to ensure spec still runs in other envs -
qa/qa/specs/features/api/1_manage/user_access_termination_spec.rb
- bug Move ProcessScanResultPolicyWorker for multiple... (#403001 - closed), qurantine only on Staging and Production to ensure spec still runs in other envs -
qa/qa/specs/features/ee/browser_ui/13_secure/license_compliance_spec.rb
- flaky failure, being investigated at #396962 (closed) -
qa/qa/specs/features/ee/browser_ui/8_monitor/alert_management/alert_with_escalation_policy_spec.rb
- transient bug #397133 (comment 1321347608)
Related discussion #386671 (comment 1333927734)
E2E Test Failure issue(s)
- Failure in api/1_manage/user_access_termination... (#386671 - closed)
- Failure in api/1_manage/migration/gitlab_migrat... (#402400 - closed)
- Failure in ee/browser_ui/13_secure/license_comp... (#396962 - closed)
- Failure in ee/browser_ui/8_monitor/alert_manage... (#397133 - closed)
Check-list
-
General code guidelines check-list -
Quarantine test check-list -
Follow the Quarantining Tests guide. -
Confirm the test has a quarantine:
tag with the specified quarantine type. -
Note if the test should be quarantined for a specific environment. -
(Optionally) In case of an emergency (e.g. blocked deployments), consider adding labels to pick into auto-deploy (Pick into auto-deploy priority1 severity1).
-
-
Dequarantine test check-list -
Follow the Dequarantining Tests guide. -
Confirm the test consistently passes on the target GitLab environment(s).
-
-
To ensure a faster turnaround, ask in the #quality_maintainers
Slack channel for someone to review and merge the merge request, rather than assigning it directly.
Merge request reports
Activity
changed milestone to %15.11
added QA Quality devopscreate maintenancepipelines typemaintenance labels
assigned to @niskhakova
added sectiondev label
1 Warning be5d4991: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer QA Sofia Vistas (
@svistas
) (UTC+3, 1 hour ahead of@niskhakova
)Dan Davison (
@ddavison
) (UTC-4, 6 hours behind@niskhakova
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerRemoved
qa/qa/specs/features/ee/browser_ui/11_fulfillment/saas_user_limit_experience_spec.rb
as the fix is in review already !116053 (merged) :mentioned in issue #397133 (closed)
- Resolved by Tiffany Rea
@treagitlab, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 6 hours ago OR finished more than 2 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to merge when pipeline succeeds.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
mentioned in commit 5884f7b6
mentioned in issue gitlab-org/quality/pipeline-triage#191 (closed)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label