FE: Don't show Design Management elements when user can't edit

changed milestone to %15.11

added Category:Design Management Contractor Contribution devopsplan groupproduct planning maintenanceusability sectiondev severity3 typemaintenance workflowin dev + 1 deleted label

assigned to @ichernob-ext

Hey @ichernob-ext!

Thank you for your contribution to GitLab. Please refer to the contribution flow documentation for a quick overview of the process, and the merge request (MR) guidelines for the detailed process.

Did you know about our community forks? Working from there will make your contribution process easier. Please check it out!

When you're ready for a first review, post @gitlab-bot ready. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with @gitlab-bot ready @user1 @user2.

At any time, if you need help, feel free to post @gitlab-bot help or initiate a mentor session on Discord. Read more on how to get help.

You can comment @gitlab-bot label <label1> <label2> to add labels to your MR. Please see the list of allowed labels in the label command documentation.

This message was generated automatically. You're welcome to improve it.

added Community contribution label

added docs-only label

added 1 commit

2fd6b5dd - Hide design management dropzone when user can't edit

Compare with previous version

added frontend label

1 Message

CHANGELOG missing:

If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog.

If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message.

If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
frontend	Janis Altherr (`@janis`) (UTC+2)	Olena HK. (`@ohoral`) (UTC+3)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

removed Community contribution label

removed docs-only label

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits c0c3de94 and fa52f63f

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.62 MB	3.62 MB	-	0.0 %
mainChunk	2.08 MB	2.08 MB	-	0.0 %

Note: We do not have exact data for c0c3de94. So we have used data from: 55353fa6.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun the bundle-size-review job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

Please look at the full report for more details

Allure report

allure-report-publisher generated test report!

e2e-review-qa: test report for fa52f63f

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Plan             | 49     | 0      | 1       | 0     | 50    | ✅     |
| Create           | 28     | 0      | 1       | 0     | 29    | ✅     |
| Data Stores      | 22     | 0      | 0       | 0     | 22    | ✅     |
| Govern           | 26     | 0      | 5       | 0     | 31    | ✅     |
| Verify           | 12     | 0      | 0       | 2     | 12    | ❗     |
| Manage           | 8      | 0      | 3       | 0     | 11    | ✅     |
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
| Framework sanity | 9      | 0      | 1       | 0     | 10    | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 158    | 0      | 12      | 2     | 170   | ❗     |
+------------------+--------+--------+---------+-------+-------+--------+

added 1 commit

2debd8c1 - Hide design management toolbar when user can't edit

Compare with previous version

marked this merge request as ready

changed title from Draft: Don't show design manager dropzone when user can't edit to FE: Don't show Design Management elements when user can't edit

changed the description

added workflowin review label and removed workflowin dev label

marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

@janis may I ask you to do the review?

requested review from @janis

added 285 commits

2debd8c1...12df8024 - 282 commits from branch master
b1861a0d - Hide design management dropzone when user can't edit
2cac2246 - Hide design management toolbar when user can't edit
fa52f63f - Add tests with mocked Apollo for the design permisions

Compare with previous version

approved this merge request

@janis, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.

For more info, please refer to the following links:

added pipeline:mr-approved label

requested review from @ohoral

removed review request for @janis

mentioned in issue gitlab-com/www-gitlab-com#14556 (closed)

approved this merge request

resolved all threads

merged

@ohoral, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 6 hours ago OR finished more than 2 hours ago, you should:

Ensure the merge request is not in Draft status.
Start a pipeline (especially important for Community contribution merge requests).
Set the merge request to merge when pipeline succeeds.

This is a guideline, not a rule. Please consider replying to this comment for transparency.

This message was generated automatically. You're welcome to improve it.