Remove unused tracking
What does this MR do and why?
In Add Learn GitLab step: "Add File/Code" (#384588 - closed) snowplow tracking commit event was added to the WebIDE. However since in production we use new version of WebIDE, this tracking doesn't generate any events. Considering complexity of tracking implementation for the new WebIDE and it's being separate repository, it was decided to remove this event
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #399096 (closed)
Merge request reports
Activity
changed milestone to %Backlog
assigned to @syarynovskyi
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Suraj Tripathi (
@suraj_tripathy
) (UTC+5.5, 2.5 hours ahead of@syarynovskyi
)Mark Chao (
@lulalala
) (UTC+8, 5 hours ahead of@syarynovskyi
)frontend Elwyn Benson (
@elwyn-gitlab
) (UTC+13, 10 hours ahead of@syarynovskyi
)Andrew Fontaine (
@afontaine
) (UTC-4, 7 hours behind@syarynovskyi
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerchanged milestone to %15.11
added workflowin review label and removed workflowin dev label
- Resolved by Lin Jen-Shin
Hey @samsam_kim and @elwyn-gitlab
added 1 deleted label and removed featureaddition label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits e4cda0eb and 7ae7100a
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.62 MB 3.62 MB - -0.0 % mainChunk 2.08 MB 2.08 MB - 0.0 %
Note: We do not have exact data for e4cda0eb. So we have used data from: 36e61d4a.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 7ae7100aexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Govern | 26 | 0 | 5 | 0 | 31 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Verify | 12 | 0 | 0 | 2 | 12 | ❗ | | Manage | 12 | 0 | 3 | 1 | 15 | ❗ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 162 | 0 | 12 | 3 | 174 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
requested review from @elwyn-gitlab
requested review from @samsam_kim
@elwyn-gitlab
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
requested review from @afontaine and removed review request for @elwyn-gitlab
mentioned in issue gitlab-com/www-gitlab-com#31164 (closed)
removed review request for @afontaine
requested review from @godfat-gitlab and removed review request for @samsam_kim
- Resolved by Lin Jen-Shin
enabled an automatic merge when the pipeline for c78a00cc succeeds
mentioned in commit 3894d553
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label