Application: Remove container limited class
What does this MR do and why?
Removes the limit-container-width
class from the application pages.
Related to the ongoing efforts of Remove «limit-container-width» (#391236)
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
- Create a test application: http://gdk.test:3000/oauth/applications
- View the test app: http://gdk.test:3000/oauth/applications/1
- Edit the test app: http://gdk.test:3000/oauth/applications/1/edit
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.11
added UX UX Paper Cuts frontend groupux paper cuts maintenanceusability sectiondev severity4 typemaintenance + 1 deleted label
assigned to @seggenberger
requested review from @annabeldunstone
- Resolved by Annabel Dunstone Gray
@annabeldunstone another one from the Remove «limit-container-width» (#391236) series
- A deleted user
added backend label
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Thomas Hutterer (
@thutterer
) (UTC+1, same timezone as@seggenberger
)Bojan Marjanović (
@bmarjanovic
) (UTC+1, same timezone as@seggenberger
)frontend Ankit Panchal (
@ankit.panchal
) (UTC+5.5, 4.5 hours ahead of@seggenberger
)Simon Knox (
@psimyn
) (UTC+11, 10 hours ahead of@seggenberger
)UX Becka Lippert (
@beckalippert
) (UTC-5, 6 hours behind@seggenberger
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in merge request !115716 (merged)
- Resolved by Simon Knox
requested review from @thutterer and @ankit.panchal
removed review request for @annabeldunstone
@annabeldunstone
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @ankit.panchal
requested review from @psimyn
@psimyn, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 6 hours ago OR finished more than 2 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to merge when pipeline succeeds.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
mentioned in commit 53be5b38
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2061 (merged)
mentioned in issue gitlab-com/www-gitlab-com#32488 (closed)