Decrease gap between MR content and sidebar
What does this MR do and why?
- Decrease gap between MR content and sidebar
- Remove
...to administrator
from "Report abuse" button (it looks buggy when it wraps, plus it opens a drawer that says "Report abuse to administrator") - Increase space below "Activity" header
- Use tertiary button for "Resolve conflicts"
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
- Look at MR page (with
:moved_mr_sidebar
enabled)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.11
added UX UX Paper Cuts frontend maintenanceusability typemaintenance labels
assigned to @annabeldunstone
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Nataliia Radina (
@nradina
) (UTC+2, 2 hours ahead of@annabeldunstone
)Phil Hughes (
@iamphill
) (UTC+1, 1 hour ahead of@annabeldunstone
)test for spec/features/*
Mario Celi (
@mcelicalderonG
) (UTC+2, 2 hours ahead of@annabeldunstone
)Maintainer review is optional for test for spec/features/*
UX Matthew Nearents (
@mnearents
) (UTC-7, 7 hours behind@annabeldunstone
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Annabel Dunstone Gray
@seggenberger More small changes!
requested review from @seggenberger
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits a21e1dbb and 718c306b
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.62 MB 3.62 MB - 0.0 % mainChunk 2.08 MB 2.08 MB - 0.0 %
Note: We do not have exact data for a21e1dbb. So we have used data from: e93919f8.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 718c306bexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | | Manage | 12 | 0 | 3 | 1 | 15 | ❗ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Verify | 12 | 0 | 0 | 2 | 12 | ❗ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 26 | 0 | 5 | 0 | 31 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 162 | 0 | 12 | 3 | 174 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
added 74 commits
-
bb6e551b...5466c598 - 73 commits from branch
master
- 863ca158 - Fix small UI inconsistencies in MR view
-
bb6e551b...5466c598 - 73 commits from branch
- Resolved by Annabel Dunstone Gray
mentioned in issue #398659 (closed)
- Resolved by Zack Cuddy
@seggenberger Can you please review/approve?
requested review from @nradina
@nradina
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
requested review from @zcuddy
- Resolved by Zack Cuddy
@zcuddy will you please continue as a maintainer?
added 1086 commits
-
1e00ad1c...653375c6 - 1085 commits from branch
master
- 718c306b - Fix small UI inconsistencies in MR view
-
1e00ad1c...653375c6 - 1085 commits from branch
enabled an automatic merge when the pipeline for 087cfe7c succeeds
mentioned in commit 071ee305
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2061 (merged)