Fix border radius on pending comments
What does this MR do and why?
Fixes border radius on pending comment (probably resulted from Fix border radius on collapsed replies in diffs (!114037 - merged)
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Go to MR > Changes tab
- Start comment on line of code, choose
Start review
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.10
added UX UX Paper Cuts frontend maintenanceusability typemaintenance labels
assigned to @annabeldunstone
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
- Resolved by Vitaly Slobodin
2 Warnings ⚠ This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.⚠ You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Artur Fedorov (
@arfedoro
) (UTC+1, 1 hour ahead of@annabeldunstone
)Vitaly Slobodin (
@vitallium
) (UTC+1, 1 hour ahead of@annabeldunstone
)UX Philip Joyce (
@philipjoyce
) (UTC+0, same timezone as@annabeldunstone
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 Danger
requested review from @philipjoyce
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits d9540ac9 and ca1bf27e
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.54 MB 3.54 MB - 0.0 % mainChunk 2.04 MB 2.04 MB - 0.0 %
Note: We do not have exact data for d9540ac9. So we have used data from: 521da864.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
❗ test report for ca1bf27eexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Manage | 34 | 0 | 3 | 1 | 37 | ❗ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Verify | 12 | 0 | 0 | 2 | 12 | ❗ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | | Govern | 27 | 0 | 5 | 5 | 32 | ❗ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 163 | 0 | 12 | 8 | 175 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
requested review from @tbulva
👋 @tbulva
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @tbulva
removed review request for @philipjoyce
requested review from @vitallium
mentioned in issue gitlab-com/www-gitlab-com#13866 (closed)
enabled an automatic merge when the pipeline for 3931d2e5 succeeds
mentioned in commit 87e8f8bf
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging-canary label and removed workflowcanary label
added workflowstaging label and removed workflowstaging-canary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1990 (merged)
mentioned in merge request !123763 (merged)