Show custom header logo on super sidebar header

What does this MR do and why?

In the current navigation, the tanuki logo can be customized by uploading a custom image under Admin > Appearance > Navigation Bar. However, the new super sidebar does not adapt to the custom logo.

Screenshots or screen recordings

How to set up and validate locally

1. Open rails console and enable super_sidebar_nav feature flag using the following commands:

   Feature.enable(:super_sidebar_nav)

2. In the dropdown menu inside the user's avatar, toggle New Navigation.
3. Go to /admin/application_settings/appearance and upload a custom logo.
4. Save the changes by clicking the update appearance settings button.
5. Go to / and the tanuki logo should now be replaced with the custom logo.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

Implements #393533 (closed)

added typefeature label

Hey @ShaneMaglangit!

Thank you for your contribution to GitLab. Please refer to the contribution flow documentation for a quick overview of the process, and the merge request (MR) guidelines for the detailed process.

When you're ready for a first review, post @gitlab-bot ready. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with @gitlab-bot ready @user1 @user2.

At any time, if you need help, feel free to post @gitlab-bot help or initiate a mentor session on Discord. Read more on how to get help.

You can comment @gitlab-bot label <label1> <label2> to add labels to your MR. Please see the list of allowed labels in the label command documentation.

This message was generated automatically. You're welcome to improve it.

added Community contribution workflowin dev labels

assigned to @ShaneMaglangit

	3 Warnings
	948fd3ab: The commit subject must not end with a period. For more information, take a look at our Commit message guidelines.
	This merge request changed files with disabled eslint rules. Please consider fixing them.
	This Merge Request needs to be labelled with backend. Please request a reviewer or maintainer to add them.

Disabled eslint rules

The following files have disabled eslint rules. Please consider fixing them:

• app/assets/javascripts/super_sidebar/components/user_bar.vue

Run the following command for more details

node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \
  'app/assets/javascripts/super_sidebar/components/user_bar.vue'

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Avielle Wolfe (@avielle) (UTC+1)	Dylan Griffith (@DylanGriffith) (UTC+11)
frontend	Rahul Chanila (@rchanila) (UTC+11)	Coung Ngo (@cngo) (UTC+0)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

added 1 commit

• 149c8af6 - Add safe navigation to header_logo_path for super sidebar context

Compare with previous version

changed the description

changed the description

mentioned in issue gitlab-org/quality/triage-reports#11475 (closed)

mentioned in issue gitlab-org/quality/triage-reports#11496 (closed)

changed the description

added 249 commits

• 149c8af6...67062fe1 - 247 commits from branch gitlab-org:master
• 4e9127a2 - Merge branch 'master' into 393533-handle-custom-header-logo-in-new-navigation
• bfbccd35 - Add test to check if custom branding logo is rendered correctly.

Compare with previous version

added 1 commit

• 948fd3ab - Add test to check if custom branding logo is rendered correctly.

Compare with previous version

@gitlab-bot ready @samdbeckham.

Figured out how to sort the test out lfg! I would appreciate your reviews

added workflowready for review label and removed workflowin dev label

@deepika.guliani, this Community contribution is ready for review.

• Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
• Add the workflowin dev label if the merge request needs action from the author. This message was generated automatically. You're welcome to improve it.

requested review from @deepika.guliani

changed milestone to %15.10

added devopsmanage label

added sectiondev label

added frontend label and removed sectiondev label

added sectiondev label

added bugux groupfoundations typebug labels and removed typefeature label

Thank you for working on this @ShaneMaglangit I have left a small suggestion , please let me know what you think

Please add me as a reviewer whenever you are done, back to you

removed review request for @deepika.guliani

Hi @deepika.guliani

We noticed this MR is marked as workflowready for review but no reviewer is assigned. A MR in workflowready for review should always have a reviewer assigned. Did you forget to assign another reviewer or relabel workflowin dev?

@ShaneMaglangit you are welcome to relabel by commenting @gitlab-bot ready for example.

This message was generated automatically. You're welcome to improve it.

added workflowin dev label and removed workflowready for review label

added 1 commit

• e9f6dff6 - Update spec to use test-id for custom header logo

Compare with previous version

@gitlab-bot ready @deepika.guliani

added workflowready for review label and removed workflowin dev label

requested review from @deepika.guliani

@deepika.guliani, this Community contribution is ready for review.

• Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
• Add the workflowin dev label if the merge request needs action from the author. This message was generated automatically. You're welcome to improve it.

requested review from @cngo and removed review request for @deepika.guliani

added 1 commit

• 97f26f6a - Remove unused logo ID on super sidebar header

Compare with previous version

resolved all threads

approved this merge request

@cngo, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.

For more info, please refer to the following links:

• rspec predictive jobs
• jest predictive jobs
• merging a merge request.

added pipeline:mr-approved label

resolved all threads

enabled an automatic merge when the pipeline for 98602ff2 succeeds

canceled the automatic merge

enabled an automatic merge when the pipeline for 98602ff2 succeeds

added backend label

	2 Warnings
	948fd3ab: The commit subject must not end with a period. For more information, take a look at our Commit message guidelines.
	This merge request changed files with disabled eslint rules. Please consider fixing them.

Disabled eslint rules

The following files have disabled eslint rules. Please consider fixing them:

• app/assets/javascripts/super_sidebar/components/user_bar.vue

Run the following command for more details

node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \
  'app/assets/javascripts/super_sidebar/components/user_bar.vue'

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Madelein van Niekerk (@maddievn) (UTC+2)	Allen Cook (@acook.gitlab) (UTC-4)
frontend	Chad Woolley (@cwoolley-gitlab) (UTC-7)	Coung Ngo (@cngo) (UTC+0)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 12f325d2 and 97f26f6a

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.54 MB	3.54 MB	-	0.0 %
mainChunk	2.04 MB	2.04 MB	-	0.0 %

---

Note: We do not have exact data for 12f325d2. So we have used data from: deed59e8.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.

Please look at the full report for more details

---

Read more about how this report works.

Generated by Danger

Allure report

allure-report-publisher generated test report!

e2e-review-qa: test report for 97f26f6a

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Govern           | 27     | 0      | 5       | 5     | 32    | ❗     |
| Verify           | 12     | 0      | 0       | 1     | 12    | ❗     |
| Plan             | 48     | 1      | 1       | 0     | 50    | ❌     |
| Create           | 28     | 0      | 1       | 0     | 29    | ✅     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
| Manage           | 34     | 0      | 3       | 1     | 37    | ❗     |
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
| Framework sanity | 9      | 0      | 1       | 0     | 10    | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 162    | 1      | 12      | 7     | 175   | ❌     |
+------------------+--------+--------+---------+-------+-------+--------+

merged

mentioned in commit b73b6650

@ShaneMaglangit, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

1. React with a or a on this comment to describe your experience.
2. Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

Interested in learning more tips and tricks to solve your next challenge faster? Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.

Thanks for your help!

This message was generated automatically. You're welcome to improve it.

added workflowstaging-canary label and removed workflowready for review label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

added releasedcandidate label

added releasedpublished label and removed releasedcandidate label