Super sidebar: Render pill badges on menu items

assigned to @leipert

1 Warning

⚠

featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.

For more information, see:

The Handbook page on merge request types.
The definition of done documentation.

1 Message

📖

CHANGELOG missing:

If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog.

If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message.

If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Tiger Watson (`@tigerwnz`) (UTC+11, 10 hours ahead of `@leipert`)	Doug Stull (`@dstull`) (UTC-5, 6 hours behind `@leipert`)
frontend	Sharmad Nachnolkar (`@snachnolkar`) (UTC+5.5, 4.5 hours ahead of `@leipert`)	Ezekiel Kigbo (`@ekigbo`) (UTC+11, 10 hours ahead of `@leipert`)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the 🔁 danger-review job that generated this comment.

Generated by 🚫 Danger

Proper labels assigned to this merge request. Please ignore me.

👋 @leipert - please see the following guidance and update this merge request.

	1 Error
❌	Please add typebug typefeature, or typemaintenance label to this merge request.

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits b78141dc and 00de63fb

✨ Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.5 MB	3.5 MB	-	0.0 %
mainChunk	2 MB	2 MB	-	0.0 %

Note: We do not have exact data for b78141dc. So we have used data from: d769bb00.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.

Please look at the full report for more details

Allure report

allure-report-publisher generated test report!

e2e-review-qa: ❗ test report for 00de63fb

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Plan             | 49     | 0      | 1       | 0     | 50    | ✅     |
| Manage           | 34     | 0      | 3       | 0     | 37    | ✅     |
| Verify           | 12     | 0      | 0       | 1     | 12    | ❗     |
| Govern           | 27     | 0      | 5       | 5     | 32    | ❗     |
| Framework sanity | 9      | 0      | 1       | 0     | 10    | ✅     |
| Create           | 28     | 0      | 1       | 0     | 29    | ✅     |
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 163    | 0      | 12      | 6     | 175   | ❗     |
+------------------+--------+--------+---------+-------+-------+--------+

added 1 commit

b3ccdf86 - Super sidebar: Render pill badges on menu items

Compare with previous version

mentioned in merge request !112817 (closed)

changed milestone to %15.10

added Category:Navigation & Settings devopsmanage feature flag featureenhancement groupfoundations sectiondev typefeature labels

resolved all threads

added 5 commits

4727b7bf - Foundations for Super Sidebar categories
c165cdfd - Super Sidebar: Add uncategorized and removals
d53753ce - Project Super Sidebar: Add static section
18582688 - Super sidebar: Project > Operations menu section
791d98af - Super sidebar: Render pill badges on menu items

Compare with previous version

changed the description

changed target branch from master to leipert-project-menu-category-first-iteration

added 1 commit

388f6341 - Super sidebar: Render pill badges on menu items

Compare with previous version

added 4 commits

388f6341...1428c962 - 3 commits from branch leipert-project-menu-category-first-iteration
151c6de8 - Super sidebar: Render pill badges on menu items

Compare with previous version

deleted the leipert-project-menu-category-first-iteration branch. This merge request now targets the master branch

resolved all threads

added 650 commits

151c6de8...99a1de8a - 649 commits from branch master
456c5bc2 - Super sidebar: Render pill badges on menu items

Compare with previous version

changed the description

@thutterer / @jrushford Could you do the initial review for backend / frontend respectively? Thank you!

/

requested review from @thutterer and @jrushford

added workflowin review label

approved this merge request

👋 @thutterer, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

For more info, please refer to the following links:

added pipeline:mr-approved label

@acook.gitlab Hi Allen, can you please backend maintainer review this? Thanks!

@leipert A couple of optional questions, but otherwise looks good to me, I'll approve incase you want to move it to a maintainer directly

approved this merge request

added 1 commit

00de63fb - Super sidebar: Render pill badges on menu items

Compare with previous version

requested review from @jannik_lehmann

Question of understanding (blocking):

One thought that just crossed my mind reading through the different lines where we do type-checking on the value in the pill. What if this value ever is negative?

This case would obviously be a bug but in the current state of this we would (if I'm not overseeing sth) displaying it. So I'm wondering if this a valid test-case to add or rather overengineering it? 🤔 Curious about your thoughts on this @leipert

@leipert Great work! Was able to reproduce this locally and it's working 👍 I do have one question regarding a potential test-gap. Thanks for looking in 🙇