Fix Projects/Groups dropdown item remove button alignment
What does this MR do and why?
Fixes a misalignment on Frequent Projects/Groups remove button by using CSS transform
instead of top
when using absolute positioning.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.9
added UI polish UX devopsmanage frontend groupfoundations typebug labels
assigned to @kushalpandya
added sectiondev label
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
2 Warnings If you are in a revert MR, consider using the revert MR template to add labels to skip changelog checks (docs). If this is reverting something in the current milestone, we don't need to add a changelog. In this case, we can skip changelog checks by adding
~"regression:*"
label, and re-run the danger job (there is a link at the bottom of this comment).You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Hinam Mehra (
@hmehra
) (UTC+11, 5.5 hours ahead of@kushalpandya
)Coung Ngo (
@cngo
) (UTC+0, 5.5 hours behind@kushalpandya
)UX Nick Leonard (
@nickleonard
) (UTC-6, 11.5 hours behind@kushalpandya
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in merge request !108205 (merged)
- Resolved by Kushal Pandya
@seggenberger Can you review UX here please?
requested review from @seggenberger
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
added bugux label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 9ed00d01 and a9efbd26
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.55 MB 3.55 MB - 0.0 % mainChunk 1.95 MB 1.95 MB - 0.0 %
Note: We do not have exact data for 9ed00d01. So we have used data from: 02cbbd2f.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for a9efbd26expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Manage | 33 | 0 | 3 | 0 | 36 | ✅ | | Verify | 12 | 0 | 0 | 0 | 12 | ✅ | | Govern | 28 | 0 | 5 | 0 | 33 | ✅ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 163 | 0 | 12 | 0 | 175 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
@seggenberger
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @seggenberger
- Resolved by Natalia Tepluhina
@ntepluhina Since you merged the original MR, can you review and merge this one too please?
requested review from @ntepluhina
enabled an automatic merge when the pipeline for cf745100 succeeds
mentioned in commit 0d2048c7
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1922 (merged)
added releasedpublished label and removed releasedcandidate label