Skip to content
Snippets Groups Projects

Add a Tag Name filter to the Incident Timeline API

7 unresolved threads
1 file
+ 7
20
Compare changes
  • Side-by-side
  • Inline
@@ -63,13 +63,10 @@
end
end
describe '.with_tag' do
describe '.with_tag_name' do
let(:tag_name) { nil }
let_it_be(:timeline_event2) do
create(:incident_management_timeline_event, project: project, incident: incident)
end
let_it_be(:timeline_event3) do
let_it_be(:timeline_event_with_tag) do
create(:incident_management_timeline_event, project: project, incident: incident)
end
@@ -77,32 +74,22 @@
create(:incident_management_timeline_event_tag, project: project)
end
let_it_be(:timeline_event_tag2) do
create(:incident_management_timeline_event_tag, project: project, name: 'Start time')
end
let_it_be(:timeline_event_tag_link) do
create(:incident_management_timeline_event_tag_link,
timeline_event: timeline_event,
timeline_event: timeline_event_with_tag,
timeline_event_tag: timeline_event_tag)
end
let_it_be(:timeline_event_tag_link2) do
create(:incident_management_timeline_event_tag_link,
timeline_event: timeline_event2,
timeline_event_tag: timeline_event_tag2)
end
subject { described_class.with_tag(tag_name: tag_name) }
subject() { described_class.with_tag_name(tag_name: tag_name) }
context 'without tag name filter' do
it { is_expected.to eq([timeline_event, timeline_event2, timeline_event3]) }
it { is_expected.to match_array([timeline_event, timeline_event_with_tag]) }
end
context 'with tag name filter' do
let(:tag_name) { 'Start time' }
let(:tag_name) { 'Start time' } # The default tag name, as specified in the factory
it { is_expected.to eq([timeline_event2]) }
it { is_expected.to match_array([timeline_event_with_tag]) }
end
end
Loading