Skip to content
Snippets Groups Projects

Handle dismiss finding logic

Merged Savas Vedova requested to merge 386012-dismiss-finding into master
1 unresolved thread

What does this MR do and why?

Handles logic for dismissing a vulnerability.

Screenshots or screen recordings

dismiss-vuln

How to set up and validate locally

Requirements:

  1. You'll need an EE License
  2. You'll need to have runners enabled (See $2408961 for setting up a runner)
  3. Enable :refactor_security_extension to turn this feature on.
echo "Feature.enable(:refactor_security_extension)" | rails c

Steps:

  1. Import https://gitlab.com/gitlab-examples/security/security-reports
  2. Create a new MR by modifying a file
  3. Toggle security reports
  4. Click on a finding name
  5. Dismiss the vulnerability from the modal

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #386012 (closed)

Edited by Savas Vedova

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Savas Vedova
  • Savas Vedova
  • Savas Vedova
  • Savas Vedova
  • Savas Vedova added 107 commits

    added 107 commits

    Compare with previous version

  • Samantha Ming
  • Samantha Ming
  • Samantha Ming approved this merge request

    approved this merge request

  • Samantha Ming removed review request for @sming-gitlab

    removed review request for @sming-gitlab

  • :wave: @sming-gitlab, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Savas Vedova requested review from @aturinske

    requested review from @aturinske

  • Alexander Turinske approved this merge request

    approved this merge request

  • Alexander Turinske resolved all threads

    resolved all threads

  • Alexander Turinske enabled an automatic merge when the pipeline for cb01e3c3 succeeds

    enabled an automatic merge when the pipeline for cb01e3c3 succeeds

  • Savas Vedova aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • Savas Vedova added 293 commits

    added 293 commits

    Compare with previous version

  • Savas Vedova enabled an automatic merge when the pipeline for f4af0b71 succeeds

    enabled an automatic merge when the pipeline for f4af0b71 succeeds

  • Savas Vedova aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • Savas Vedova added 1 commit

    added 1 commit

    • 27d11772 - Handle dismiss finding logic

    Compare with previous version

  • Savas Vedova enabled an automatic merge when the pipeline for d232f3ae succeeds

    enabled an automatic merge when the pipeline for d232f3ae succeeds

  • merged

  • Savas Vedova mentioned in commit ea4660ce

    mentioned in commit ea4660ce

  • added workflowstaging label and removed workflowcanary label

  • Savas Vedova resolved all threads

    resolved all threads

  • mentioned in issue #378353 (closed)

  • Please register or sign in to reply
    Loading