Skip to content
Snippets Groups Projects

Draft: GitLab UI integration branch for 1904-charts-add-space-between-toolbox-and-chart

1 unresolved thread

Integration MR for gitlab-ui!3186 (merged).

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • A deleted user added frontend label

    added frontend label

  • 1 Error
    :no_entry_sign: The merge request title may not be longer than 72 characters. For more information, take a look at our Commit message guidelines.
    4 Warnings
    :warning: 190a42df: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines.
    :warning: Please add a merge request subtype to this merge request.
    :warning: Please add a merge request type to this merge request.
    :warning: This merge request does not refer to an existing milestone.
    1 Message
    :book: CHANGELOG missing:

    If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog.

    If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    frontend Deepika Guliani current availability (@deepika.guliani) (UTC+5.5, 10.5 hours ahead of @pgascouvaillancourt) Coung Ngo current availability (@cngo) (UTC+0, 5 hours ahead of @pgascouvaillancourt)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits ebd9bf5d and 190a42df

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    mainChunk 1.86 MB 1.94 MB +83.6 KB 4.4 %
    average 3.45 MB 3.5 MB +42.48 KB 1.2 %

    :fearful: Significant Growth: 5

    Expand
    Entrypoint / Name Size before Size after Diff Diff in percent
    pages.dashboard.milestones.show 616.6 KB 682.8 KB +66.2 KB 10.7 %
    pages.projects.branches.index 1.03 MB 1.07 MB +37.91 KB 3.6 %
    pages.groups.observability.dashboards 105.65 KB 117.19 KB +11.53 KB 10.9 %
    pages.groups.observability.explore 105.65 KB 117.19 KB +11.53 KB 10.9 %
    pages.groups.observability.manage 105.65 KB 117.19 KB +11.53 KB 10.9 %

    :new: New entry points: 1

    Expand
    Entrypoint / Name Size before Size after Diff Diff in percent
    pages.web_ide.remote_ide 0 Bytes 6.62 KB +6.62 KB 100.0 %

    :tada: Significant Reduction: 182

    Expand
    Entrypoint / Name Size before Size after Diff Diff in percent
    pages.projects.settings.ci_cd.show 2.93 MB 2.74 MB -202.42 KB -6.7 %
    pages.projects.licenses.index 2.24 MB 2.05 MB -198.37 KB -8.6 %
    pages.projects.settings.repository.create_deploy_token 1.39 MB 1.26 MB -125.95 KB -8.9 %
    pages.projects.settings.repository.show 1.39 MB 1.26 MB -125.95 KB -8.9 %
    pages.projects.settings.merge_requests 2.19 MB 2.07 MB -123.9 KB -5.5 %
    pages.projects.shared.web_ide_link 991.92 KB 910.67 KB -81.25 KB -8.2 %
    pages.groups.registry.repositories 1.26 MB 1.19 MB -75.56 KB -5.9 %
    pages.projects.registry.repositories 1.43 MB 1.36 MB -75.56 KB -5.2 %
    jira_connect_app 371.83 KB 297.21 KB -74.63 KB -20.1 %
    pages.admin.applications 91.02 KB 16.4 KB -74.63 KB -82.0 %

    The table above is limited to 10 entries. Please look at the full report for more details


    Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.

    Please consider pinging someone from the FE Foundations (@leipert, @markrian, @mikegreiling, @ohoral or @pgascouvaillancourt) for review, if you are unsure about the size increase.

    Note: We do not have exact data for ebd9bf5d. So we have used data from: f257619d.
    The target commit was too new, so we used the latest commit from master we have info on.
    It might help to rerun the bundle-size-review job
    This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Allure report

    allure-report-publisher generated test report!

    e2e-review-qa: :exclamation: test report for 190a42df

    expand test summary
    +-----------------------------------------------------------------------------------------+
    |                                     suites summary                                      |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    |                                    | passed | failed | skipped | flaky | total | result |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Version sanity check               | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Create                             | 28     | 0      | 1       | 0     | 29    | ✅     |
    | Govern                             | 15     | 0      | 5       | 2     | 20    | ❗     |
    | Manage                             | 39     | 0      | 4       | 2     | 43    | ❗     |
    | Plan                               | 49     | 0      | 1       | 0     | 50    | ✅     |
    | Verify                             | 12     | 0      | 1       | 0     | 13    | ✅     |
    | Package                            | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Feature flag handler sanity checks | 9      | 0      | 0       | 0     | 9     | ✅     |
    | Configure                          | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Total                              | 152    | 0      | 15      | 4     | 167   | ❗     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :exclamation: test report for 190a42df

    expand test summary
    +---------------------------------------------------------------------------+
    |                              suites summary                               |
    +----------------------+--------+--------+---------+-------+-------+--------+
    |                      | passed | failed | skipped | flaky | total | result |
    +----------------------+--------+--------+---------+-------+-------+--------+
    | Create               | 818    | 0      | 27      | 0     | 845   | ✅     |
    | Package              | 144    | 0      | 37      | 0     | 181   | ✅     |
    | Verify               | 264    | 0      | 17      | 5     | 281   | ❗     |
    | Manage               | 361    | 0      | 27      | 0     | 388   | ✅     |
    | Plan                 | 312    | 0      | 0       | 0     | 312   | ✅     |
    | Govern               | 214    | 0      | 0       | 0     | 214   | ✅     |
    | Secure               | 15     | 0      | 25      | 12    | 40    | ❗     |
    | Release              | 30     | 0      | 0       | 0     | 30    | ✅     |
    | Monitor              | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Version sanity check | 0      | 0      | 7       | 6     | 7     | ➖     |
    | Configure            | 1      | 0      | 15      | 0     | 16    | ✅     |
    | Analytics            | 11     | 0      | 0       | 0     | 11    | ✅     |
    | Fulfillment          | 10     | 0      | 70      | 0     | 80    | ✅     |
    | ModelOps             | 0      | 0      | 5       | 0     | 5     | ➖     |
    | GitLab Metrics       | 2      | 0      | 1       | 0     | 3     | ✅     |
    | Systems              | 3      | 0      | 0       | 0     | 3     | ✅     |
    | Data Stores          | 13     | 0      | 1       | 0     | 14    | ✅     |
    +----------------------+--------+--------+---------+-------+-------+--------+
    | Total                | 2203   | 0      | 232     | 23    | 2435  | ❗     |
    +----------------------+--------+--------+---------+-------+-------+--------+
Please register or sign in to reply
Loading