Fix ToolWithVendorFilter querystring key
What does this MR do and why?
This MR fixes the querystring key for ToolWithVendorFilter
that's shown on the project-level vulnerability report. The deprecated ScannerFilter
was using scanner
for its querystring key (?scanner=GitLab.SAST
), but ToolWithVendorFilter
incorrectly uses reportType
(?reportType=GitLab.SAST
). This means that every existing bookmark to a project-level report that has tools selected will break, and will default to All tools
.
Though we should eventually use reportType
for the querystring key because that's what the other tool filters use, we need to fix ToolWithVendorFilter
for now.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #376337 (closed)
Merge request reports
Activity
changed milestone to %15.7
assigned to @dftian
@sming-gitlab Would you mind doing the initial review for this one?
requested review from @sming-gitlab
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Sharmad Nachnolkar (
@snachnolkar
) (UTC+5.5, 15.5 hours ahead of@dftian
)Justin Ho (
@justin_ho
) (UTC+7, 17 hours ahead of@dftian
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 952324ff and c3d3a594
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.45 MB 3.45 MB - -0.0 % mainChunk 1.86 MB 1.86 MB - -0.0 % Significant Growth: 10Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.dashboard.milestones.show 616.6 KB 757.28 KB +140.68 KB 22.8 % pages.projects.branches.index 1.03 MB 1.14 MB +109.7 KB 10.4 % pages.groups.milestones.edit 1.67 MB 1.77 MB +100.6 KB 5.9 % pages.groups.milestones.new 1.67 MB 1.77 MB +100.6 KB 5.9 % pages.projects.milestones.edit 1.78 MB 1.87 MB +100.6 KB 5.5 % pages.projects.milestones.index 1.78 MB 1.87 MB +100.6 KB 5.5 % pages.projects.milestones.new 1.78 MB 1.87 MB +100.6 KB 5.5 % pages.groups.observability.dashboards 105.65 KB 117.75 KB +12.1 KB 11.5 % pages.groups.observability.explore 105.65 KB 117.75 KB +12.1 KB 11.5 % pages.groups.observability.manage 105.65 KB 117.75 KB +12.1 KB 11.5 % New entry points: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.web_ide.remote_ide 0 Bytes 6.62 KB +6.62 KB 100.0 % Significant Reduction: 5Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.settings.ci_cd.show 2.93 MB 2.81 MB -130.61 KB -4.3 % pages.projects.licenses.index 2.24 MB 2.12 MB -123.73 KB -5.4 % pages.projects.settings.merge_requests 2.19 MB 2.14 MB -52.11 KB -2.3 % pages.projects.settings.repository.create_deploy_token 1.39 MB 1.33 MB -51.32 KB -3.6 % pages.projects.settings.repository.show 1.39 MB 1.33 MB -51.32 KB -3.6 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@leipert
,@markrian
,@mikegreiling
,@ohoral
or@pgascouvaillancourt
) for review, if you are unsure about the size increase.Note: We do not have exact data for 952324ff. So we have used data from: f257619d.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for c3d3a594expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Verify | 12 | 0 | 1 | 0 | 13 | ✅ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Govern | 13 | 0 | 5 | 1 | 18 | ❗ | | Manage | 39 | 0 | 4 | 2 | 43 | ❗ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 150 | 0 | 15 | 3 | 165 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Daniel Tian
requested review from @svedova and removed review request for @sming-gitlab
@sming-gitlab
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
enabled an automatic merge when the pipeline for 43553171 succeeds
mentioned in commit b1faa20d
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label