Skip to content
Snippets Groups Projects

Remove valid IDs prop for QuerystringSync component

Closed Daniel Tian requested to merge 383346-remove-valid-ids-check into master
1 unresolved thread

What does this MR do and why?

This MR removes the validIds prop for the QuerystringSync component. It was intended as a way to remove invalid IDs on the querystring, but it's too narrow in scope and only works for a few vulnerability report filters. The valid ID check and cleanup will be handled another way in a different MR.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #383346 (closed)

Edited by Daniel Tian

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • assigned to @dftian

  • A deleted user added frontend label

    added frontend label

  • 4 Warnings
    :warning: 2a3fd3c2: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
    :warning: Please add a merge request subtype to this merge request.
    :warning: Please add a merge request type to this merge request.
    :warning: This merge request does not refer to an existing milestone.
    1 Message
    :book: CHANGELOG missing:

    If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog.

    If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    frontend Axel García current availability (@agarciatesares) (UTC-3, 7 hours ahead of @dftian) Jannik Lehmann current availability (@jannik_lehmann) (UTC+1, 11 hours ahead of @dftian)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Daniel Tian marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • removed frontend label

  • Daniel Tian requested review from @sming-gitlab

    requested review from @sming-gitlab

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 9a20b845 and 2a3fd3c2

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 3.45 MB 3.45 MB - -0.0 %
    mainChunk 1.86 MB 1.86 MB - 0.0 %

    :tada: Significant Reduction: 3

    Expand
    Entrypoint / Name Size before Size after Diff Diff in percent
    pages.projects.settings.merge_requests 2.19 MB 2.14 MB -52.11 KB -2.3 %
    pages.projects.settings.repository.create_deploy_token 1.39 MB 1.33 MB -51.32 KB -3.6 %
    pages.projects.settings.repository.show 1.39 MB 1.33 MB -51.32 KB -3.6 %

    Note: We do not have exact data for 9a20b845. So we have used data from: f257619d.
    The target commit was too new, so we used the latest commit from master we have info on.
    It might help to rerun the bundle-size-review job
    This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Allure report

    allure-report-publisher generated test report!

    e2e-review-qa: :exclamation: test report for 2a3fd3c2

    expand test summary
    +-----------------------------------------------------------------------------------------+
    |                                     suites summary                                      |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    |                                    | passed | failed | skipped | flaky | total | result |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Plan                               | 49     | 0      | 1       | 0     | 50    | ✅     |
    | Create                             | 28     | 0      | 1       | 0     | 29    | ✅     |
    | Govern                             | 13     | 0      | 5       | 1     | 18    | ❗     |
    | Manage                             | 39     | 0      | 4       | 2     | 43    | ❗     |
    | Package                            | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Verify                             | 12     | 0      | 1       | 0     | 13    | ✅     |
    | Configure                          | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Version sanity check               | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Feature flag handler sanity checks | 9      | 0      | 0       | 0     | 9     | ✅     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Total                              | 150    | 0      | 15      | 3     | 165   | ❗     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
  • Daniel Tian removed review request for @sming-gitlab

    removed review request for @sming-gitlab

  • Author Developer

    @sming-gitlab Would you be able to review this one? :bow:

  • Daniel Tian requested review from @sming-gitlab

    requested review from @sming-gitlab

  • Daniel Tian added 63 commits

    added 63 commits

    Compare with previous version

  • A deleted user added frontend label

    added frontend label

  • closed

Please register or sign in to reply
Loading