Skip to content
Snippets Groups Projects

Refactor Severity Icons Mr Widget naming

Merged Jannik Lehmann requested to merge jnnkl-refactor-Severity-icons-naming into master
All threads resolved!

What does this MR do and why?

This MR solves #382758 (closed) it refactors the naming of the severity icons used for the Codequality MR Widget.

Screenshots or screen recordings

No visual changes.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jannik Lehmann

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • A deleted user added frontend label

    added frontend label

  • 1 Warning
    :warning: You've made some app changes, but didn't add any tests.
    That's OK as long as you're refactoring existing code,
    but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    frontend Tomáš Bulva current availability (@tbulva) (UTC+1, same timezone as @jannik_lehmann) Jose Ivan Vargas current availability (@jivanvl) (UTC-6, 7 hours behind @jannik_lehmann)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 06c724a9 and 7e9ec6cf

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 3.55 MB 3.55 MB - -0.0 %
    mainChunk 1.96 MB 1.96 MB - 0.0 %

    Note: We do not have exact data for 06c724a9. So we have used data from: e61d5ae6.
    The intended commit has no webpack pipeline, so we chose the last commit with one before it.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Allure report

    allure-report-publisher generated test report!

    e2e-review-qa: :exclamation: test report for 7e9ec6cf

    expand test summary
    +-----------------------------------------------------------------------------------------+
    |                                     suites summary                                      |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    |                                    | passed | failed | skipped | flaky | total | result |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Plan                               | 49     | 0      | 1       | 0     | 50    | ✅     |
    | Create                             | 28     | 0      | 1       | 0     | 29    | ✅     |
    | Manage                             | 39     | 0      | 4       | 4     | 43    | ❗     |
    | Govern                             | 10     | 0      | 5       | 1     | 15    | ❗     |
    | Verify                             | 12     | 0      | 1       | 0     | 13    | ✅     |
    | Package                            | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Feature flag handler sanity checks | 9      | 0      | 0       | 0     | 9     | ✅     |
    | Version sanity check               | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Configure                          | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Total                              | 147    | 0      | 15      | 5     | 162   | ❗     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
  • Jannik Lehmann marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Jannik Lehmann marked this merge request as ready

    marked this merge request as ready

  • Jannik Lehmann
  • requested review from @tristan.read

  • Tristan Read approved this merge request

    approved this merge request

  • :wave: @tristan.read, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • 🤖 GitLab Bot 🤖 added 1 deleted label

    added 1 deleted label

  • Tristan Read changed milestone to %15.7

    changed milestone to %15.7

  • Tristan Read resolved all threads

    resolved all threads

  • Tristan Read resolved all threads

    resolved all threads

  • Ezekiel Kigbo resolved all threads

    resolved all threads

  • Ezekiel Kigbo approved this merge request

    approved this merge request

  • Ezekiel Kigbo enabled an automatic merge when the pipeline for faa86be2 succeeds

    enabled an automatic merge when the pipeline for faa86be2 succeeds

  • Ezekiel Kigbo requested review from @ekigbo

    requested review from @ekigbo

  • Setting label groupstatic analysis based on @jannik_lehmann's group.

  • merged

  • Ezekiel Kigbo mentioned in commit 0481262a

    mentioned in commit 0481262a

  • added workflowstaging label and removed workflowcanary label

  • mentioned in issue #382758 (closed)

  • Please register or sign in to reply
    Loading