Skip to content
Snippets Groups Projects

Update Timeline event update mutation to consider timeline event tags

Merged Rajendra Kadam requested to merge 373853-incident-tag-timeline-event-update into master
All threads resolved!
2 files
+ 6
4
Compare changes
  • Side-by-side
  • Inline
Files
2
@@ -24,6 +24,7 @@ def execute
return error_no_permissions unless allowed?
timeline_event.assign_attributes(update_params)
update_timeline_event_tags(timeline_event, timeline_event_tags) if timeline_event_tags
if timeline_event.save(context: validation_context)
add_system_note(timeline_event)
@@ -37,7 +38,7 @@ def execute
private
attr_reader :timeline_event, :incident, :user, :note, :occurred_at, :validation_context
attr_reader :timeline_event, :incident, :user, :note, :occurred_at, :validation_context, :timeline_event_tags
def update_params
{ updated_by_user: user, note: note, occurred_at: occurred_at }.compact
@@ -74,14 +75,14 @@ def update_timeline_event_tags(timeline_event, tag_updates)
validate_tags(tags_to_add, tags_defined_on_project)
remove_tag_links(timeline_event, tags_to_remove)
create_tag_links(timeline_event, tags_to_add)
remove_tag_links(timeline_event, tags_to_remove) if tags_to_remove.any?
create_tag_links(timeline_event, tags_to_add) if tags_to_add.any?
end
def remove_tag_links(timeline_event, tags_to_remove_names)
tags_to_remove_ids = timeline_event.timeline_event_tags.by_names(tags_to_remove_names).ids
timeline_event.timeline_event_tag_links.where(timeline_event_tag_id: tag_to_remove_ids).delete_all
timeline_event.timeline_event_tag_links.where(timeline_event_tag_id: tags_to_remove_ids).delete_all
end
def create_tag_links(timeline_event, tags_to_add_names)
Loading