Skip to content
Snippets Groups Projects

Install two versions of Sentry Client SDK

Merged Miguel Rincon requested to merge mrincon-sentry-double-integration into master
All threads resolved!
1 file
+ 5
4
Compare changes
  • Side-by-side
  • Inline
@@ -3,9 +3,6 @@
require 'spec_helper'
RSpec.describe 'Sentry' do
let(:sentry_regex_path) { '\/sentry.*\.chunk\.js' }
let(:legacy_sentry_regex_path) { '\/legacy_sentry.*\.chunk\.js' }
context 'when enable_new_sentry_clientside_integration is disabled' do
before do
stub_feature_flags(enable_new_sentry_clientside_integration: false)
@@ -41,7 +38,7 @@
expect(has_requested_sentry).to eq(true)
end
it 'does not loads sentry if sentry settings are disabled' do
it 'does not load sentry if sentry settings are disabled' do
allow(Gitlab::CurrentSettings).to receive(:sentry_enabled).and_return(false)
visit new_user_session_path
@@ -51,12 +48,16 @@
end
def has_requested_legacy_sentry
legacy_sentry_regex_path = '\/legacy_sentry.*\.chunk\.js'
page.all('script', visible: false).one? do |elm|
elm[:src] =~ /#{legacy_sentry_regex_path}$/
end
end
def has_requested_sentry
sentry_regex_path = '\/sentry.*\.chunk\.js'
page.all('script', visible: false).one? do |elm|
elm[:src] =~ /#{sentry_regex_path}$/
end
Loading