Add title to runner delete error alert
What does this MR do and why?
This change improves the information provided when a runner deletion fails.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Create a condition for an error
- Change code to ensure the backend produces an error, here I change how the backend handles deletion:
diff --git a/app/graphql/mutations/ci/runner/delete.rb b/app/graphql/mutations/ci/runner/delete.rb
index db68914a4eb0..7261ea8f1f0f 100644
--- a/app/graphql/mutations/ci/runner/delete.rb
+++ b/app/graphql/mutations/ci/runner/delete.rb
@@ -23,7 +23,8 @@ def resolve(id:, **runner_attrs)
end
def find_object(id)
- GitlabSchema.find_by_gid(id)
+ nil
+ # GitlabSchema.find_by_gid(id)
end
end
end
Trigger the error
- With at least one runner registered, logged in as admin
- Visit the Admin -> Runners page
- Select the delete button in a runner
- Check the error alert at the top of the screen
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #346793 (closed)
Merge request reports
Activity
changed milestone to %Backlog
added Deferred UX Track Health Status [DEPRECATED] UX [Deprecated] Category:Runner Fleet [deprecated] Accepting merge requests [deprecated] good for new contributors auto updated devopsverify featureenhancement frontend grouprunner sectionops severity4 typefeature usability workflowready for development + 1 deleted label
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
assigned to @mrincon
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Ammar Alakkad (
@aalakkad
) (UTC+3, 2 hours ahead of@mrincon
)Vitaly Slobodin (
@vitallium
) (UTC+1, same timezone as@mrincon
)UX Sunjung Park (
@sunjungp
) (UTC+1, same timezone as@mrincon
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in merge request !102523 (merged)
- Resolved by Miguel Rincon
@gdoyle this is my proposal for implementation of #346793 (closed), there you designed a screen with a specific error message. That message may vary so here I only added a title like the design, wdyt?
Allure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for f4ca2549expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 43 | 0 | 3 | 7 | 46 | ❗ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Verify | 37 | 4 | 8 | 8 | 49 | ❌ | | Govern | 10 | 0 | 5 | 0 | 15 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 176 | 4 | 21 | 15 | 201 | ❌ | +------------------------------------+--------+--------+---------+-------+-------+--------+
removed [deprecated] Accepting merge requests label
added Technical Writing label
added 1106 commits
-
17470ba6...8f7a212d - 1105 commits from branch
master
- f4ca2549 - Add title to runner delete error alert
-
17470ba6...8f7a212d - 1105 commits from branch
- Resolved by Vitaly Slobodin
@rchanila could you help me review this change? Thanks!
requested review from @rchanila
requested review from @danmh
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 1c505128 and 037f69a5
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.6 MB 3.6 MB - 0.0 % mainChunk 1.96 MB 1.96 MB - 0.0 %
Note: We do not have exact data for 1c505128. So we have used data from: e664cbb6.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger@fneill
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
removed review request for @rchanila
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
requested review from @vitallium
removed review request for @danmh
changed milestone to %15.6
- Resolved by Miguel Rincon
mentioned in issue danmh/danmh#11 (closed)
removed review request for @vitallium
added 1319 commits
-
f4ca2549...5fb5e0ea - 1318 commits from branch
master
- 037f69a5 - Add title to runner delete error alert
-
f4ca2549...5fb5e0ea - 1318 commits from branch
requested review from @vitallium
mentioned in commit cf4c47fe
added workflowstaging-canary label and removed workflowready for development label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1646 (merged)
added releasedpublished label and removed releasedcandidate label