Fix scoped label styles in activity feed
What does this MR do and why?
Describe in detail what your merge request does and why.
Makes scoped labels display with a border in the project & group activity feeds.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Premium or higher licence needed. Learn more about developer licences for working on GitLab EE.
- Create a scoped label. For example
scoped::label
. - Add a comment that includes the scoped label to an issue, on a project in a group. For example
This is my ~scoped::label comment
onhttp://127.0.0.1:3000/flightjs/Flight/-/issues/9
. - View the comment on the project activity feed. It can take up to 15min for the activity to show. For example
http://127.0.0.1:3000/flightjs/Flight/activity
. - View the comment on the group activity feed. It can take up to 15min for the activity to show. For example
http://127.0.0.1:3000/groups/flightjs/-/activity
.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @danmh
2 Warnings You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.This merge request does not refer to an existing milestone. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Lee Tickett ( @leetickett-gitlab
) (UTC+1, same timezone as@danmh
)Olena HK. ( @ohoral
) (UTC+3, 2 hours ahead of@danmh
)UX Nick Leonard ( @nickleonard
) (UTC-5, 6 hours behind@danmh
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@danmh - please see the following guidance and update this merge request.1 Warning Please add a subtype label to this merge request. If you have added a type label and do not feel the purpose of this merge request matches one of the subtypes labels, please resolve this discussion.
Edited by 🤖 GitLab Bot 🤖
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 76abf813 and 3b534bb5
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.59 MB 3.59 MB +1.49 KB 0.0 % mainChunk 1.96 MB 1.96 MB - 0.0 % Significant Growth: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.groups.billings 153.47 KB 786.84 KB +633.37 KB 412.7 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@leipert
,@markrian
,@mikegreiling
,@ohoral
or@pgascouvaillancourt
) for review, if you are unsure about the size increase.Note: We do not have exact data for 76abf813. So we have used data from: 3889d44c.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 3b534bb5expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 47 | 0 | 1 | 0 | 48 | ✅ | | Manage | 52 | 0 | 8 | 3 | 60 | ❗ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Verify | 12 | 0 | 1 | 0 | 13 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Secure | 2 | 0 | 0 | 0 | 2 | ✅ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 152 | 0 | 14 | 3 | 166 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
added UX bugux workflowin dev labels
added UI polish label
added severity4 label
added 388 commits
-
845dba66...5d6571fc - 387 commits from branch
master
- 3b534bb5 - Fix scoped label styles in activity feed
-
845dba66...5d6571fc - 387 commits from branch
- Resolved by Olena Horal-Koretska
requested review from @nickleonard
requested review from @leetickett-gitlab
- Resolved by Olena Horal-Koretska
This small MR makes scoped labels display with a border in the activity feeds.
@leetickett-gitlab please could you review frontend ?
@nickleonard please could your review UX ?
mentioned in issue danmh/danmh#10 (closed)
@nickleonard
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
removed review request for @nickleonard
requested review from @ohoral and removed review request for @leetickett-gitlab
changed milestone to %15.6
@ohoral, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline finished more than 2 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to merge when pipeline succeeds.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
mentioned in commit 86969d36
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1521 (merged)
mentioned in issue danmh/danmh#11 (closed)
added releasedpublished label and removed releasedcandidate label