Skip to content
Snippets Groups Projects

Fix scoped label styles in activity feed

Merged Dan MH requested to merge danmh-label-small-border into master
All threads resolved!

What does this MR do and why?

Describe in detail what your merge request does and why.

Makes scoped labels display with a border in the project & group activity feeds.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
127.0.0.1_3000_groups_flightjs_-activity__1 127.0.0.1_3000_groups_flightjs_-_activity
127.0.0.1_3000_flightjs_Flight_activity__1_ 127.0.0.1_3000_flightjs_Flight_activity

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Premium or higher licence needed. Learn more about developer licences for working on GitLab EE.
  2. Create a scoped label. For example scoped::label.
  3. Add a comment that includes the scoped label to an issue, on a project in a group. For example This is my ~scoped::label comment on http://127.0.0.1:3000/flightjs/Flight/-/issues/9.
  4. View the comment on the project activity feed. It can take up to 15min for the activity to show. For example http://127.0.0.1:3000/flightjs/Flight/activity.
  5. View the comment on the group activity feed. It can take up to 15min for the activity to show. For example http://127.0.0.1:3000/groups/flightjs/-/activity.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Dan MH

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • assigned to @danmh

  • Dan MH marked this merge request as draft

    marked this merge request as draft

  • A deleted user added frontend typebug labels

    added frontend typebug labels

  • 2 Warnings
    :warning: You've made some app changes, but didn't add any tests.
    That's OK as long as you're refactoring existing code,
    but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.
    :warning: This merge request does not refer to an existing milestone.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    frontend Lee Tickett (@leetickett-gitlab) (UTC+1, same timezone as @danmh) Olena HK. (@ohoral) (UTC+3, 2 hours ahead of @danmh)
    UX Nick Leonard (@nickleonard) (UTC-5, 6 hours behind @danmh) Maintainer review is optional for UX

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 76abf813 and 3b534bb5

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 3.59 MB 3.59 MB +1.49 KB 0.0 %
    mainChunk 1.96 MB 1.96 MB - 0.0 %

    :fearful: Significant Growth: 1

    Expand
    Entrypoint / Name Size before Size after Diff Diff in percent
    pages.groups.billings 153.47 KB 786.84 KB +633.37 KB 412.7 %

    Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.

    Please consider pinging someone from the FE Foundations (@leipert, @markrian, @mikegreiling, @ohoral or @pgascouvaillancourt) for review, if you are unsure about the size increase.

    Note: We do not have exact data for 76abf813. So we have used data from: 3889d44c.
    The target commit was too new, so we used the latest commit from master we have info on.
    It might help to rerun the bundle-size-review job
    This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Allure report

    allure-report-publisher generated test report!

    e2e-review-qa: :exclamation: test report for 3b534bb5

    expand test summary
    +-----------------------------------------------------------------------------------------+
    |                                     suites summary                                      |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    |                                    | passed | failed | skipped | flaky | total | result |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Govern                             | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Plan                               | 47     | 0      | 1       | 0     | 48    | ✅     |
    | Manage                             | 52     | 0      | 8       | 3     | 60    | ❗     |
    | Create                             | 28     | 0      | 1       | 0     | 29    | ✅     |
    | Verify                             | 12     | 0      | 1       | 0     | 13    | ✅     |
    | Package                            | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Version sanity check               | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Feature flag handler sanity checks | 9      | 0      | 0       | 0     | 9     | ✅     |
    | Configure                          | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Secure                             | 2      | 0      | 0       | 0     | 2     | ✅     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Total                              | 152    | 0      | 14      | 3     | 166   | ❗     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
  • 🤖 GitLab Bot 🤖 resolved all threads

    resolved all threads

  • added UI polish label

  • added severity4 label

  • Dan MH changed title from Draft: Fix scoped badge styles in activity feed to Draft: Fix scoped label styles in activity feed

    changed title from Draft: Fix scoped badge styles in activity feed to Draft: Fix scoped label styles in activity feed

  • Dan MH added 1 commit

    added 1 commit

    • 845dba66 - Fix scoped label styles in activity feed

    Compare with previous version

  • Dan MH changed the description

    changed the description

  • Dan MH added 388 commits

    added 388 commits

    Compare with previous version

  • Dan MH changed the description

    changed the description

  • Dan MH
  • Dan MH requested review from @nickleonard

    requested review from @nickleonard

  • Dan MH requested review from @leetickett-gitlab

    requested review from @leetickett-gitlab

  • mentioned in issue danmh/danmh#10 (closed)

  • Nick Leonard approved this merge request

    approved this merge request

  • :wave: @nickleonard, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • 🤖 GitLab Bot 🤖 added 1 deleted label

    added 1 deleted label

  • Nick Leonard removed review request for @nickleonard

    removed review request for @nickleonard

  • Lee Tickett requested review from @ohoral and removed review request for @leetickett-gitlab

    requested review from @ohoral and removed review request for @leetickett-gitlab

  • Lee Tickett approved this merge request

    approved this merge request

  • Dan MH changed milestone to %15.6

    changed milestone to %15.6

  • Dan MH marked this merge request as ready

    marked this merge request as ready

  • Olena Horal-Koretska approved this merge request

    approved this merge request

  • Olena Horal-Koretska resolved all threads

    resolved all threads

  • @ohoral, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline finished more than 2 hours ago, you should:

    1. Ensure the merge request is not in Draft status.
    2. Start a pipeline (especially important for Community contribution merge requests).
    3. Set the merge request to merge when pipeline succeeds.

    This is a guideline, not a rule. Please consider replying to this comment for transparency.

    This message was generated automatically. You're welcome to improve it.

  • mentioned in commit 86969d36

  • Olena Horal-Koretska resolved all threads

    resolved all threads

  • added workflowstaging label and removed workflowcanary label

  • mentioned in issue danmh/danmh#11 (closed)

  • Please register or sign in to reply
    Loading