Skip to content
Snippets Groups Projects

Move groupsPath util to its own file

Merged Paul Gascou-Vaillancourt requested to merge 374010-group-select-utils into master
All threads resolved!

What does this MR do and why?

This moves the groupsPath util to its own utils.js file. This makes it more reusable and testable. We're doing this in preparation for migrating the group selector away from select2 as we'll be able to import this helper in the new Vue component that will coexist with the existing select2 implementation for a short while.

The main migration is being done in !98597 (merged) and already leverages these changes. That other MR is currently blocked by other considerations, so this one lets us ship an independent change to make the main MR smaller when it is ready.

Screenshots or screen recordings

No visual change.

How to set up and validate locally

The group selectors are located at Admin Area > Settings > Templates > Custom project templates and :group > Settings > General > Custom project templates but are both unaffected.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #374010 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Rahul Chanila approved this merge request

    approved this merge request

  • Rahul Chanila requested review from @f_caplette and removed review request for @rchanila

    requested review from @f_caplette and removed review request for @rchanila

  • :wave: @rchanila, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • 🤖 GitLab Bot 🤖 added 1 deleted label

    added 1 deleted label

  • added 137 commits

    Compare with previous version

  • Frédéric Caplette resolved all threads

    resolved all threads

  • Frédéric Caplette approved this merge request

    approved this merge request

  • Frédéric Caplette enabled an automatic merge when the pipeline for ccccf65f succeeds

    enabled an automatic merge when the pipeline for ccccf65f succeeds

  • mentioned in commit bfe7f792

  • added workflowstaging label and removed workflowcanary label

  • 🤖 GitLab Bot 🤖 added devopsmanage label and removed 1 deleted label

    added devopsmanage label and removed 1 deleted label

  • Please register or sign in to reply
    Loading