Move groupsPath util to its own file
What does this MR do and why?
This moves the groupsPath
util to its own utils.js
file. This makes it
more reusable and testable. We're doing this in preparation for
migrating the group selector away from select2
as we'll be able to
import this helper in the new Vue component that will coexist with the
existing select2
implementation for a short while.
The main migration is being done in !98597 (merged) and already leverages these changes. That other MR is currently blocked by other considerations, so this one lets us ship an independent change to make the main MR smaller when it is ready.
Screenshots or screen recordings
No visual change.
How to set up and validate locally
The group selectors are located at Admin Area > Settings > Templates > Custom project templates and :group > Settings > General > Custom project templates but are both unaffected.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #374010 (closed)
Merge request reports
Activity
changed milestone to %15.6
added UX dropdownlistbox frontend groupfoundations maintenancerefactor sectiondev typemaintenance workflowin dev + 1 deleted label
assigned to @pgascouvaillancourt
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Deepika Guliani ( @deepika.guliani
) (UTC+5.5, 9.5 hours ahead of@pgascouvaillancourt
)Phil Hughes ( @iamphill
) (UTC+1, 5 hours ahead of@pgascouvaillancourt
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 427d9595 and a0ef3636
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.59 MB 3.59 MB - 0.0 % mainChunk 1.96 MB 1.96 MB - 0.0 %
Note: We do not have exact data for 427d9595. So we have used data from: c3148be8.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangerremoved UX label
- Resolved by Frédéric Caplette
@rchanila could you review this please?
requested review from @rchanila
Allure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for a0ef3636expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 52 | 0 | 8 | 3 | 60 | ❗ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Verify | 12 | 0 | 1 | 2 | 13 | ❗ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 47 | 0 | 1 | 0 | 48 | ✅ | | Secure | 2 | 0 | 0 | 0 | 2 | ✅ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 152 | 0 | 14 | 5 | 166 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Frédéric Caplette
requested review from @f_caplette and removed review request for @rchanila
@rchanila
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added 137 commits
-
691002fe...427d9595 - 135 commits from branch
master
- 495b51cb - Move groupsPath util to its own file
- a0ef3636 - Handle invalid groupsPath params combination
-
691002fe...427d9595 - 135 commits from branch
enabled an automatic merge when the pipeline for ccccf65f succeeds
mentioned in commit bfe7f792
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added devopsmanage label and removed 1 deleted label
added releasedpublished label and removed releasedcandidate label