Show error when removing epic or issue from epic
What does this MR do and why?
Fixes showing error when removing epic or issue child from epic.
Screenshots or screen recordings
How to set up and validate locally
- Navigate to epic
- Switch browser to offline mode
- Remove issue or epic from
Child issues and epics
section - An error is showing
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #37065 (closed)
Merge request reports
Activity
changed milestone to %15.6
assigned to @fguibert
3 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.This merge request changed files with disabled eslint rules. Please consider fixing them. Please add a merge request subtype to this merge request. Disabled eslint rules
The following files have disabled
eslint
rules. Please consider fixing them:ee/app/assets/javascripts/related_items_tree/store/actions.js
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'ee/app/assets/javascripts/related_items_tree/store/actions.js'
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Doug Stull ( @dstull
) (UTC-4, 14 hours behind@fguibert
)Anna Vovchenko ( @anna_vovchenko
) (UTC+3, 7 hours behind@fguibert
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Kushal Pandya
@fguibert - please see the following guidance and update this merge request.1 Warning Please add a subtype label to this merge request. If you have added a type label and do not feel the purpose of this merge request matches one of the subtypes labels, please resolve this discussion.
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits f359bb83 and 916bcd28
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.59 MB 3.59 MB - 0.0 % mainChunk 1.96 MB 1.96 MB - 0.0 %
Note: We do not have exact data for f359bb83. So we have used data from: 51c6acd4.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 916bcd28expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Plan | 53 | 0 | 4 | 1 | 57 | ❗ | | Verify | 12 | 0 | 1 | 2 | 13 | ❗ | | Manage | 52 | 0 | 8 | 3 | 60 | ❗ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 158 | 0 | 17 | 8 | 175 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
removed workflowin dev label
added workflowin review label
requested review from @cngo
- Resolved by Kushal Pandya
@cngo Could you please review this small fix and pass it to
@kushalpandya
for maintainer review if you're happy with it?
requested review from @kushalpandya and removed review request for @cngo
@cngo
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
mentioned in commit 60875732
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1521 (merged)
added releasedpublished label and removed releasedcandidate label