GitLab merge requestshttps://gitlab.com/gitlab-org/gitlab/-/merge_requests2024-03-29T00:00:17Zhttps://gitlab.com/gitlab-org/gitlab/-/merge_requests/148219Draft: Move "Promote" to actions menu for milestone list pages2024-03-29T00:00:17ZChad LavimoniereDraft: Move "Promote" to actions menu for milestone list pages## What does this MR do and why?
Removes the Promote button shown on milestone list pages and adds an action menu that includes edit, promote and delete actions depending on context.
## MR acceptance checklist
**Please evaluate this M...## What does this MR do and why?
Removes the Promote button shown on milestone list pages and adds an action menu that includes edit, promote and delete actions depending on context.
## MR acceptance checklist
**Please evaluate this MR against the [MR acceptance checklist](https://docs.gitlab.com/ee/development/code_review.html#acceptance-checklist).**
It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
## Screenshots or screen recordings
_Screenshots are required for UI changes, and strongly recommended for all other merge requests._
<!--
Please include any relevant screenshots or screen recordings that will assist
reviewers and future readers. If you need help visually verifying the change,
please leave a comment and ping a GitLab reviewer, maintainer, or MR coach.
-->
| Page | Before | After |
| ---- | ------ | ----- |
| Individual Milestone page in a project | | |
| Individual Milestone page in a group | | |
| Project milestone list page | | |
| Group milestone show page | | |
| Your work Milestone Dashboard list page | | |
## How to set up and validate locally
_Numbered steps to set up and validate the change are strongly suggested._
<!--
Example below:
1. In rails console enable the experiment fully
```ruby
Feature.enable(:member_areas_of_focus)
```
1. Visit any group or project member pages such as `http://127.0.0.1:3000/groups/flightjs/-/group_members`
1. Click the `invite members` button.
-->
<!-- template sourced from https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/merge_request_templates/Default.md -->
Related to #39675316.11Chad LavimoniereChad Lavimonierehttps://gitlab.com/gitlab-org/gitlab/-/merge_requests/148215Draft: Add development widget to work item types2024-03-28T22:54:24ZMario CeliDraft: Add development widget to work item types## What does this MR do and why?
## MR acceptance checklist
**Please evaluate this MR against the [MR acceptance checklist](https://docs.gitlab.com/ee/development/code_review.html#acceptance-checklist).**
It helps you analyze changes ...## What does this MR do and why?
## MR acceptance checklist
**Please evaluate this MR against the [MR acceptance checklist](https://docs.gitlab.com/ee/development/code_review.html#acceptance-checklist).**
It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
## Screenshots or screen recordings
_Screenshots are required for UI changes, and strongly recommended for all other merge requests._
<!--
Please include any relevant screenshots or screen recordings that will assist
reviewers and future readers. If you need help visually verifying the change,
please leave a comment and ping a GitLab reviewer, maintainer, or MR coach.
-->
| Before | After |
| ------ | ------ |
| | |
## How to set up and validate locally
_Numbered steps to set up and validate the change are strongly suggested._
<!--
Example below:
1. In rails console enable the experiment fully
```ruby
Feature.enable(:member_areas_of_focus)
```
1. Visit any group or project member pages such as `http://127.0.0.1:3000/groups/flightjs/-/group_members`
1. Click the `invite members` button.
-->
<!-- template sourced from https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/merge_request_templates/Default.md -->
Related to #45240916.11Mario CeliMario Celihttps://gitlab.com/gitlab-org/gitlab/-/merge_requests/148200Draft: Adds a new keep file to remove duplicated indexes2024-03-29T00:14:25ZLeonardo da RosaDraft: Adds a new keep file to remove duplicated indexes## What does this MR do and why?
<!--
Describe in detail what your merge request does and why.
Please keep this description updated with any discussion that takes place so
that reviewers can understand your intent. Keeping the descript...## What does this MR do and why?
<!--
Describe in detail what your merge request does and why.
Please keep this description updated with any discussion that takes place so
that reviewers can understand your intent. Keeping the description updated is
especially important if they didn't participate in the discussion.
-->
Adds a new keep file to remove duplicated indexes
This keep uses test database to look for duplicated
indexes and it creates each respective MR to drop
each index.
Changelog: added
## MR acceptance checklist
**Please evaluate this MR against the [MR acceptance checklist](https://docs.gitlab.com/ee/development/code_review.html#acceptance-checklist).**
It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
## Screenshots or screen recordings
_Screenshots are required for UI changes, and strongly recommended for all other merge requests._
<!--
Please include any relevant screenshots or screen recordings that will assist
reviewers and future readers. If you need help visually verifying the change,
please leave a comment and ping a GitLab reviewer, maintainer, or MR coach.
-->
| Before | After |
| ------ | ------ |
| | |
## How to set up and validate locally
_Numbered steps to set up and validate the change are strongly suggested._
<!--
Example below:
1. In rails console enable the experiment fully
```ruby
Feature.enable(:member_areas_of_focus)
```
1. Visit any group or project member pages such as `http://127.0.0.1:3000/groups/flightjs/-/group_members`
1. Click the `invite members` button.
-->
<!-- template sourced from https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/merge_request_templates/Default.md -->
Related to #44021316.11Leonardo da RosaLeonardo da Rosahttps://gitlab.com/gitlab-org/gitlab/-/merge_requests/148196Proposed change to Git LFS page2024-03-28T20:22:53ZMike JangProposed change to Git LFS page## What does this MR do?
I'm proposing some changes to https://docs.gitlab.com/ee/topics/git/lfs/, primarily for clarity. However, I have:
- Rewritten the intro as a [Concept](https://docs.gitlab.com/ee/development/documentation/topic_...## What does this MR do?
I'm proposing some changes to https://docs.gitlab.com/ee/topics/git/lfs/, primarily for clarity. However, I have:
- Rewritten the intro as a [Concept](https://docs.gitlab.com/ee/development/documentation/topic_types/concept.html) topic type
- Moved the image after the instructions to install LFS on the server and client
- Checked my proposed change through Vale. I improved readability from 8.11 to 7.83.
In addition:
- I'm tempted to add a link to OAuth 2 docs (see Line 60), as I'm pretty sure that'll also work as as an HTTPS credential store.
- I would have changed more titles to avoid "ing" verbs (such as "Using Git LFS" -\> "Use Git LFS", but I didn't want to break links, and prefer an MVC.
- Before I set up this MR, I used this procedure to build the doc locally: https://gitlab.com/gitlab-org/gitlab-docs/-/blob/main/doc/setup.md
## Related issues
## Author's checklist
- [ ] Optional. Consider taking [the GitLab Technical Writing Fundamentals course](https://about.gitlab.com/handbook/product/ux/technical-writing/fundamentals/).
- [x] Follow the:
- [Documentation process](https://docs.gitlab.com/ee/development/documentation/workflow.html).
- [Documentation guidelines](https://docs.gitlab.com/ee/development/documentation/).
- [Style Guide](https://docs.gitlab.com/ee/development/documentation/styleguide/).
- [ ] If you're adding a new page, add the [product tier badge](https://docs.gitlab.com/ee/development/documentation/styleguide/index.html#product-tier-badges) under the H1 topic title.
- [ ] If you are a GitLab team member, [request a review](https://docs.gitlab.com/ee/development/code_review.html#dogfooding-the-reviewers-feature) based on:
- The documentation page's [metadata](https://docs.gitlab.com/ee/development/documentation/metadata.html).
- The [associated Technical Writer](https://handbook.gitlab.com/handbook/product/ux/technical-writing/#assignments).
If you are a GitLab team member and only adding documentation, do not add any of the following labels:
- `~"frontend"`
- `~"backend"`
- `~"type::bug"`
- `~"database"`
These labels cause the MR to be added to code verification QA issues.
## Reviewer's checklist
Documentation-related MRs should be reviewed by a Technical Writer for a non-blocking review, based on [Documentation Guidelines](https://docs.gitlab.com/ee/development/documentation/) and the [Style Guide](https://docs.gitlab.com/ee/development/documentation/styleguide/).
If you aren't sure which tech writer to ask, use [roulette](https://gitlab-org.gitlab.io/gitlab-roulette/?sortKey=stats.avg30&order=-1&hourFormat24=true&visible=maintainer%7Cdocs) or ask in the [#docs](https://gitlab.slack.com/archives/C16HYA2P5) Slack channel.
- [ ] If the content requires it, ensure the information is reviewed by a subject matter expert.
- [ ] Technical writer review items:
- [ ] Ensure docs metadata is present and up-to-date.
- [ ] Ensure the appropriate [labels](https://handbook.gitlab.com/handbook/product/ux/technical-writing/workflow/#labels) are added to this MR.
- [ ] Ensure a release milestone is set.
- [ ] If relevant to this MR, ensure [content topic type](https://docs.gitlab.com/ee/development/documentation/topic_types/) principles are in use, including:
- [ ] The headings should be something you'd do a Google search for. Instead of `Default behavior`, say something like `Default behavior when you close an issue`.
- [ ] The headings (other than the page title) should be active. Instead of `Configuring GDK`, say something like `Configure GDK`.
- [ ] Any task steps should be written as a numbered list.
- [ ] If the content still needs to be edited for topic types, you can create a follow-up issue with the ~"docs-technical-debt" label.
- [ ] Review by assigned maintainer, who can always request/require the reviews above. Maintainer's review can occur before or after a technical writer review.
cc @kpaizeeMike JangMike Janghttps://gitlab.com/gitlab-org/gitlab/-/merge_requests/148187Delete unused LLM `JsonReader` tool2024-03-28T22:08:00ZLesley RazzaghianDelete unused LLM `JsonReader` tool## What does this MR do and why?
This tool has been unused for over 1 month, so we decided to remove it rather than keep it in the codebase.
(See [issue](https://gitlab.com/gitlab-org/gitlab/-/issues/452279) for more details)
Please se...## What does this MR do and why?
This tool has been unused for over 1 month, so we decided to remove it rather than keep it in the codebase.
(See [issue](https://gitlab.com/gitlab-org/gitlab/-/issues/452279) for more details)
Please see [this MR](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/143822) for historical details about why `JsonReader` is no longer used.
<!--
Describe in detail what your merge request does and why.
Please keep this description updated with any discussion that takes place so
that reviewers can understand your intent. Keeping the description updated is
especially important if they didn't participate in the discussion.
-->
## MR acceptance checklist
**Please evaluate this MR against the [MR acceptance checklist](https://docs.gitlab.com/ee/development/code_review.html#acceptance-checklist).**
It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
## Screenshots or screen recordings
N/A
## How to set up and validate locally
1. Go to Duo Chat
2. Ask a question about an issue or epic using the URL. (For instance: summarize this issue: http://localhost:3000/ai_group/gitlab-com/www-gitlab-com/-/issues/34345) and make sure it works as expected.
<!-- template sourced from https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/merge_request_templates/Default.md -->
Related to #45227916.11Lesley RazzaghianLesley Razzaghianhttps://gitlab.com/gitlab-org/gitlab/-/merge_requests/148170Draft: Fix UI for Duo Pro trial errors2024-03-28T13:40:16ZRoy LiuDraft: Fix UI for Duo Pro trial errors## What does this MR do and why?
<!--
Describe in detail what your merge request does and why.
Please keep this description updated with any discussion that takes place so
that reviewers can understand your intent. Keeping the descript...## What does this MR do and why?
<!--
Describe in detail what your merge request does and why.
Please keep this description updated with any discussion that takes place so
that reviewers can understand your intent. Keeping the description updated is
especially important if they didn't participate in the discussion.
-->
## MR acceptance checklist
**Please evaluate this MR against the [MR acceptance checklist](https://docs.gitlab.com/ee/development/code_review.html#acceptance-checklist).**
It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
## Screenshots or screen recordings
_Screenshots are required for UI changes, and strongly recommended for all other merge requests._
<!--
Please include any relevant screenshots or screen recordings that will assist
reviewers and future readers. If you need help visually verifying the change,
please leave a comment and ping a GitLab reviewer, maintainer, or MR coach.
-->
| Before | After |
| ------ | ------ |
| | |
## How to set up and validate locally
_Numbered steps to set up and validate the change are strongly suggested._
<!--
Example below:
1. In rails console enable the experiment fully
```ruby
Feature.enable(:member_areas_of_focus)
```
1. Visit any group or project member pages such as `http://127.0.0.1:3000/groups/flightjs/-/group_members`
1. Click the `invite members` button.
-->
<!-- template sourced from https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/merge_request_templates/Default.md -->
Related to #45102316.11Roy LiuRoy Liuhttps://gitlab.com/gitlab-org/gitlab/-/merge_requests/148162Draft: Protected containers: Apply ServiceResponse for ContainerRegistryAuthS...2024-03-29T02:04:15ZGerardo Navarrogerardo@b310.deDraft: Protected containers: Apply ServiceResponse for ContainerRegistryAuthService## What does this MR do and why?
:tools: with :heart: at Siemens
## MR acceptance checklist
**Please evaluate this MR against the [MR acceptance checklist](https://docs.gitlab.com/ee/development/code_review.html#acceptance-checklist)....## What does this MR do and why?
:tools: with :heart: at Siemens
## MR acceptance checklist
**Please evaluate this MR against the [MR acceptance checklist](https://docs.gitlab.com/ee/development/code_review.html#acceptance-checklist).**
It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
<details><summary>MR Checklist (@gerardo-navarro)</summary>
- [x] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/documentation/feature-change-workflow.html) via this MR
- [ ] Documentation reviewed by technical writer *or* follow-up review issue [created](https://gitlab.com/gitlab-org/gitlab-ee/issues/new?issuable_template=Doc%20Review)
- [x] [Tests added for this feature/bug](https://docs.gitlab.com/ee/development/testing_guide/index.html)
- [ ] Tested in [all supported browsers](https://docs.gitlab.com/ee/install/requirements.html#supported-web-browsers)
- [x] Conforms to the [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html)
- [ ] Conforms to the [merge request performance guidelines](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [x] Conforms to the [style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Conforms to the [javascript style guides](https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/development/fe_guide/style/javascript.md)
- [ ] Conforms to the [database guides](https://docs.gitlab.com/ee/development/README.html#databases-guides)
</details>
## Screenshots or screen recordings
_Screenshots are required for UI changes, and strongly recommended for all other merge requests._
<!--
Please include any relevant screenshots or screen recordings that will assist
reviewers and future readers. If you need help visually verifying the change,
please leave a comment and ping a GitLab reviewer, maintainer, or MR coach.
-->
| Before | After |
| ------ | ------ |
| | |
## How to set up and validate locally
_Numbered steps to set up and validate the change are strongly suggested._
<!--
Example below:
1. In rails console enable the experiment fully
```ruby
Feature.enable(:member_areas_of_focus)
```
1. Visit any group or project member pages such as `http://127.0.0.1:3000/groups/flightjs/-/group_members`
1. Click the `invite members` button.
-->
<!-- template sourced from https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/merge_request_templates/Default.md -->
Related to #427546Gerardo Navarrogerardo@b310.deGerardo Navarrogerardo@b310.dehttps://gitlab.com/gitlab-org/gitlab/-/merge_requests/148161Draft: refactor: Fix rubocop issues related to ContainerRegistryAuthService2024-03-29T02:04:16ZGerardo Navarrogerardo@b310.deDraft: refactor: Fix rubocop issues related to ContainerRegistryAuthService## What does this MR do and why?
refactor: Fix rubocop issues related to ContainerRegistryAuthService
- Fixing rubocop issues also in ee codebase
Changelog: other
:tools: with :heart: at Siemens
## MR acceptance checklist
**Please...## What does this MR do and why?
refactor: Fix rubocop issues related to ContainerRegistryAuthService
- Fixing rubocop issues also in ee codebase
Changelog: other
:tools: with :heart: at Siemens
## MR acceptance checklist
**Please evaluate this MR against the [MR acceptance checklist](https://docs.gitlab.com/ee/development/code_review.html#acceptance-checklist).**
It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
<details><summary>MR Checklist (@gerardo-navarro)</summary>
- [x] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/documentation/feature-change-workflow.html) via this MR
- [ ] Documentation reviewed by technical writer *or* follow-up review issue [created](https://gitlab.com/gitlab-org/gitlab-ee/issues/new?issuable_template=Doc%20Review)
- [x] [Tests added for this feature/bug](https://docs.gitlab.com/ee/development/testing_guide/index.html)
- [ ] Tested in [all supported browsers](https://docs.gitlab.com/ee/install/requirements.html#supported-web-browsers)
- [x] Conforms to the [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html)
- [ ] Conforms to the [merge request performance guidelines](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [x] Conforms to the [style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Conforms to the [javascript style guides](https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/development/fe_guide/style/javascript.md)
- [ ] Conforms to the [database guides](https://docs.gitlab.com/ee/development/README.html#databases-guides)
</details>
## Screenshots or screen recordings
_Screenshots are required for UI changes, and strongly recommended for all other merge requests._
<!--
Please include any relevant screenshots or screen recordings that will assist
reviewers and future readers. If you need help visually verifying the change,
please leave a comment and ping a GitLab reviewer, maintainer, or MR coach.
-->
| Before | After |
| ------ | ------ |
| | |
## How to set up and validate locally
_Numbered steps to set up and validate the change are strongly suggested._
<!--
Example below:
1. In rails console enable the experiment fully
```ruby
Feature.enable(:member_areas_of_focus)
```
1. Visit any group or project member pages such as `http://127.0.0.1:3000/groups/flightjs/-/group_members`
1. Click the `invite members` button.
-->
<!-- template sourced from https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/merge_request_templates/Default.md -->
Related to #427546Gerardo Navarrogerardo@b310.deGerardo Navarrogerardo@b310.dehttps://gitlab.com/gitlab-org/gitlab/-/merge_requests/148158Draft: Update documentation for burnchart2024-03-28T11:03:19ZEulyeon KoDraft: Update documentation for burnchart## What does this MR do and why?
<!--
Describe in detail what your merge request does and why.
Please keep this description updated with any discussion that takes place so
that reviewers can understand your intent. Keeping the descript...## What does this MR do and why?
<!--
Describe in detail what your merge request does and why.
Please keep this description updated with any discussion that takes place so
that reviewers can understand your intent. Keeping the description updated is
especially important if they didn't participate in the discussion.
-->
Update documentation for burnchart
Document the new rollup weight/counting behavior.
## MR acceptance checklist
**Please evaluate this MR against the [MR acceptance checklist](https://docs.gitlab.com/ee/development/code_review.html#acceptance-checklist).**
It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
## Screenshots or screen recordings
_Screenshots are required for UI changes, and strongly recommended for all other merge requests._
<!--
Please include any relevant screenshots or screen recordings that will assist
reviewers and future readers. If you need help visually verifying the change,
please leave a comment and ping a GitLab reviewer, maintainer, or MR coach.
-->
| Before | After |
| ------ | ------ |
| | |
## How to set up and validate locally
_Numbered steps to set up and validate the change are strongly suggested._
<!--
Example below:
1. In rails console enable the experiment fully
```ruby
Feature.enable(:member_areas_of_focus)
```
1. Visit any group or project member pages such as `http://127.0.0.1:3000/groups/flightjs/-/group_members`
1. Click the `invite members` button.
-->
<!-- template sourced from https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/merge_request_templates/Default.md -->
Related to #38187916.11Eulyeon KoEulyeon Kohttps://gitlab.com/gitlab-org/gitlab/-/merge_requests/148151Draft: Add milestone and iteration to board card2024-03-28T15:18:32ZJack ChapmanDraft: Add milestone and iteration to board card## What does this MR do and why?
Adds the ability to display an issue's Milestone and Iteration when viewed on an issue board. If there is no Milestone or Iteration, nothing will be displayed.
Also adds tooltips to provide some extra i...## What does this MR do and why?
Adds the ability to display an issue's Milestone and Iteration when viewed on an issue board. If there is no Milestone or Iteration, nothing will be displayed.
Also adds tooltips to provide some extra information, as long Milestone or Iteration names will be truncated.
## MR acceptance checklist
**Please evaluate this MR against the [MR acceptance checklist](https://docs.gitlab.com/ee/development/code_review.html#acceptance-checklist).**
It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
## Screenshots or screen recordings
_Screenshots are required for UI changes, and strongly recommended for all other merge requests._
<!--
Please include any relevant screenshots or screen recordings that will assist
reviewers and future readers. If you need help visually verifying the change,
please leave a comment and ping a GitLab reviewer, maintainer, or MR coach.
-->
| Before | After |
| ------ | ------ |
| ![Screenshot_2024-03-28_at_15.12.14](/uploads/5cb72887c62679467b73083e98e2c5b3/Screenshot_2024-03-28_at_15.12.14.png) | ![Screenshot_2024-03-28_at_15.12.02](/uploads/719d6c0dca5990719aedab2c650412bc/Screenshot_2024-03-28_at_15.12.02.png) |
## How to set up and validate locally
_Numbered steps to set up and validate the change are strongly suggested._
1. Visit an issue board
2. Assign milestones and/or iterations to issues
3. See how it looks :thumbsup:
<!-- template sourced from https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/merge_request_templates/Default.md -->
Related to #2575816.11Jack ChapmanJack Chapmanhttps://gitlab.com/gitlab-org/gitlab/-/merge_requests/148149Draft: Adding protocols used for LB2024-03-29T02:04:14ZAysegul AcarDraft: Adding protocols used for LB## What does this MR do?
Protocols used for load balancers are not documented. This MR adds those.
## Related issues
https://gitlab.com/gitlab-org/gitaly/-/issues/5890
## Author's checklist
- [X] Optional. Consider taking [the GitLa...## What does this MR do?
Protocols used for load balancers are not documented. This MR adds those.
## Related issues
https://gitlab.com/gitlab-org/gitaly/-/issues/5890
## Author's checklist
- [X] Optional. Consider taking [the GitLab Technical Writing Fundamentals course](https://about.gitlab.com/handbook/product/ux/technical-writing/fundamentals/).
- [X] Follow the:
- [Documentation process](https://docs.gitlab.com/ee/development/documentation/workflow.html).
- [Documentation guidelines](https://docs.gitlab.com/ee/development/documentation/).
- [Style Guide](https://docs.gitlab.com/ee/development/documentation/styleguide/).
- [ ] If you're adding a new page, add the [product tier badge](https://docs.gitlab.com/ee/development/documentation/styleguide/index.html#product-tier-badges) under the H1 topic title.
- [X] If you are a GitLab team member, [request a review](https://docs.gitlab.com/ee/development/code_review.html#dogfooding-the-reviewers-feature) based on:
- The documentation page's [metadata](https://docs.gitlab.com/ee/development/documentation/metadata.html).
- The [associated Technical Writer](https://handbook.gitlab.com/handbook/product/ux/technical-writing/#assignments).
If you are a GitLab team member and only adding documentation, do not add any of the following labels:
- `~"frontend"`
- `~"backend"`
- `~"type::bug"`
- `~"database"`
These labels cause the MR to be added to code verification QA issues.
## Reviewer's checklist
Documentation-related MRs should be reviewed by a Technical Writer for a non-blocking review, based on [Documentation Guidelines](https://docs.gitlab.com/ee/development/documentation/) and the [Style Guide](https://docs.gitlab.com/ee/development/documentation/styleguide/).
If you aren't sure which tech writer to ask, use [roulette](https://gitlab-org.gitlab.io/gitlab-roulette/?sortKey=stats.avg30&order=-1&hourFormat24=true&visible=maintainer%7Cdocs) or ask in the [#docs](https://gitlab.slack.com/archives/C16HYA2P5) Slack channel.
- [ ] If the content requires it, ensure the information is reviewed by a subject matter expert.
- Technical writer review items:
- [ ] Ensure docs metadata is present and up-to-date.
- [ ] Ensure the appropriate [labels](https://handbook.gitlab.com/handbook/product/ux/technical-writing/workflow/#labels) are added to this MR.
- [ ] Ensure a release milestone is set.
- If relevant to this MR, ensure [content topic type](https://docs.gitlab.com/ee/development/documentation/topic_types/) principles are in use, including:
- [ ] The headings should be something you'd do a Google search for. Instead of `Default behavior`, say something like `Default behavior when you close an issue`.
- [ ] The headings (other than the page title) should be active. Instead of `Configuring GDK`, say something like `Configure GDK`.
- [ ] Any task steps should be written as a numbered list.
- If the content still needs to be edited for topic types, you can create a follow-up issue with the ~"docs-technical-debt" label.
- [ ] Review by assigned maintainer, who can always request/require the reviews above. Maintainer's review can occur before or after a technical writer review.Aysegul AcarAysegul Acarhttps://gitlab.com/gitlab-org/gitlab/-/merge_requests/148148Add accessLevel & isLastOrganizationOwner fields to organizationUser2024-03-28T09:05:19ZAbdul WadoodAdd accessLevel & isLastOrganizationOwner fields to organizationUser## What does this MR do and why?
<!--
Describe in detail what your merge request does and why.
Please keep this description updated with any discussion that takes place so
that reviewers can understand your intent. Keeping the descript...## What does this MR do and why?
<!--
Describe in detail what your merge request does and why.
Please keep this description updated with any discussion that takes place so
that reviewers can understand your intent. Keeping the description updated is
especially important if they didn't participate in the discussion.
-->
This is part of the ongoing organization work https://docs.gitlab.com/ee/architecture/blueprints/organization/.
We are adding these fields to the `organizationUser` GraphQL query so
check if the current user is the last owner of the organization to see
if the user can leave the organization or not.
## Query plan
<details><summary>Raw query 1</summary>
```sql
EXPLAIN
SELECT 1 AS one
FROM "organization_users"
INNER JOIN "users" ON "users"."id" = "organization_users"."user_id"
WHERE "organization_users"."organization_id" = 1
AND "organization_users"."access_level" = 50
AND ("users"."state" IN ('active'))
AND "users"."user_type" IN (0, 6, 4, 13)
AND "organization_users"."id" != 10000
LIMIT 1;
```
</details>
https://console.postgres.ai/gitlab/gitlab-production-main/sessions/27273/commands/84790
<details><summary>Raw query 2</summary>
```sql
EXPLAIN
SELECT 1 AS one
FROM "organization_users"
WHERE "organization_users"."organization_id" = 1
AND "organization_users"."access_level" = 50
AND "organization_users"."id" != 10327656
LIMIT 1;
```
</details>
https://console.postgres.ai/gitlab/gitlab-production-main/sessions/27273/commands/84791
## MR acceptance checklist
**Please evaluate this MR against the [MR acceptance checklist](https://docs.gitlab.com/ee/development/code_review.html#acceptance-checklist).**
It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
## How to set up and validate locally
Run the below query on https://gdk.test:3000/-/graphql-explorer:
```graphql
{
organization(id: "gid://gitlab/Organizations::Organization/1") {
organizationUsers {
nodes {
id
accessLevel {
integerValue
stringValue
}
isLastOrganizationOwner
}
}
}
}
```
<!--
Example below:
1. In rails console enable the experiment fully
```ruby
Feature.enable(:member_areas_of_focus)
```
1. Visit any group or project member pages such as `http://127.0.0.1:3000/groups/flightjs/-/group_members`
1. Click the `invite members` button.
-->
<!-- template sourced from https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/merge_request_templates/Default.md -->
Related to #44157716.11Abdul WadoodAbdul Wadoodhttps://gitlab.com/gitlab-org/gitlab/-/merge_requests/148147Draft: Resolve "Improve messaging around "assumed merged" MRs"2024-03-28T20:50:47ZSincheol (David) KimDraft: Resolve "Improve messaging around "assumed merged" MRs"## What does this MR do and why?
<!--
Describe in detail what your merge request does and why.
Please keep this description updated with any discussion that takes place so
that reviewers can understand your intent. Keeping the descript...## What does this MR do and why?
<!--
Describe in detail what your merge request does and why.
Please keep this description updated with any discussion that takes place so
that reviewers can understand your intent. Keeping the description updated is
especially important if they didn't participate in the discussion.
-->
## MR acceptance checklist
**Please evaluate this MR against the [MR acceptance checklist](https://docs.gitlab.com/ee/development/code_review.html#acceptance-checklist).**
It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
## Screenshots or screen recordings
_Screenshots are required for UI changes, and strongly recommended for all other merge requests._
<!--
Please include any relevant screenshots or screen recordings that will assist
reviewers and future readers. If you need help visually verifying the change,
please leave a comment and ping a GitLab reviewer, maintainer, or MR coach.
-->
| Before | After |
| ------ | ------ |
| | |
## How to set up and validate locally
_Numbered steps to set up and validate the change are strongly suggested._
<!--
Example below:
1. In rails console enable the experiment fully
```ruby
Feature.enable(:member_areas_of_focus)
```
1. Visit any group or project member pages such as `http://127.0.0.1:3000/groups/flightjs/-/group_members`
1. Click the `invite members` button.
-->
<!-- template sourced from https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/merge_request_templates/Default.md -->
Related to #43606116.11Sincheol (David) KimSincheol (David) Kimhttps://gitlab.com/gitlab-org/gitlab/-/merge_requests/148144Add info about release notes for policy rename2024-03-28T22:37:30ZAlan (Maciej) Paruszewskimparuszewski@gitlab.comAdd info about release notes for policy rename## What does this MR do and why?
<!--
Describe in detail what your merge request does and why.
Please keep this description updated with any discussion that takes place so
that reviewers can understand your intent. Keeping the descript...## What does this MR do and why?
<!--
Describe in detail what your merge request does and why.
Please keep this description updated with any discussion that takes place so
that reviewers can understand your intent. Keeping the description updated is
especially important if they didn't participate in the discussion.
-->
This MR adds information about release notes for policy rename, removed with https://gitlab.com/gitlab-org/gitlab/-/merge_requests/146260+.
- Adds link to banner
- Tooltips cannot have links
## MR acceptance checklist
**Please evaluate this MR against the [MR acceptance checklist](https://docs.gitlab.com/ee/development/code_review.html#acceptance-checklist).**
It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
## Screenshots or screen recordings
_Screenshots are required for UI changes, and strongly recommended for all other merge requests._
<!--
Please include any relevant screenshots or screen recordings that will assist
reviewers and future readers. If you need help visually verifying the change,
please leave a comment and ping a GitLab reviewer, maintainer, or MR coach.
-->
| Banner | Tooltip |
| ------ | ------ |
| ![Screenshot_2024-03-28_at_14.36.42](/uploads/5d714cb6edb28c266b25a5dc838fddc2/Screenshot_2024-03-28_at_14.36.42.png) | ![Screenshot_2024-03-28_at_14.36.29](/uploads/5d944721ae21587d0860762fefcd05e0/Screenshot_2024-03-28_at_14.36.29.png) |
## How to set up and validate locally
_Numbered steps to set up and validate the change are strongly suggested._
<!--
Example below:
1. In rails console enable the experiment fully
```ruby
Feature.enable(:member_areas_of_focus)
```
1. Visit any group or project member pages such as `http://127.0.0.1:3000/groups/flightjs/-/group_members`
1. Click the `invite members` button.
-->
<!-- template sourced from https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/merge_request_templates/Default.md -->
Related to #44382316.11Alan (Maciej) Paruszewskimparuszewski@gitlab.comAlan (Maciej) Paruszewskimparuszewski@gitlab.comhttps://gitlab.com/gitlab-org/gitlab/-/merge_requests/148130Draft: Add update avatar on user api2024-03-29T02:04:15ZPhawin KhongkhasawanDraft: Add update avatar on user api## What does this MR do and why?
I'm not sure if this implement way is correct (please disregard details outside of `avatar` parameter type)
I saw in the `update user api` using `API::Validations::Types::WorkhorseFile` for validate ima...## What does this MR do and why?
I'm not sure if this implement way is correct (please disregard details outside of `avatar` parameter type)
I saw in the `update user api` using `API::Validations::Types::WorkhorseFile` for validate image `avatar` image file.But in this case we cannot use that due to the `scope api` things? I'm not sure. But I can make it work with the `Rack::Multipart::UploadedFile` validator.
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/148130/diffs?pin=cea108c8e65432ebcb3ad330684741c82e30549c#cea108c8e65432ebcb3ad330684741c82e30549c_1390_1390
Could you please advise?
## MR acceptance checklist
**Please evaluate this MR against the **[**MR acceptance checklist**](https://docs.gitlab.com/ee/development/code_review.html#acceptance-checklist)**.** It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
## Screenshots or screen recordings
_Screenshots are required for UI changes, and strongly recommended for all other merge requests._
| Before | After |
|--------|-------|
| | |
## How to set up and validate locally
_Numbered steps to set up and validate the change are strongly suggested._Phawin KhongkhasawanPhawin Khongkhasawanhttps://gitlab.com/gitlab-org/gitlab/-/merge_requests/148114Draft: Periodically re-verify GPG keys2024-03-28T20:13:42ZJerry SetoDraft: Periodically re-verify GPG keys## What does this MR do and why?
<!--
Describe in detail what your merge request does and why.
Please keep this description updated with any discussion that takes place so
that reviewers can understand your intent. Keeping the descript...## What does this MR do and why?
<!--
Describe in detail what your merge request does and why.
Please keep this description updated with any discussion that takes place so
that reviewers can understand your intent. Keeping the description updated is
especially important if they didn't participate in the discussion.
-->
Periodically re-verify GPG keys
When verifiying signatures call integrations to revalidate a GPG key if the last validation time is more than 1 day ago.
## MR acceptance checklist
**Please evaluate this MR against the [MR acceptance checklist](https://docs.gitlab.com/ee/development/code_review.html#acceptance-checklist).**
It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
## How to set up and validate locally
_Numbered steps to set up and validate the change are strongly suggested._
<!--
Example below:
1. In rails console enable the experiment fully
```ruby
Feature.enable(:member_areas_of_focus)
```
1. Visit any group or project member pages such as `http://127.0.0.1:3000/groups/flightjs/-/group_members`
1. Click the `invite members` button.
-->
<!-- template sourced from https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/merge_request_templates/Default.md -->
Related to #44209816.11Jerry SetoJerry Setohttps://gitlab.com/gitlab-org/gitlab/-/merge_requests/148081Draft: Redirect profile ssh keys to user settings2024-03-28T16:22:49ZGavin HinfeyDraft: Redirect profile ssh keys to user settings## What does this MR do and why?
<!--
Describe in detail what your merge request does and why.
Please keep this description updated with any discussion that takes place so
that reviewers can understand your intent. Keeping the descript...## What does this MR do and why?
<!--
Describe in detail what your merge request does and why.
Please keep this description updated with any discussion that takes place so
that reviewers can understand your intent. Keeping the description updated is
especially important if they didn't participate in the discussion.
-->
Move /-/profile/keys to /-/user_settings/ssh_keys and
redirect end_point to new endpoint till next major release (17.0)
## MR acceptance checklist
**Please evaluate this MR against the [MR acceptance checklist](https://docs.gitlab.com/ee/development/code_review.html#acceptance-checklist).**
It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
## Screenshots or screen recordings
_Screenshots are required for UI changes, and strongly recommended for all other merge requests._
<!--
Please include any relevant screenshots or screen recordings that will assist
reviewers and future readers. If you need help visually verifying the change,
please leave a comment and ping a GitLab reviewer, maintainer, or MR coach.
-->
| Before | After |
| ------ | ------ |
| | |
## How to set up and validate locally
_Numbered steps to set up and validate the change are strongly suggested._
<!--
Example below:
1. In rails console enable the experiment fully
```ruby
Feature.enable(:member_areas_of_focus)
```
1. Visit any group or project member pages such as `http://127.0.0.1:3000/groups/flightjs/-/group_members`
1. Click the `invite members` button.
-->
<!-- template sourced from https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/merge_request_templates/Default.md -->
Related to #43281916.11Gavin HinfeyGavin Hinfeyhttps://gitlab.com/gitlab-org/gitlab/-/merge_requests/148078Add AI impact analytics dashboard placeholder2024-03-28T21:47:59ZAlex PennellsAdd AI impact analytics dashboard placeholder## What does this MR do and why?
Adds the basic skeleton for a new analytics dashboard behind the `ai_impact_analytics_dashboard` feature flag. This MR is simply adds the blank panel behind a feature flag. The panel content will be expa...## What does this MR do and why?
Adds the basic skeleton for a new analytics dashboard behind the `ai_impact_analytics_dashboard` feature flag. This MR is simply adds the blank panel behind a feature flag. The panel content will be expanded in a future MR.
## MR acceptance checklist
**Please evaluate this MR against the [MR acceptance checklist](https://docs.gitlab.com/ee/development/code_review.html#acceptance-checklist).**
It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
## Screenshots or screen recordings
<!--
Please include any relevant screenshots or screen recordings that will assist
reviewers and future readers. If you need help visually verifying the change,
please leave a comment and ping a GitLab reviewer, maintainer, or MR coach.
-->
| Groups | Projects |
| ------ | ------ |
| ![Screenshot_2024-03-28_at_11.52.18_AM](/uploads/4606b4958b4cc002a6a4abd2524a5a28/Screenshot_2024-03-28_at_11.52.18_AM.png) | ![Screenshot_2024-03-28_at_11.52.24_AM](/uploads/acb24f5a5abea20b4f483ac0ddd20ccb/Screenshot_2024-03-28_at_11.52.24_AM.png) |
| ![Screenshot_2024-03-28_at_11.53.42_AM](/uploads/d7936ba7cd5b6a1cca2dd715bfd2603a/Screenshot_2024-03-28_at_11.53.42_AM.png) | ![Screenshot_2024-03-28_at_11.53.34_AM](/uploads/c52769bccd9c9def354b59819cc4c38c/Screenshot_2024-03-28_at_11.53.34_AM.png) |
## How to set up and validate locally
1. Enable feature:
```
Feature.enable(:ai_impact_analytics_dashboard)
```
2. Navigate to the group analytics dashboards page:
```
http://gdk.test:3000/groups/GROUP/-/analytics/dashboards/
```
3. Click the `AI impact analytics` dashboard and you should see the placeholder panel
4. Navigate to the project analytics dashboards page:
```
http://gdk.test:3000/GROUP/PROJECT/-/analytics/dashboards/
```
5. Click the `AI impact analytics` dashboard and you should see the placeholder panel
<!-- template sourced from https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/merge_request_templates/Default.md -->
Related to #45148216.11Alex PennellsAlex Pennellshttps://gitlab.com/gitlab-org/gitlab/-/merge_requests/148052Fix incorrect relative path in unit test report docs2024-03-28T19:20:05ZLeo SingerFix incorrect relative path in unit test report docs## What does this MR do and why?
Fix incorrect relative path in unit test report docs.
## MR acceptance checklist
**Please evaluate this MR against the [MR acceptance checklist](https://docs.gitlab.com/ee/development/code_review.html#...## What does this MR do and why?
Fix incorrect relative path in unit test report docs.
## MR acceptance checklist
**Please evaluate this MR against the [MR acceptance checklist](https://docs.gitlab.com/ee/development/code_review.html#acceptance-checklist).**
It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
## Screenshots or screen recordings
_Screenshots are required for UI changes, and strongly recommended for all other merge requests._
<!--
Please include any relevant screenshots or screen recordings that will assist
reviewers and future readers. If you need help visually verifying the change,
please leave a comment and ping a GitLab reviewer, maintainer, or MR coach.
-->
| Before | After |
| ------ | ------ |
| | |
## How to set up and validate locally
_Numbered steps to set up and validate the change are strongly suggested._
<!--
Example below:
1. In rails console enable the experiment fully
```ruby
Feature.enable(:member_areas_of_focus)
```
1. Visit any group or project member pages such as `http://127.0.0.1:3000/groups/flightjs/-/group_members`
1. Click the `invite members` button.
-->
<!-- template sourced from https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/merge_request_templates/Default.md -->Leo SingerLeo Singerhttps://gitlab.com/gitlab-org/gitlab/-/merge_requests/148049Draft: Added frontend for overriding merge request change requests2024-03-27T14:29:26ZPhil HughesDraft: Added frontend for overriding merge request change requests## What does this MR do and why?
<!--
Describe in detail what your merge request does and why.
Please keep this description updated with any discussion that takes place so
that reviewers can understand your intent. Keeping the descript...## What does this MR do and why?
<!--
Describe in detail what your merge request does and why.
Please keep this description updated with any discussion that takes place so
that reviewers can understand your intent. Keeping the description updated is
especially important if they didn't participate in the discussion.
-->
Added frontend for overriding merge request change requests
https://gitlab.com/gitlab-org/gitlab/-/issues/430728
## MR acceptance checklist
**Please evaluate this MR against the [MR acceptance checklist](https://docs.gitlab.com/ee/development/code_review.html#acceptance-checklist).**
It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
## Screenshots or screen recordings
![Screenshot_2024-03-27_at_14.23.31](/uploads/551d5bf364dadd49720aae9bdd75a0ea/Screenshot_2024-03-27_at_14.23.31.png)
![Screenshot_2024-03-27_at_14.23.40](/uploads/e4f58c22d67ef239d023fe84bc5dcad0/Screenshot_2024-03-27_at_14.23.40.png)
## How to set up and validate locally
_Numbered steps to set up and validate the change are strongly suggested._
<!--
Example below:
1. In rails console enable the experiment fully
```ruby
Feature.enable(:member_areas_of_focus)
```
1. Visit any group or project member pages such as `http://127.0.0.1:3000/groups/flightjs/-/group_members`
1. Click the `invite members` button.
-->
<!-- template sourced from https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/merge_request_templates/Default.md -->16.11Phil HughesPhil Hughes