danger-review
Passed Started
by
@jprovaznik
Jan Provaznik
1Running with gitlab-runner 13.8.0-rc1 (28e2e34a)2 on prm-com-gitlab-org ae3bfce25Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images:danger ...6Authenticating with credentials from job payload (GitLab Registry)7Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images:danger ...8Using docker image sha256:6fee9504bd4ea16722e2b45dff4c1a49113f3bb99351ede63a74dc553d37a580 for registry.gitlab.com/gitlab-org/gitlab-build-images:danger with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:1486c5971842d6cef360238e1e58012c1bc10a4f96b3a03dee18e50e4093e3e0 ...10Running on runner-ae3bfce2-project-278964-concurrent-0 via runner-ae3bfce2-prm-1611219948-da325d2e...12$ eval "$CI_PRE_CLONE_SCRIPT"13Downloading archived master...14Connecting to storage.googleapis.com (172.217.193.128:443)15saving to '/tmp/gitlab.tar.gz'16gitlab.tar.gz 28% |********* | 109M 0:00:02 ETA17gitlab.tar.gz 86% |*************************** | 333M 0:00:00 ETA18gitlab.tar.gz 100% |********************************| 383M 0:00:00 ETA19'/tmp/gitlab.tar.gz' saved20Extracting tarball into /builds/gitlab-org/gitlab...21Fetching changes with git depth set to 20...22Reinitialized existing Git repository in /builds/gitlab-org/gitlab/.git/23remote: Enumerating objects: 3901, done. 24remote: Counting objects: 100% (1202/1202), done. 25remote: Compressing objects: 100% (338/338), done. 26remote: Total 611 (delta 427), reused 375 (delta 210), pack-reused 0 27Receiving objects: 100% (611/611), 1.26 MiB | 12.87 MiB/s, done.28Resolving deltas: 100% (427/427), completed with 231 local objects.30 * [new ref] 4f3fdfe7db3d43f5210a9b54d63b886876653acf -> refs/pipelines/24496620731Checking out 4f3fdfe7 as refs/merge-requests/52182/merge...32Skipping Git submodules setup34Checking cache for yarn-v1-3...35Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/yarn-v1-3 36Successfully extracted cache38$ source ./scripts/utils.sh39$ run_timed_command "retry yarn install --frozen-lockfile"40$ retry yarn install --frozen-lockfile41yarn install v1.21.142[1/5] Validating package.json...43[2/5] Resolving packages...44success Already up-to-date.45$ node ./scripts/frontend/postinstall.js46success Dependency postinstall check passed.47Done in 1.13s.48==> 'retry yarn install --frozen-lockfile' succeeded in 1 seconds.49$ danger --fail-on-errors=true --verbose50danger/roulette/Dangerfile:5: warning: already initialized constant Danger::Dangerfile::MESSAGE51danger/pipeline/Dangerfile:3: warning: previous definition of MESSAGE was here52WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.53WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.54WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.55WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.56WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.57WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.58WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.59WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.60WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.61WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.62WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.63WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.64WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.65WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.66WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.67WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.68WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.69WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.70WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.71WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.72WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.73WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.74WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.75WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.76WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.77WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.78WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.79WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.80WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.81WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.82Results:83Messages:84- [ ] **[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html)**:85If you want to create a changelog entry for GitLab FOSS, run the following:86 bin/changelog -m 52182 "Ban \`attributes_for\` for migration specs"87If you want to create a changelog entry for GitLab EE, run the following instead:88 bin/changelog --ee -m 52182 "Ban \`attributes_for\` for migration specs"89If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.90Markdown:91## Reviewer roulette92Changes that require review have been detected! A merge request is normally93reviewed by both a reviewer and a maintainer in its primary category (e.g.94~frontend or ~backend), and by a maintainer in all other categories.95To spread load more evenly across eligible reviewers, Danger has picked a candidate for each96review slot, based on their timezone. Feel free to97[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)98if you think someone else would be better-suited99or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.100To read more on how to use the reviewer roulette, please take a look at the101[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)102and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).103Please consider assigning a reviewer or maintainer who is a104[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.105Once you've decided who will review this merge request, mention them as you106normally would! Danger does not automatically notify them for you.107| Category | Reviewer | Maintainer |108| -------- | -------- | ---------- |109| ~backend | [Reuben Pereira](https://gitlab.com/rpereira2) (`@rpereira2`) (UTC+5.5, 2.5 hours behind `@godfat-gitlab`) | [Michael Kozono](https://gitlab.com/mkozono) (`@mkozono`) (UTC-8, 16 hours behind `@godfat-gitlab`) |110**If needed, you can retry the [`danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/977780637) that generated this comment.**112Not uploading cache yarn-v1-3 due to policy114Job succeeded