danger-review
Passed Started
by
@oregand

David O'Regan
1Running with gitlab-runner 13.8.0-rc1 (28e2e34a)2 on docker-auto-scale-com d5ae8d255Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images:danger ...6Authenticating with credentials from job payload (GitLab Registry)7Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images:danger ...8Using docker image sha256:667aeea4301a264b4719e52af0a23896997dd6fd97d95880a5ad1c80ad8b579a for registry.gitlab.com/gitlab-org/gitlab-build-images:danger with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:5c7c15199d161b533dd1fb667b427ca30422c5b64dd3261a55933af8507287ab ...10Running on runner-d5ae8d25-project-278964-concurrent-0 via runner-d5ae8d25-gsrm-1610658968-e0117d5d...12$ eval "$CI_PRE_CLONE_SCRIPT"13Downloading archived master...14Connecting to storage.googleapis.com (172.217.193.128:443)15saving to '/tmp/gitlab.tar.gz'16gitlab.tar.gz 2% | | 10.4M 0:00:35 ETA17gitlab.tar.gz 80% |************************* | 309M 0:00:00 ETA18gitlab.tar.gz 100% |********************************| 382M 0:00:00 ETA19'/tmp/gitlab.tar.gz' saved20Extracting tarball into /builds/gitlab-org/gitlab...21Fetching changes with git depth set to 20...22Reinitialized existing Git repository in /builds/gitlab-org/gitlab/.git/23remote: Enumerating objects: 507, done. 24remote: Counting objects: 100% (338/338), done. 25remote: Compressing objects: 100% (106/106), done. 26remote: Total 171 (delta 131), reused 100 (delta 62), pack-reused 0 27Receiving objects: 100% (171/171), 100.93 KiB | 5.61 MiB/s, done.28Resolving deltas: 100% (131/131), completed with 71 local objects.30 * [new ref] refs/pipelines/241909974 -> refs/pipelines/24190997431Checking out 8b17f8f1 as refs/merge-requests/50044/merge...32Skipping Git submodules setup34Checking cache for yarn-v1-3...35Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/yarn-v1-3 36Successfully extracted cache38$ source ./scripts/utils.sh39$ run_timed_command "retry yarn install --frozen-lockfile"40$ retry yarn install --frozen-lockfile41yarn install v1.21.142[1/5] Validating package.json...43[2/5] Resolving packages...44success Already up-to-date.45$ node ./scripts/frontend/postinstall.js46success Dependency postinstall check passed.47Done in 1.13s.48$ danger --fail-on-errors=true --verbose49==> 'retry yarn install --frozen-lockfile' succeeded in 1 seconds.50danger/roulette/Dangerfile:5: warning: already initialized constant Danger::Dangerfile::MESSAGE51danger/pipeline/Dangerfile:3: warning: previous definition of MESSAGE was here52WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.53WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.54WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.55WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.56WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.57WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.58WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.59WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.60WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.61WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.62WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.63WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.64WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.65WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.66WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.67WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.68WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.69WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.70WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.71WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.72WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.73WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.74WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.75WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.76WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.77WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.78WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.79WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.80WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.81WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.82WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.83WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.84WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.85WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.86WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.87WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.88WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.89WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.90WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.91WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.92WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.93WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.94WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.95WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.96WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.97WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.98WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.99WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.100WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.101WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.102WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.103WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.104WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.105WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.106WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.107WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.108WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.109WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.110WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.111WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.112WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.113WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.114WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.115WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.116WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.117WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.118WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.119WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.120Results:121Messages:122- [ ] This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is **recommended**. Reviews can happen after you merge.123Markdown:124## Documentation review125The following files require a review from a technical writer:126* `doc/operations/incident_management/img/incident_metrics_tab_v13_8.png`127* `doc/operations/incident_management/img/metric_image_url_dialog_v13_8.png`128* `doc/operations/incident_management/incidents.md`129The review does not need to block merging this merge request. See the:130- [Technical Writers assignments](https://about.gitlab.com/handbook/engineering/technical-writing/#designated-technical-writers) for the appropriate technical writer for this review.131- [Documentation workflows](https://docs.gitlab.com/ee/development/documentation/workflow.html) for information on when to assign a merge request for review.132**If needed, you can retry the [`danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/964505820) that generated this comment.**134Not uploading cache yarn-v1-3 due to policy136Job succeeded