danger-review
Passed Started
by
@toupeira
Markus Koller
1Running with gitlab-runner 13.7.0 (943fc252)2 on prm-com-gitlab-org ae3bfce25Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images:danger ...6Authenticating with credentials from job payload (GitLab Registry)7Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images:danger ...8Using docker image sha256:7ef70547d557a216d583d8778f0df3218253cef2fc841ddeb3d14019672c7507 for registry.gitlab.com/gitlab-org/gitlab-build-images:danger with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:7fb5495e497f441fe228cea9ed09a0a08f7c408f4044f0e6852bd1acd896350f ...10Running on runner-ae3bfce2-project-278964-concurrent-0 via runner-ae3bfce2-prm-1608725399-460c0197...12$ eval "$CI_PRE_CLONE_SCRIPT"13Downloading archived master...14Connecting to storage.googleapis.com (172.217.193.128:443)15saving to '/tmp/gitlab.tar.gz'16gitlab.tar.gz 39% |************ | 149M 0:00:01 ETA17gitlab.tar.gz 89% |**************************** | 335M 0:00:00 ETA18gitlab.tar.gz 100% |********************************| 374M 0:00:00 ETA19'/tmp/gitlab.tar.gz' saved20Extracting tarball into /builds/gitlab-org/gitlab...21Fetching changes with git depth set to 20...22Reinitialized existing Git repository in /builds/gitlab-org/gitlab/.git/23remote: Enumerating objects: 208, done. 24remote: Counting objects: 100% (157/157), done. 25remote: Compressing objects: 100% (80/80), done. 26remote: Total 91 (delta 75), reused 22 (delta 11), pack-reused 0 28 * [new ref] refs/pipelines/233794220 -> refs/pipelines/23379422029Checking out 0227843e as refs/merge-requests/50323/merge...30Skipping Git submodules setup32Checking cache for yarn-v1-3...33cache.zip is up to date 34Successfully extracted cache36$ source ./scripts/utils.sh37$ run_timed_command "retry yarn install --frozen-lockfile"38$ retry yarn install --frozen-lockfile39yarn install v1.21.140[1/5] Validating package.json...41[2/5] Resolving packages...42success Already up-to-date.43$ node ./scripts/frontend/postinstall.js44success Dependency postinstall check passed.45Done in 1.21s.46==> 'retry yarn install --frozen-lockfile' succeeded in 2 seconds.47$ danger --fail-on-errors=true --verbose48danger/roulette/Dangerfile:5: warning: already initialized constant Danger::Dangerfile::MESSAGE49danger/pipeline/Dangerfile:3: warning: previous definition of MESSAGE was here50WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.51WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.52WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.53WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.54WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.55WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.56WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.57WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.58WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.59WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.60WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.61WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.62WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.63WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.64WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.65WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.66WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.67WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.68WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.69WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.70WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.71WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.72WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.73WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.74WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.75WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.76WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.77WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.78WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.79WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.80WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.81WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.82WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.83WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.84WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.85WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.86WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.87WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.88WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.89WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.90WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.91WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.92WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.93WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.94WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.95WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.96WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.97WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.98WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.99WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.100WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.101WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.102WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.103WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.104WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.105WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.106WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.107WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.108WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.109WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.110WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.111WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.112WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.113WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.114WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.115WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.116WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.117WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.118WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.119WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.120WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.121WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.122WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.123WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.124WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.125WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.126WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.127WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.128WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.129WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.130WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.131WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.132WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.133WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.134WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.135WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.136WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.137WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.138WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.139WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.140Results:141Warnings:142- [ ] 7abe0f2589dbbc85514115296cb69e8d523c3b17: Commits that change 30 or more lines across at least 3 files must describe these changes in the commit body. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).143Messages:144- [ ] This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is **recommended**. Reviews can happen after you merge.145Markdown:146## Documentation review147The following files require a review from a technical writer:148* `doc/user/project/wiki/index.md`149The review does not need to block merging this merge request. See the:150- [Technical Writers assignments](https://about.gitlab.com/handbook/engineering/technical-writing/#designated-technical-writers) for the appropriate technical writer for this review.151- [Documentation workflows](https://docs.gitlab.com/ee/development/documentation/workflow.html) for information on when to assign a merge request for review.152## Reviewer roulette153Changes that require review have been detected! A merge request is normally154reviewed by both a reviewer and a maintainer in its primary category (e.g.155~frontend or ~backend), and by a maintainer in all other categories.156To spread load more evenly across eligible reviewers, Danger has picked a candidate for each157review slot, based on their timezone. Feel free to158[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)159if you think someone else would be better-suited, or the chosen person is unavailable.160To read more on how to use the reviewer roulette, please take a look at the161[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)162and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).163Please consider assigning a reviewer or maintainer who is a164[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.165Once you've decided who will review this merge request, mention them as you166normally would! Danger does not automatically notify them for you.167| Category | Reviewer | Maintainer |168| -------- | -------- | ---------- |169| ~backend | [Furkan Ayhan](https://gitlab.com/furkanayhan) (`@furkanayhan`) (UTC+3, 2 hours ahead of `@toupeira`) | [Igor Drozdov](https://gitlab.com/igor.drozdov) (`@igor.drozdov`) (UTC+3, 2 hours ahead of `@toupeira`) |170| ~frontend | [Justin Boyson](https://gitlab.com/jboyson) (`@jboyson`) (UTC-6, 7 hours behind `@toupeira`) | [Natalia Tepluhina](https://gitlab.com/ntepluhina) (`@ntepluhina`) (UTC+1, same timezone as `@toupeira`) |171| ~test ~Quality for `spec/features/*` | [Anastasia McDonald](https://gitlab.com/a_mcdonald) (`@a_mcdonald`) (UTC+13, 12 hours ahead of `@toupeira`) | Maintainer review is optional for ~test ~Quality for `spec/features/*` |172**If needed, you can retry the [`danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/929422702) that generated this comment.**174Not uploading cache yarn-v1-3 due to policy176Job succeeded