danger-review
Passed Started
by
@fabiopitino
Fabio Pitino
1Running with gitlab-runner 13.7.0-rc1 (98e2e32d)2 on docker-auto-scale-com 1d6b581d5Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images:danger ...6Authenticating with credentials from job payload (GitLab Registry)7Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images:danger ...8Using docker image sha256:7ef70547d557a216d583d8778f0df3218253cef2fc841ddeb3d14019672c7507 for registry.gitlab.com/gitlab-org/gitlab-build-images:danger with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:7fb5495e497f441fe228cea9ed09a0a08f7c408f4044f0e6852bd1acd896350f ...10Running on runner-1d6b581d-project-278964-concurrent-0 via runner-1d6b581d-gsrm-1608706747-cd78129f...12$ eval "$CI_PRE_CLONE_SCRIPT"13Downloading archived master...14Connecting to storage.googleapis.com (172.217.193.128:443)15saving to '/tmp/gitlab.tar.gz'16gitlab.tar.gz 5% |* | 21.4M 0:00:16 ETA17gitlab.tar.gz 82% |************************** | 309M 0:00:00 ETA18gitlab.tar.gz 100% |********************************| 373M 0:00:00 ETA19'/tmp/gitlab.tar.gz' saved20Extracting tarball into /builds/gitlab-org/gitlab...21Fetching changes with git depth set to 20...22Reinitialized existing Git repository in /builds/gitlab-org/gitlab/.git/23remote: Enumerating objects: 838, done. 24remote: Counting objects: 100% (534/534), done. 25remote: Compressing objects: 100% (163/163), done. 26remote: Total 223 (delta 191), reused 89 (delta 60), pack-reused 027Receiving objects: 100% (223/223), 32.25 KiB | 1.54 MiB/s, done.28Resolving deltas: 100% (191/191), completed with 110 local objects.30 * [new ref] refs/pipelines/233707187 -> refs/pipelines/23370718731Checking out f59aba33 as refs/merge-requests/49462/merge...32Skipping Git submodules setup34Checking cache for yarn-v1-3...35Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/yarn-v1-3 36Successfully extracted cache38$ source ./scripts/utils.sh39$ run_timed_command "retry yarn install --frozen-lockfile"40$ retry yarn install --frozen-lockfile41yarn install v1.21.142[1/5] Validating package.json...43[2/5] Resolving packages...44success Already up-to-date.45$ node ./scripts/frontend/postinstall.js46success Dependency postinstall check passed.47Done in 1.29s.48==> 'retry yarn install --frozen-lockfile' succeeded in 1 seconds.49$ danger --fail-on-errors=true --verbose50danger/roulette/Dangerfile:5: warning: already initialized constant Danger::Dangerfile::MESSAGE51danger/pipeline/Dangerfile:3: warning: previous definition of MESSAGE was here52WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.53WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.54WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.55WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.56WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.57WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.58WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.59WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.60WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.61WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.62WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.63WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.64WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.65WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.66WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.67WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.68WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.69WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.70WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.71WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.72WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.73WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.74WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.75WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.76WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.77WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.78WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.79WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.80WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.81WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.82WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.83WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.84WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.85WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.86WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.87WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.88WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.89WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.90WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.91WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.92WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.93WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.94WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.95WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.96WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.97WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.98WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.99WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.100WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.101WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.102WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.103WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.104WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.105WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.106WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.107WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.108WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.109WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.110WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.111WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.112WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.113WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.114WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.115WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.116WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.117WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.118WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.119WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.120WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.121WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.122WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.123WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.124WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.125WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.126WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.127WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.128WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.129WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.130WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.131WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.132WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.133WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.134WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.135WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.136WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.137WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.138WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.139WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.140WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.141WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.142WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.143WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.144WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.145WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.146WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.147WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.148WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.149WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.150WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.151WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.152WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.153WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.154WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.155WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.156WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.157WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.158WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.159WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.160WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.161WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.162WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.163WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.164WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.165WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.166WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.167WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.168WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.169WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.170WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.171WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.172Results:173Messages:174- [ ] **[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html)**:175If you want to create a changelog entry for GitLab FOSS, run the following:176 bin/changelog -m 49462 "Implement exit code functionality for allow_failure"177If you want to create a changelog entry for GitLab EE, run the following instead:178 bin/changelog --ee -m 49462 "Implement exit code functionality for allow_failure"179If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.180Markdown:181## Reviewer roulette182Changes that require review have been detected! A merge request is normally183reviewed by both a reviewer and a maintainer in its primary category (e.g.184~frontend or ~backend), and by a maintainer in all other categories.185To spread load more evenly across eligible reviewers, Danger has picked a candidate for each186review slot, based on their timezone. Feel free to187[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)188if you think someone else would be better-suited, or the chosen person is unavailable.189To read more on how to use the reviewer roulette, please take a look at the190[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)191and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).192Please consider assigning a reviewer or maintainer who is a193[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.194Once you've decided who will review this merge request, mention them as you195normally would! Danger does not automatically notify them for you.196| Category | Reviewer | Maintainer |197| -------- | -------- | ---------- |198| ~backend | [Nikola Milojevic](https://gitlab.com/nmilojevic1) (`@nmilojevic1`) (UTC+1, 1 hour behind `@mbobin`) | [Mayra Cabrera](https://gitlab.com/mayra-cabrera) (`@mayra-cabrera`) (UTC-6, 8 hours behind `@mbobin`) |199**If needed, you can retry the [`danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/929050837) that generated this comment.**201Not uploading cache yarn-v1-3 due to policy203Job succeeded