danger-review

Passed Started 4 years ago by
1Running with gitlab-runner 13.6.0 (8fa89735)
2  on prm-com-gitlab-org ae3bfce2
 3  Resolving secrets  
  00:00
 4  Preparing the "docker+machine" executor  
  00:07
5Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images:danger ...
6Authenticating with credentials from job payload (GitLab Registry)
7Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images:danger ...
8Using docker image sha256:c2918d6944f54c63f7d8a381d18257af5b62339816c194923f6a5c6cda475db4 for registry.gitlab.com/gitlab-org/gitlab-build-images:danger with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:6295637471a0a6c47794a8d34436b6f96498bb41c29a5fd8e6a2990ef07f6004 ...
 9  Preparing environment  
  00:01
10Running on runner-ae3bfce2-project-278964-concurrent-0 via runner-ae3bfce2-prm-1607435189-81d64e72...
 11  Getting source from Git repository  
  00:32
12$ eval "$CI_PRE_CLONE_SCRIPT"
13Downloading archived master...
14Connecting to storage.googleapis.com (172.217.193.128:443)
15saving to '/tmp/gitlab.tar.gz'
16gitlab.tar.gz         86% |***************************     |  321M  0:00:00 ETA
17gitlab.tar.gz        100% |********************************|  371M  0:00:00 ETA
18'/tmp/gitlab.tar.gz' saved
19Extracting tarball into /builds/gitlab-org/gitlab...
20Fetching changes with git depth set to 20...
21Reinitialized existing Git repository in /builds/gitlab-org/gitlab/.git/
22remote: Enumerating objects: 1015, done.        
23remote: Counting objects: 100% (470/470), done.        
24remote: Compressing objects: 100% (184/184), done.        
25remote: Total 271 (delta 192), reused 154 (delta 83), pack-reused 0        
26Receiving objects: 100% (271/271), 46.48 KiB | 11.62 MiB/s, done.
27Resolving deltas: 100% (192/192), completed with 104 local objects.
28From https://gitlab.com/gitlab-org/gitlab
29 * [new ref]               refs/pipelines/226973828 -> refs/pipelines/226973828
30Checking out 4e164e98 as refs/merge-requests/48922/merge...
31Skipping Git submodules setup
 32  Restoring cache  
  00:27
33Checking cache for yarn-v1-3...
34Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/yarn-v1-3 
35Successfully extracted cache
 36  Executing "step_script" stage of the job script  
  00:13
37$ source ./scripts/utils.sh
38$ run_timed_command "retry yarn install --frozen-lockfile"
39$ retry yarn install --frozen-lockfile
40yarn install v1.21.1
41[1/5] Validating package.json...
42[2/5] Resolving packages...
43success Already up-to-date.
44$ node ./scripts/frontend/postinstall.js
45success Dependency postinstall check passed.
46Done in 1.22s.
47==> 'retry yarn install --frozen-lockfile' succeeded in 2 seconds.
48$ danger --fail-on-errors=true --verbose
49danger/roulette/Dangerfile:5: warning: already initialized constant Danger::Dangerfile::MESSAGE
50danger/pipeline/Dangerfile:3: warning: previous definition of MESSAGE was here
51WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
52WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
53WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
54WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
55WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
56WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
57WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
58WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
59WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
60WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
61WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
62WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
63WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
64WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
65WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
66WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
67WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
68WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
69WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
70WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
71WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
72WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
73WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
74WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
75WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
76WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
77WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
78WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
79WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
80WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
81WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
82WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
83WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
84WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
85WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
86WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
87WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
88WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
89WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
90WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
91WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
92WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
93WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
94WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
95WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
96WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
97WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
98WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
99WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
100WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
101WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
102WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
103WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
104WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
105WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
106WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
107WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
108WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
109WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
110WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
111WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
112WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
113WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
114WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
115WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
116WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
117WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
118WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
119WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
120WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
121WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
122WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
123WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
124WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
125WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
126WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
127WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
128WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
129WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
130WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
131WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
132WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
133WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
134WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
135WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
136WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
137WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
138WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
139WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
140WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
141WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
142WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
143WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
144WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
145WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
146WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
147WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
148WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
149WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
150WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
151WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
152WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
153WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
154WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
155WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
156WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
157WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
158WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
159WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
160WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
161WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
162WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
163WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
164WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
165WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
166WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
167WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
168WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
169WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
170WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
171WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
172WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
173WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
174WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
175WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
176WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
177WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
178WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
179WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
180WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
181WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
182WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
183WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
184WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
185WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
186WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
187WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
188WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
189WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
190WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
191WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
192WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
193WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
194WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
195WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
196WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
197WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
198WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
199WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
200WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
201WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
202WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
203WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
204WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
205WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
206WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
207WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
208WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
209WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
210WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
211WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
212WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
213WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
214WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
215WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
216WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
217WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
218WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
219WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
220WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
221WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
222WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
223WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
224WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
225WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
226WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
227WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
228WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
229WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
230WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
231WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
232WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
233WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
234WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
235WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
236WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
237WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
238WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
239WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
240WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
241WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
242WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
243WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
244WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
245WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
246WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
247WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
248WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
249WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
250WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
251WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
252WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
253WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
254WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
255WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
256WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
257WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
258WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
259WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
260WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
261Results:
262Warnings:
263- [ ] This merge request changed files with disabled eslint rules. Please consider fixing them.
264Messages:
265- [ ] **[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html)**:
266If you want to create a changelog entry for GitLab FOSS, run the following:
267    bin/changelog -m 48922 "Add admin users vue app wrapper"
268If you want to create a changelog entry for GitLab EE, run the following instead:
269    bin/changelog --ee -m 48922 "Add admin users vue app wrapper"
270If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.
271Markdown:
272## Disabled eslint rules
273The following files have disabled `eslint` rules. Please consider fixing them:
274* `app/assets/javascripts/pages/admin/users/index.js`
275Run the following command for more details
276```
277node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \
278  'app/assets/javascripts/pages/admin/users/index.js'
279```
280## Reviewer roulette
281Changes that require review have been detected! A merge request is normally
282reviewed by both a reviewer and a maintainer in its primary category (e.g.
283~frontend or ~backend), and by a maintainer in all other categories.
284To spread load more evenly across eligible reviewers, Danger has picked a candidate for each
285review slot, based on their timezone. Feel free to
286[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)
287if you think someone else would be better-suited, or the chosen person is unavailable.
288To read more on how to use the reviewer roulette, please take a look at the
289[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)
290and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).
291Please consider assigning a reviewer or maintainer who is a
292[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.
293Once you've decided who will review this merge request, mention them as you
294normally would! Danger does not automatically notify them for you.
295| Category | Reviewer | Maintainer |
296| -------- | -------- | ---------- |
297| ~backend | [Adrien Kohlbecker](https://gitlab.com/akohlbecker) (`@akohlbecker`) (UTC+1, 1 hour behind `@jiaan`) | [Rémy Coutable](https://gitlab.com/rymai) (`@rymai`) (UTC+1, 1 hour behind `@jiaan`) |
298| ~frontend | [Tom Quirk](https://gitlab.com/tomquirk) (`@tomquirk`) (UTC+10, 8 hours ahead of `@jiaan`) | [Jacques Erasmus](https://gitlab.com/jerasmus) (`@jerasmus`) (UTC+2, same timezone as `@jiaan`) |
299| ~test ~Quality for `spec/features/*` | [Adrien Kohlbecker](https://gitlab.com/akohlbecker) (`@akohlbecker`) (UTC+1, 1 hour behind `@jiaan`) | Maintainer review is optional for ~test ~Quality for `spec/features/*` |
300**If needed, you can retry the [`danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/898090081) that generated this comment.**
 301  Saving cache for successful job  
  00:00
302Not uploading cache yarn-v1-3 due to policy
 303  Cleaning up file based variables  
  00:01
304Job succeeded