Skip to content
Snippets Groups Projects

danger-review

Passed Started by
Fabio Pitino
@fabiopitino
1Running with gitlab-runner 13.6.0 (8fa89735)
2 on docker-auto-scale-com 1d6b581d
3 Resolving secrets 00:00
4 Preparing the "docker+machine" executor 00:34
5Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images:danger ...
6Authenticating with credentials from job payload (GitLab Registry)
7Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images:danger ...
8Using docker image sha256:87a973587ec9475ed3e51ef812dd7cb9521b2d7d5adbdc18a4ffb4582911fefd for registry.gitlab.com/gitlab-org/gitlab-build-images:danger with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:a57e82a6e69526d3f61aed4094f19309626b307a9d06d5ac8ede7060df2645a2 ...
9 Preparing environment 00:05
10Running on runner-1d6b581d-project-278964-concurrent-0 via runner-1d6b581d-gsrm-1606470064-4fb08b65...
11 Getting source from Git repository 00:33
12$ eval "$CI_PRE_CLONE_SCRIPT"
13Downloading archived master...
14Connecting to storage.googleapis.com (172.217.204.128:443)
15saving to '/tmp/gitlab.tar.gz'
16gitlab.tar.gz 84% |*************************** | 307M 0:00:00 ETA
17gitlab.tar.gz 100% |********************************| 363M 0:00:00 ETA
18'/tmp/gitlab.tar.gz' saved
19Extracting tarball into /builds/gitlab-org/gitlab...
20Fetching changes with git depth set to 20...
21Reinitialized existing Git repository in /builds/gitlab-org/gitlab/.git/
22remote: Enumerating objects: 1955, done.
23remote: Counting objects: 100% (933/933), done.
24remote: Compressing objects: 100% (337/337), done.
25remote: Total 439 (delta 343), reused 182 (delta 98), pack-reused 0
26Receiving objects: 100% (439/439), 115.95 KiB | 6.10 MiB/s, done.
27Resolving deltas: 100% (343/343), completed with 205 local objects.
28From https://gitlab.com/gitlab-org/gitlab
29 * [new ref] refs/pipelines/222159801 -> refs/pipelines/222159801
30Checking out 8e6107fd as refs/merge-requests/46575/merge...
31Skipping Git submodules setup
32 Restoring cache 00:53
33Checking cache for yarn-v1-3...
34Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/yarn-v1-3
35Successfully extracted cache
36 Executing "step_script" stage of the job script 00:09
37$ source ./scripts/utils.sh
38$ run_timed_command "retry yarn install --frozen-lockfile"
39$ retry yarn install --frozen-lockfile
40yarn install v1.21.1
41[1/5] Validating package.json...
42[2/5] Resolving packages...
43success Already up-to-date.
44$ node ./scripts/frontend/postinstall.js
45success Dependency postinstall check passed.
46Done in 1.41s.
47==> 'retry yarn install --frozen-lockfile' succeeded in 2 seconds.
48$ danger --fail-on-errors=true --verbose
49WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
50WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
51WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
52WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
53WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
54WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
55WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
56WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
57WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
58WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
59WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
60WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
61WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
62WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
63WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
64WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
65WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
66WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
67WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
68WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
69WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
70WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
71WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
72WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
73WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
74WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
75WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
76WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
77WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
78WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
79WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
80WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
81WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
82WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
83WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
84WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
85WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
86WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
87WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
88WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
89WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
90WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
91WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
92WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
93WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
94WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
95WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
96WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
97WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
98WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
99WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
100WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
101WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
102WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
103WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
104WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
105WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
106WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
107WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
108WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
109WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
110WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
111WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
112WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
113WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
114WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
115WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
116WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
117WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
118WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
119WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
120WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
121WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
122WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
123WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
124WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
125WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
126WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
127WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
128WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
129WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
130WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
131WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
132WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
133WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
134WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
135WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
136WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
137WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
138WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
139WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
140WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
141WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
142WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
143WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
144WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
145WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
146WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
147WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
148WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
149WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
150WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
151WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
152WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
153WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
154WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
155WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
156WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
157WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
158WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
159WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
160WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
161WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
162WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.
163Results:
164Messages:
165- [ ] **[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html)**:
166If you want to create a changelog entry for GitLab FOSS, run the following:
167 bin/changelog -m 46575 "Fix query timeout when finding auto-cancelable pipelines"
168If you want to create a changelog entry for GitLab EE, run the following instead:
169 bin/changelog --ee -m 46575 "Fix query timeout when finding auto-cancelable pipelines"
170If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.
171Markdown:
172## Reviewer roulette
173Changes that require review have been detected! A merge request is normally
174reviewed by both a reviewer and a maintainer in its primary category (e.g.
175~frontend or ~backend), and by a maintainer in all other categories.
176To spread load more evenly across eligible reviewers, Danger has picked a candidate for each
177review slot, based on their timezone. Feel free to
178[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)
179if you think someone else would be better-suited, or the chosen person is unavailable.
180To read more on how to use the reviewer roulette, please take a look at the
181[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)
182and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).
183Please consider assigning a reviewer or maintainer who is a
184[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.
185Once you've decided who will review this merge request, mention them as you
186normally would! Danger does not automatically notify them for you.
187| Category | Reviewer | Maintainer |
188| -------- | -------- | ---------- |
189| ~backend | [Tiger Watson](https://gitlab.com/tigerwnz) (`@tigerwnz`) (UTC+11, 11 hours ahead of `@fabiopitino`) | [Mayra Cabrera](https://gitlab.com/mayra-cabrera) (`@mayra-cabrera`) (UTC-6, 6 hours behind `@fabiopitino`) |
190| ~database | [Can Eldem](https://gitlab.com/caneldem) (`@caneldem`) (UTC+0, same timezone as `@fabiopitino`) | [Yannis Roussos](https://gitlab.com/iroussos) (`@iroussos`) (UTC+2, 2 hours ahead of `@fabiopitino`) |
191**If needed, you can retry the [`danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/876782556) that generated this comment.**
192 Saving cache for successful job 00:02
193Not uploading cache yarn-v1-3 due to policy
194 Cleaning up file based variables 00:03
195Job succeeded