danger-review
Passed Started
by
@jivanvl
Jose Ivan Vargas
1Running with gitlab-runner 13.6.0-rc1 (d83ac56c)2 on docker-auto-scale-com 1d6b581d5Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images:danger ...6Authenticating with credentials from job payload (GitLab Registry)7Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images:danger ...8Using docker image sha256:87a973587ec9475ed3e51ef812dd7cb9521b2d7d5adbdc18a4ffb4582911fefd for registry.gitlab.com/gitlab-org/gitlab-build-images:danger with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:a57e82a6e69526d3f61aed4094f19309626b307a9d06d5ac8ede7060df2645a2 ...10Running on runner-1d6b581d-project-278964-concurrent-0 via runner-1d6b581d-gsrm-1606144778-a69200ba...12$ eval "$CI_PRE_CLONE_SCRIPT"13Downloading archived master...14Connecting to storage.googleapis.com (172.217.193.128:443)15saving to '/tmp/gitlab.tar.gz'16gitlab.tar.gz 73% |*********************** | 264M 0:00:00 ETA17gitlab.tar.gz 100% |********************************| 361M 0:00:00 ETA18'/tmp/gitlab.tar.gz' saved19Extracting tarball into /builds/gitlab-org/gitlab...20Fetching changes with git depth set to 20...21Reinitialized existing Git repository in /builds/gitlab-org/gitlab/.git/22Checking out 36f233ee as refs/merge-requests/41402/merge...23Skipping Git submodules setup25Checking cache for yarn-v1-3...26Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/yarn-v1-3 27Successfully extracted cache29$ source ./scripts/utils.sh30$ run_timed_command "retry yarn install --frozen-lockfile"31$ retry yarn install --frozen-lockfile32yarn install v1.21.133[1/5] Validating package.json...34[2/5] Resolving packages...35[3/5] Fetching packages...36warning sha.js@2.4.10: Invalid bin entry for "sha.js" (in "sha.js").37info fsevents@2.1.3: The platform "linux" is incompatible with this module.38info "fsevents@2.1.3" is an optional dependency and failed compatibility check. Excluding it from installation.39[4/5] Linking dependencies...40warning "@gitlab/eslint-plugin > eslint-plugin-jest > @typescript-eslint/experimental-utils > @typescript-eslint/typescript-estree > tsutils@3.17.1" has unmet peer dependency "typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta".41warning " > eslint-import-resolver-jest@2.1.2" has unmet peer dependency "eslint-plugin-import@>=1.4.0".42warning " > eslint-import-resolver-webpack@0.12.1" has unmet peer dependency "eslint-plugin-import@>=1.4.0".43warning "vue-jest > ts-jest@26.4.1" has unmet peer dependency "typescript@>=3.8 <5.0".44[5/5] Building fresh packages...45$ node ./scripts/frontend/postinstall.js46success Dependency postinstall check passed.47Done in 70.04s.48==> 'retry yarn install --frozen-lockfile' succeeded in 70 seconds.49$ danger --fail-on-errors=true --verbose50WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.51WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.52WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.53WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.54WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.55WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.56WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.57WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.58WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.59WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.60WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.61WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.62WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.63WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.64WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.65WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.66WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.67WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.68WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.69WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.70WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.71WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.72WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.73WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.74WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.75WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.76WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.77WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.78WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.79WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.80WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.81WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.82WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.83WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.84WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.85WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.86WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.87WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.88WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.89WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.90WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.91WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.92WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.93WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.94WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.95WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.96WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.97WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.98WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.99WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.100WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.101WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.102WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.103WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.104WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.105WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.106WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.107WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.108WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.109WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.110WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.111WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.112WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.113WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.114WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.115WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.116WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.117WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.118WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.119WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.120WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.121WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.122WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.123WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.124WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.125WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.126WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.127WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.128WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.129WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.130WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.131WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.132WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.133WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.134WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.135WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.136WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.137WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.138WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.139WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.140WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.141WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.142WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.143WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.144WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.145WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.146WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.147WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.148WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.149WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.150WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.151WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.152WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.153WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.154WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.155WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.156WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.157WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.158WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.159WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.160WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.161WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.162WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.163WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.164WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.165WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.166WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.167WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.168WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.169WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.170WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.171WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.172WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.173WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.174WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.175WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.176WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.177WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.178WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.179WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.180WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.181WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.182WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.183WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.184WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.185WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.186WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.187WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.188WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.189WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.190WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.191WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.192WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.193WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.194WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.195WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.196WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.197WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.198WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.199WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.200WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.201WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.202WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.203WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.204WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.205WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.206WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.207WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.208WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.209WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.210WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.211WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.212WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.213WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.214Results:215Warnings:216- [ ] ~"feature::addition" and ~"feature::enhancement" merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the [Technical Writer counterpart](https://about.gitlab.com/handbook/engineering/ux/technical-writing/#designated-technical-writers).217For more information, see:218- The Handbook page on [throughput implementation](https://about.gitlab.com/handbook/engineering/management/throughput/#implementation).219- The [definition of done](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#definition-of-done) documentation.220Markdown:221## Reviewer roulette222Changes that require review have been detected! A merge request is normally223reviewed by both a reviewer and a maintainer in its primary category (e.g.224~frontend or ~backend), and by a maintainer in all other categories.225To spread load more evenly across eligible reviewers, Danger has picked a candidate for each226review slot, based on their timezone. Feel free to227[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)228if you think someone else would be better-suited, or the chosen person is unavailable.229To read more on how to use the reviewer roulette, please take a look at the230[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)231and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).232Please consider assigning a reviewer or maintainer who is a233[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.234Once you've decided who will review this merge request, mention them as you235normally would! Danger does not automatically notify them for you.236| Category | Reviewer | Maintainer |237| -------- | -------- | ---------- |238| ~frontend | [Tomas Vik](https://gitlab.com/viktomas) (`@viktomas`) (UTC+1, 1 hour ahead of `@pedroms`) | [Kushal Pandya](https://gitlab.com/kushalpandya) (`@kushalpandya`) (UTC+5.5, 5.5 hours ahead of `@pedroms`) |239| ~test ~Quality for `spec/features/*` | [Mark Lapierre](https://gitlab.com/mlapierre) (`@mlapierre`) (UTC+11, 11 hours ahead of `@pedroms`) | Maintainer review is optional for ~test ~Quality for `spec/features/*` |240**If needed, you can retry the [`danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/867557896) that generated this comment.**242Not uploading cache yarn-v1-3 due to policy244Job succeeded