Skip to content
Snippets Groups Projects

danger-review

Passed Started by
🤖 GitLab Bot 🤖
@gitlab-bot
Log timestamps in UTC.
111:38:20Running with gitlab-runner 17.4.0~pre.110.g27400594 (27400594)
211:38:20 on blue-8.private.runners-manager.gitlab.com/gitlab.com/gitlab-org t2_JMznMq, system ID: s_d955b1c3cfe6
311:38:20 feature flags: FF_NETWORK_PER_BUILD:true, FF_TIMESTAMPS:true
411:38:20Resolving secrets
5 11:38:20 Preparing the "docker+machine" executor 00:03
611:38:20Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.2.5-golang-1.23-rust-1.73-node-20.12-postgresql-14:rubygems-3.5-git-2.45-lfs-2.9-chrome-123-yarn-1.22-graphicsmagick-1.3.36 ...
711:38:23Authenticating with credentials from job payload (GitLab Registry)
811:38:23Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.2.5-golang-1.23-rust-1.73-node-20.12-postgresql-14:rubygems-3.5-git-2.45-lfs-2.9-chrome-123-yarn-1.22-graphicsmagick-1.3.36 ...
911:38:23Using docker image sha256:48db929a55a2be5110b5960190ff38acfc40d29bc36ea646709c22fc8c84cdc4 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.2.5-golang-1.23-rust-1.73-node-20.12-postgresql-14:rubygems-3.5-git-2.45-lfs-2.9-chrome-123-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.2.5-golang-1.23-rust-1.73-node-20.12-postgresql-14@sha256:65458f152848ae0ef6490ac865d187b22b81b56beb95a413093fd14812c834d2 ...
10 11:38:23 Preparing environment 00:00
1111:38:23Running on runner-t2jmznmq-project-278964-concurrent-0 via runner-t2jmznmq-private-1734509776-f2672a6c...
12 11:38:23 Getting source from Git repository 00:44
1311:38:24Fetching changes with git depth set to 20...
1411:38:24Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/
1511:38:24Created fresh repository.
1611:38:27remote: Enumerating objects: 232539, done.
1711:38:27remote: Counting objects: 100% (232539/232539), done.
1811:38:31remote: Compressing objects: 100% (151551/151551), done.
1911:38:32remote: Total 232539 (delta 122186), reused 155288 (delta 72426), pack-reused 0 (from 0)
2011:38:38Receiving objects: 100% (232539/232539), 185.67 MiB | 30.14 MiB/s, done.
2111:38:38Resolving deltas: 100% (122186/122186), done.
2211:38:51From https://us-east1-d.ci-gateway.int.gprd.gitlab.net:8989/gitlab-org/gitlab
2311:38:51 * [new ref] refs/pipelines/1594029751 -> refs/pipelines/1594029751
2411:38:51Checking out 589aebd3 as detached HEAD (ref is refs/merge-requests/175971/merge)...
2511:39:06Skipping Git submodules setup
2611:39:06$ git remote set-url origin "${CI_REPOSITORY_URL}"
27 11:39:07 Restoring cache 00:39
2811:39:07Checking cache for ruby-gems-debian-bookworm-ruby-3.2.5-gemfile-Gemfile-21...
2911:39:07Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-debian-bookworm-ruby-3.2.5-gemfile-Gemfile-21 ETag="93620edbbeef201e2dcdb4e451146dbd"
3011:39:21Successfully extracted cache
3111:39:21Checking cache for node-modules-debian-bookworm-test-21...
3211:39:21Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-debian-bookworm-test-21 ETag="e2983797ad3b21de9cdce0b56d8b0255"
3311:39:40Successfully extracted cache
34 11:39:46 Executing "step_script" stage of the job script 00:49
3511:39:46Using docker image sha256:48db929a55a2be5110b5960190ff38acfc40d29bc36ea646709c22fc8c84cdc4 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.2.5-golang-1.23-rust-1.73-node-20.12-postgresql-14:rubygems-3.5-git-2.45-lfs-2.9-chrome-123-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.2.5-golang-1.23-rust-1.73-node-20.12-postgresql-14@sha256:65458f152848ae0ef6490ac865d187b22b81b56beb95a413093fd14812c834d2 ...
3611:39:47$ source scripts/utils.sh
3711:39:47$ bundle_install_script
38 11:39:47 Installing gems 00:23
7111:40:10$ yarn_install_script
72 11:40:10 Installing Yarn packages 00:05
9711:40:15$ if [[ "$CI_MERGE_REQUEST_PROJECT_URL" != "$CI_MERGE_REQUEST_SOURCE_PROJECT_URL" || -z "${DANGER_GITLAB_API_TOKEN}" ]]; then # collapsed multi-line command
9811:40:15$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command
9911:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/ai_logging.rb
10011:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/analytics_instrumentation.rb
10111:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/bulk_database_actions.rb
10211:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/change_column_default.rb
10311:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/ci_templates.rb
10411:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/clickhouse.rb
10511:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb
10611:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/cookie_setting.rb
10711:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb
10811:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database.rb
10911:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb
11011:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb
11111:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/experiments.rb
11211:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb
11311:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/gitlab_schema_validation.rb
11411:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/ignored_model_columns.rb
11511:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/internal_users.rb
11611:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/master_pipeline_status.rb
11711:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/model_validations.rb
11811:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb
11911:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb
12011:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/remote_development.rb
12111:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/rubocop.rb
12211:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/saas_feature.rb
12311:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/settings_sections.rb
12411:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb
12511:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb
12611:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb
12711:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb
12811:40:21Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/todos.rb
12911:40:21Importing rule ai_logging at /builds/gitlab-org/gitlab/danger/ai_logging
13011:40:22Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation
13111:40:22Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture
13211:40:22Importing rule bulk_database_actions at /builds/gitlab-org/gitlab/danger/bulk_database_actions
13311:40:22Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates
13411:40:22Importing rule change_column_default at /builds/gitlab-org/gitlab/danger/change_column_default
13511:40:22Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.8.0/lib/danger/rules/changelog
13611:40:22Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.8.0/lib/danger/rules/changes_size
13711:40:35Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config
13811:40:35Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables
13911:40:35Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates
14011:40:35Importing rule clickhouse at /builds/gitlab-org/gitlab/danger/clickhouse
14111:40:35Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.8.0/lib/danger/rules/commit_messages
14211:40:35Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.8.0/lib/danger/rules/commits_counter
14311:40:35Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files
14411:40:35Importing rule cookie_setting at /builds/gitlab-org/gitlab/danger/cookie_setting
14511:40:35Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success
14611:40:35Importing rule database at /builds/gitlab-org/gitlab/danger/database
14711:40:35Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam
14811:40:35Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation
14911:40:35Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies
15011:40:35Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint
15111:40:35Importing rule experiments at /builds/gitlab-org/gitlab/danger/experiments
15211:40:35Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag
15311:40:35Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly
15411:40:35Importing rule gitlab_schema_validation at /builds/gitlab-org/gitlab/danger/gitlab_schema_validation
15511:40:35Importing rule ignored_model_columns at /builds/gitlab-org/gitlab/danger/ignored_model_columns
15611:40:35Importing rule internal_users at /builds/gitlab-org/gitlab/danger/internal_users
15711:40:35Importing rule master_pipeline_status at /builds/gitlab-org/gitlab/danger/master_pipeline_status
15811:40:35Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.8.0/lib/danger/rules/metadata
15911:40:35Importing rule model_validations at /builds/gitlab-org/gitlab/danger/model_validations
16011:40:35Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion
16111:40:35Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline
16211:40:35Importing rule pipeline_config at /builds/gitlab-org/gitlab/danger/pipeline_config
16311:40:35Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector
16411:40:35Importing rule remote_development at /builds/gitlab-org/gitlab/danger/remote_development
16511:40:35Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette
16611:40:35Importing rule rubocop at /builds/gitlab-org/gitlab/danger/rubocop
16711:40:35Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems
16811:40:35Importing rule saas_feature at /builds/gitlab-org/gitlab/danger/saas_feature
16911:40:35Importing rule secrets_initializer at /builds/gitlab-org/gitlab/danger/secrets_initializer
17011:40:35Importing rule settings_sections at /builds/gitlab-org/gitlab/danger/settings_sections
17111:40:35Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args
17211:40:35Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues
17311:40:35Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels
17411:40:35Importing rule specs at /builds/gitlab-org/gitlab/danger/specs
17511:40:35Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch
17611:40:35Importing rule todos at /builds/gitlab-org/gitlab/danger/todos
17711:40:35Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.8.0/lib/danger/rules/type_label
17811:40:35Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css
17911:40:35Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation
18011:40:35Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.8.0/lib/danger/rules/z_add_labels
18111:40:35Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.8.0/lib/danger/rules/z_retry_link
18211:40:35Results:
18311:40:35Warnings:
18411:40:35- [ ] ~"feature::addition" and ~"feature::enhancement" merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the [Technical Writer counterpart](https://handbook.gitlab.com/handbook/product/ux/technical-writing/#assignments).
18511:40:35For more information, see:
18611:40:35- The Handbook page on [merge request types](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification).
18711:40:35- The [definition of done](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#definition-of-done) documentation.
18811:40:35Messages:
18911:40:35- [ ] This merge request includes changes to Vue files that have both CE and EE versions.
19011:40:35- [ ] **[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html)**:
19111:40:35If this merge request needs a changelog entry, add the `Changelog` trailer to the commit message you want to add to the changelog.
19211:40:35If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.
19311:40:35Markdown:
19411:40:35## Vue `<template>` in CE and EE
19511:40:35Some Vue files in CE have a counterpart in EE.
19611:40:35(For example, `path/to/file.vue` and `ee/path/to/file.vue`.)
19711:40:35When run in the context of CE, the `<template>` of the CE Vue file is used.
19811:40:35When run in the context of EE, the `<template>` of the EE Vue file is used.
19911:40:35It's easy to accidentally make a change to a CE `<template>` that _should_
20011:40:35appear in both CE and EE without making the change in both places.
20111:40:35When this happens, the change only takes effect in CE.
20211:40:35The following Vue files were changed as part of this merge request that
20311:40:35include both a CE and EE version of the file:
20411:40:35* `app/assets/javascripts/projects/settings/branch_rules/components/view/index.vue`
20511:40:35If you made a change to the `<template>` of any of these Vue files that
20611:40:35should be visible in both CE and EE, please ensure you have made your
20711:40:35change to both versions of the file.
20811:40:35### A better alternative
20911:40:35An even _better_ alternative is to refactor this component to only use
21011:40:35a single template for both CE and EE. More info on this approach here:
21111:40:35https://docs.gitlab.com/ee/development/ee_features.html#template-tag
21211:40:35## Reviewer roulette
21311:40:35| Category | Reviewer | Maintainer |
21411:40:35| -------- | -------- | ---------- |
21511:40:35| ~"frontend" | `@aalakkad` [![profile link](https://gitlab-org.gitlab.io/gitlab-roulette/status-png/_user.png){width=12}](https://gitlab.com/aalakkad) ![current availability](https://gitlab-org.gitlab.io/gitlab-roulette/status-png/aalakkad.png){width=12} (UTC+3, 2 hours ahead of author) | `@dmishunov` [![profile link](https://gitlab-org.gitlab.io/gitlab-roulette/status-png/_user.png){width=12}](https://gitlab.com/dmishunov) ![current availability](https://gitlab-org.gitlab.io/gitlab-roulette/status-png/dmishunov.png){width=12} (UTC+1, same timezone as author) |
21611:40:35Please refer to [documentation page](https://docs.gitlab.com/ee/development/code_review.html#reviewer-roulette)
21711:40:35for guidance on how you can benefit from the Reviewer Roulette, or use the
21811:40:35[GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/)
21911:40:35to find other available reviewers.
22011:40:35**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/8674943039) that generated this comment.**
221 11:40:35 Saving cache for successful job 00:01
22211:40:36Not uploading cache ruby-gems-debian-bookworm-ruby-3.2.5-gemfile-Gemfile-21 due to policy
22311:40:36Not uploading cache node-modules-debian-bookworm-test-21 due to policy
224 11:40:36 Cleaning up project directory and file based variables 00:00
22511:40:45Job succeeded