danger-review
Passed Started
by
@mbobin
Marius Bobin
211:51:50 on green-3.shared-gitlab-org.runners-manager.gitlab.com/default EuhiQzPR, system ID: s_360bc9544527611:51:50Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.2.5-golang-1.22-rust-1.73-node-20.12-postgresql-14:rubygems-3.4-git-2.45-lfs-2.9-chrome-123-yarn-1.22-graphicsmagick-1.3.36 ...811:51:54Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.2.5-golang-1.22-rust-1.73-node-20.12-postgresql-14:rubygems-3.4-git-2.45-lfs-2.9-chrome-123-yarn-1.22-graphicsmagick-1.3.36 ...911:52:58Using docker image sha256:72c427a29f80c5ff14e5cd83601d7507c7de71ce18b2ccd8a04667fdd0d6aba0 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.2.5-golang-1.22-rust-1.73-node-20.12-postgresql-14:rubygems-3.4-git-2.45-lfs-2.9-chrome-123-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.2.5-golang-1.22-rust-1.73-node-20.12-postgresql-14@sha256:ba1a3d49eae4bc906535413ec79e7efdb3497247de3e53f23a928039672611a1 ...1111:52:58Running on runner-euhiqzpr-project-278964-concurrent-0 via runner-euhiqzpr-shared-gitlab-org-1725537069-6c1fe776...2911:53:32Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-debian-bookworm-ruby-3.2.5-gemfile-Gemfile-18 3211:53:44Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-debian-bookworm-test-18 3511:54:09Using docker image sha256:72c427a29f80c5ff14e5cd83601d7507c7de71ce18b2ccd8a04667fdd0d6aba0 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.2.5-golang-1.22-rust-1.73-node-20.12-postgresql-14:rubygems-3.4-git-2.45-lfs-2.9-chrome-123-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.2.5-golang-1.22-rust-1.73-node-20.12-postgresql-14@sha256:ba1a3d49eae4bc906535413ec79e7efdb3497247de3e53f23a928039672611a1 ...9611:54:37$ if [[ "$CI_MERGE_REQUEST_PROJECT_URL" != "$CI_MERGE_REQUEST_SOURCE_PROJECT_URL" || -z "${GITLAB_API_TOKEN}" ]]; then # collapsed multi-line command12611:54:44Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation12811:54:44Importing rule bulk_database_actions at /builds/gitlab-org/gitlab/danger/bulk_database_actions12911:54:44Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates13011:54:44Importing rule change_column_default at /builds/gitlab-org/gitlab/danger/change_column_default13111:54:44Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.8.0/lib/danger/rules/changelog13211:54:44Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.8.0/lib/danger/rules/changes_size13711:54:44Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.8.0/lib/danger/rules/commit_messages13811:55:09Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.8.0/lib/danger/rules/commits_counter14511:55:09Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies15011:55:09Importing rule gitlab_schema_validation at /builds/gitlab-org/gitlab/danger/gitlab_schema_validation15111:55:09Importing rule ignored_model_columns at /builds/gitlab-org/gitlab/danger/ignored_model_columns15211:55:09Importing rule master_pipeline_status at /builds/gitlab-org/gitlab/danger/master_pipeline_status15311:55:09Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.8.0/lib/danger/rules/metadata16711:55:09Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels16911:55:09Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch17211:55:09Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.8.0/lib/danger/rules/type_label17411:55:09Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation17511:55:09Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.8.0/lib/danger/rules/z_add_labels17611:55:09Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.8.0/lib/danger/rules/z_retry_link17911:55:09- [ ] This MR changes code in `ee/`, but its Changelog commit is missing the [`EE: true` trailer](https://docs.gitlab.com/ee/development/changelog.html#gitlab-enterprise-changes). Consider adding it to your Changelog commits.18011:55:09- [ ] 2626861f48bb23886fb2262804d0cc264f67095b: The commit subject must start with a capital letter. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).18611:55:09For guidance on when to use a feature flag, please see the [documentation](https://about.gitlab.com/handbook/product-development-flow/feature-flag-lifecycle/#when-to-use-feature-flags).18711:55:09- [ ] The [master pipeline status page](https://gitlab.com/gitlab-org/quality/engineering-productivity/master-broken-incidents/-/raw/master-pipeline-status/canonical-gitlab-master-pipeline-status.json) reported failures in18811:55:09* [rspec-ee system pg14 single-db-ci-connection 5/16](https://gitlab.com/gitlab-org/gitlab/-/jobs/7738003359)18911:55:09* [rspec unit pg14 single-db-ci-connection 10/44](https://gitlab.com/gitlab-org/gitlab/-/jobs/7738002360)19011:55:09If these jobs fail in your merge request with the same errors, then they are not caused by your changes.19111:55:09Please check for any on-going incidents in the [incident issue tracker](https://gitlab.com/gitlab-org/quality/engineering-productivity/master-broken-incidents/-/issues) or in the `#master-broken` Slack channel.19511:55:09Please follow the [code quality guidelines about new model validations](https://docs.gitlab.com/ee/development/code_review.html#quality) when adding a new20111:55:09| ~"backend" | `@rcobb` [{width=12}](https://gitlab.com/rcobb) {width=12} (UTC-7, 9 hours behind author) | `@kerrizor` [{width=12}](https://gitlab.com/kerrizor) {width=12} (UTC-7, 9 hours behind author) |20211:55:09| ~"database" | `@tianwenchen` [{width=12}](https://gitlab.com/tianwenchen) {width=12} (UTC+10, 8 hours ahead of author) | `@ahegyi` [{width=12}](https://gitlab.com/ahegyi) {width=12} (UTC+2, same timezone as author) |20311:55:09| ~"Verify" | Reviewer review is optional for ~"Verify" | `@pedropombeiro` [{width=12}](https://gitlab.com/pedropombeiro) {width=12} (UTC+2, same timezone as author) |20411:55:09Please refer to [documentation page](https://docs.gitlab.com/ee/development/code_review.html#reviewer-roulette)20811:55:09**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/7753398194) that generated this comment.**21011:55:10Not uploading cache ruby-gems-debian-bookworm-ruby-3.2.5-gemfile-Gemfile-18 due to policy 
