danger-review
Passed Started
by
@krasio
Krasimir Angelov
1Running with gitlab-runner 17.0.0~pre.88.g761ae5dd (761ae5dd)2 on green-5.private.runners-manager.gitlab.com/gitlab.com/gitlab-org Zi_8oswQ, system ID: s_8a4f217c24b63 feature flags: FF_NETWORK_PER_BUILD:true4Resolving secrets6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.2.patched-golang-1.21-rust-1.73-node-20.12-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-123-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.2.patched-golang-1.21-rust-1.73-node-20.12-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-123-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:d10d211334d3c94a5e626cf961467431b7d3f3bd8b6109e5caf9357421c0117b for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.2.patched-golang-1.21-rust-1.73-node-20.12-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-123-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.2.patched-golang-1.21-rust-1.73-node-20.12-postgresql-14@sha256:3c4cd9a237deb59350b4836552151ba2aae96247034074c8f0c2ccaff4558cab ...11Running on runner-zi8oswq-project-278964-concurrent-0 via runner-zi8oswq-private-1717022337-ba3f3277...13Fetching changes with git depth set to 20...14Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/15Created fresh repository.16remote: Enumerating objects: 207806, done. 17remote: Counting objects: 100% (207806/207806), done. 18remote: Compressing objects: 100% (129421/129421), done. 19remote: Total 207806 (delta 111136), reused 141664 (delta 70806), pack-reused 0 (from 0) 20Receiving objects: 100% (207806/207806), 149.46 MiB | 28.81 MiB/s, done.21Resolving deltas: 100% (111136/111136), done.23 * [new ref] refs/pipelines/1311053906 -> refs/pipelines/131105390624Checking out f4f54d50 as detached HEAD (ref is refs/merge-requests/152249/merge)...25Skipping Git submodules setup26$ git remote set-url origin "${CI_REPOSITORY_URL}"28Checking cache for ruby-gems-debian-bookworm-ruby-3.2-17...29cache.zip is up to date 30Successfully extracted cache31Checking cache for node-modules-debian-bookworm-test-17...32Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-debian-bookworm-test-17 33Successfully extracted cache35Using docker image sha256:d10d211334d3c94a5e626cf961467431b7d3f3bd8b6109e5caf9357421c0117b for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.2.patched-golang-1.21-rust-1.73-node-20.12-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-123-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.2.patched-golang-1.21-rust-1.73-node-20.12-postgresql-14@sha256:3c4cd9a237deb59350b4836552151ba2aae96247034074c8f0c2ccaff4558cab ...36$ source scripts/utils.sh37$ bundle_install_script740$ yarn_install_script763$ if [[ "$CI_MERGE_REQUEST_PROJECT_URL" != "$CI_MERGE_REQUEST_SOURCE_PROJECT_URL" || -z "${GITLAB_API_TOKEN}" ]]; then # collapsed multi-line command765 * branch 20381-add-trigram-indexes-on-email-column -> FETCH_HEAD766$ if [ -z "${GITLAB_API_TOKEN}" ]; then # collapsed multi-line command767Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/analytics_instrumentation.rb768Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/bulk_database_actions.rb769Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/change_column_default.rb770Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/ci_templates.rb771Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/clickhouse.rb772Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb773Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb774Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database.rb775Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb776Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb777Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/experiments.rb778Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb779Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/gitlab_schema_validation.rb780Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/ignored_model_columns.rb781Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/master_pipeline_status.rb782Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/model_validations.rb783Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb784Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb785Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/required_stops.rb786Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/rubocop.rb787Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/saas_feature.rb788Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb789Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb790Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb791Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb792Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/todos.rb793Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation794Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture795Importing rule bulk_database_actions at /builds/gitlab-org/gitlab/danger/bulk_database_actions796Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates797Importing rule change_column_default at /builds/gitlab-org/gitlab/danger/change_column_default798Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/changelog799Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/changes_size800Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config801Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables802Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates803Importing rule clickhouse at /builds/gitlab-org/gitlab/danger/clickhouse804Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/commit_messages805Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/commits_counter806Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files807Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success808Importing rule database at /builds/gitlab-org/gitlab/danger/database809Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam810Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation811Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies812Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint813Importing rule experiments at /builds/gitlab-org/gitlab/danger/experiments814Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag815Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly816Importing rule gitlab_schema_validation at /builds/gitlab-org/gitlab/danger/gitlab_schema_validation817Importing rule ignored_model_columns at /builds/gitlab-org/gitlab/danger/ignored_model_columns818Importing rule master_pipeline_status at /builds/gitlab-org/gitlab/danger/master_pipeline_status819Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/metadata820Importing rule model_validations at /builds/gitlab-org/gitlab/danger/model_validations821Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion822Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline823Importing rule pipeline_config at /builds/gitlab-org/gitlab/danger/pipeline_config824Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier825Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector826Importing rule required_stops at /builds/gitlab-org/gitlab/danger/required_stops827Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette828Importing rule rubocop at /builds/gitlab-org/gitlab/danger/rubocop829Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems830Importing rule saas_feature at /builds/gitlab-org/gitlab/danger/saas_feature831Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args832Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues833Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels834Importing rule specs at /builds/gitlab-org/gitlab/danger/specs835Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch836Importing rule tailwindcss at /builds/gitlab-org/gitlab/danger/tailwindcss837Rebuilding...838Done in 5636ms.839Importing rule todos at /builds/gitlab-org/gitlab/danger/todos840Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/type_label841Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css842Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation843Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/z_add_labels844Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/z_retry_link845Results:846Warnings:847- [ ] ⌛ **Migration Timestamp Out of Date**848The following migrations have timestamps that are over three weeks old:849* db/post_migrate/20240507161859_add_trigram_index_on_public_email_for_users.rb850* db/post_migrate/20240507162033_add_trigram_index_on_email_for_users.rb851* db/post_migrate/20240507162310_add_trigram_index_on_email_for_emails.rb852Please double check the timestamps and update them if possible. [Why does this matter?](https://docs.gitlab.com/ee/development/migration_style_guide.html#migration-timestamp-age)853- [ ] You've made some app changes, but didn't add any tests.854That's OK as long as you're refactoring existing code,855but please consider adding any of the ~"maintenance::pipelines", ~"maintenance::refactor", ~"maintenance::workflow", ~"documentation", ~"QA" labels.856Messages:857- [ ] This merge request adds or changes files that require a review from the [Database team](https://gitlab.com/groups/gl-database/-/group_members).858Markdown:859This merge request requires a database review. To make sure these860changes are reviewed, take the following steps:8611. Ensure the merge request has ~database and ~"database::review pending" labels.862 If the merge request modifies database files, Danger will do this for you.8631. Prepare your MR for database review according to the864 [docs](https://docs.gitlab.com/ee/development/database_review.html#how-to-prepare-the-merge-request-for-a-database-review).8651. Assign and mention the database reviewer suggested by Reviewer Roulette.866The following files require a review from the Database team:867* `db/post_migrate/20240507161859_add_trigram_index_on_public_email_for_users.rb`868* `db/post_migrate/20240507162033_add_trigram_index_on_email_for_users.rb`869* `db/post_migrate/20240507162310_add_trigram_index_on_email_for_emails.rb`870* `db/schema_migrations/20240507161859`871* `db/schema_migrations/20240507162033`872* `db/schema_migrations/20240507162310`873* `db/docs/emails.yml`874* `db/docs/users.yml`875* `db/structure.sql`876## Reviewer roulette877| Category | Reviewer | Maintainer |878| -------- | -------- | ---------- |879| ~"database" | `@ck3g` [{width=12}](https://gitlab.com/ck3g) {width=12} (UTC+2) | `@tigerwnz` [{width=12}](https://gitlab.com/tigerwnz) {width=12} (UTC+10) |880**Please check reviewer's status!**881- {width=12} Reviewer is available!882- {width=12} Reviewer is unavailable!883Please refer to [documentation page](https://docs.gitlab.com/ee/development/code_review.html#reviewer-roulette)884for guidance on how you can benefit from the Reviewer Roulette, or use the885[GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/)886to find other available reviewers.887**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/6975008334) that generated this comment.**889Not uploading cache ruby-gems-debian-bookworm-ruby-3.2-17 due to policy890Not uploading cache node-modules-debian-bookworm-test-17 due to policy892Job succeeded 
