danger-review
Passed Started
by
@dat.tang.gitlab
Dat Tang
1Running with gitlab-runner 16.11.0~pre.21.gaa21be2d (aa21be2d)2 on blue-6.private.runners-manager.gitlab.com/gitlab.com/gitlab-org mKJTFBei, system ID: s_90a66139ec063 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:0bb54a9ccc2367eb1dccba56bee4c67bdeaad5b6b769e1f666e1b83a48f7c6ef for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14@sha256:f209c4512e7f88808cf770194d13f020455d802006031159fb48a74be4fc62b2 ...11Running on runner-mkjtfbei-project-278964-concurrent-0 via runner-mkjtfbei-private-1713532384-2ef37d7b...13Fetching changes with git depth set to 20...14Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/15Created fresh repository.16remote: Enumerating objects: 84059, done. 17remote: Counting objects: 100% (84059/84059), done. 18remote: Compressing objects: 100% (71769/71769), done. 19remote: Total 84059 (delta 12034), reused 51013 (delta 8241), pack-reused 0 20Receiving objects: 100% (84059/84059), 105.19 MiB | 23.81 MiB/s, done.21Resolving deltas: 100% (12034/12034), done.23 * [new ref] refs/pipelines/1258950368 -> refs/pipelines/125895036824remote: Enumerating objects: 5, done. 25remote: Counting objects: 100% (5/5), done. 26remote: Compressing objects: 100% (5/5), done. 27remote: Total 5 (delta 0), reused 5 (delta 0), pack-reused 0 28 * [new tag] v16.9.1-ee -> v16.9.1-ee29 * [new tag] v16.9.2-ee -> v16.9.2-ee30 * [new tag] v16.9.3-ee -> v16.9.3-ee31 * [new tag] v16.9.4-ee -> v16.9.4-ee32 * [new tag] v16.9.5-ee -> v16.9.5-ee33Checking out 11c99d04 as detached HEAD (ref is refs/merge-requests/150030/merge)...34Skipping Git submodules setup35$ git remote set-url origin "${CI_REPOSITORY_URL}"37Checking cache for ruby-gems-debian-bookworm-ruby-3.1-17...38Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-debian-bookworm-ruby-3.1-17 39Successfully extracted cache40Checking cache for node-modules-bookworm-test-17...41WARNING: file does not exist 42Failed to extract cache44Using docker image sha256:0bb54a9ccc2367eb1dccba56bee4c67bdeaad5b6b769e1f666e1b83a48f7c6ef for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14@sha256:f209c4512e7f88808cf770194d13f020455d802006031159fb48a74be4fc62b2 ...45$ source scripts/utils.sh46$ bundle_install_script "--with danger"857$ yarn_install_script933$ if [[ "$CI_MERGE_REQUEST_PROJECT_URL" != "$CI_MERGE_REQUEST_SOURCE_PROJECT_URL" || -z "${DANGER_GITLAB_API_TOKEN}" ]]; then # collapsed multi-line command934$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command935Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/analytics_instrumentation.rb936Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/bulk_database_actions.rb937Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/change_column_default.rb938Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/clickhouse.rb939Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb940Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb941Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database.rb942Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb943Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb944Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/experiments.rb945Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb946Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/gitlab_schema_validation.rb947Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/ignored_model_columns.rb948Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/model_validations.rb949Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb950Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb951Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/required_stops.rb952Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/rubocop.rb953Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/saas_feature.rb954Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb955Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb956Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb957Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb958Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/todos.rb959Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation960Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture961Importing rule bulk_database_actions at /builds/gitlab-org/gitlab/danger/bulk_database_actions962Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates963Importing rule change_column_default at /builds/gitlab-org/gitlab/danger/change_column_default964Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/changelog965/builds/gitlab-org/gitlab/danger/saas_feature/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::SEE_DOC966/builds/gitlab-org/gitlab/danger/feature_flag/Dangerfile:3: warning: previous definition of SEE_DOC was here967/builds/gitlab-org/gitlab/danger/saas_feature/Dangerfile:5: warning: already initialized constant Danger::Dangerfile::SUGGEST_MR_COMMENT968/builds/gitlab-org/gitlab/danger/feature_flag/Dangerfile:9: warning: previous definition of SUGGEST_MR_COMMENT was here969WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.970WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.971Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/changes_size972Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config973Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables974Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates975Importing rule clickhouse at /builds/gitlab-org/gitlab/danger/clickhouse976Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/commit_messages977Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/commits_counter978Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files979Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success980Importing rule database at /builds/gitlab-org/gitlab/danger/database981Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam982Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation983Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies984Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint985Importing rule experiments at /builds/gitlab-org/gitlab/danger/experiments986Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag987Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly988Importing rule gitlab_schema_validation at /builds/gitlab-org/gitlab/danger/gitlab_schema_validation989Importing rule ignored_model_columns at /builds/gitlab-org/gitlab/danger/ignored_model_columns990Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/metadata991Importing rule model_validations at /builds/gitlab-org/gitlab/danger/model_validations992Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion993Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline994Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier995Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector996Importing rule required_stops at /builds/gitlab-org/gitlab/danger/required_stops997Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette998Importing rule rubocop at /builds/gitlab-org/gitlab/danger/rubocop999Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems1000Importing rule saas_feature at /builds/gitlab-org/gitlab/danger/saas_feature1001Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args1002Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues1003Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels1004Importing rule specs at /builds/gitlab-org/gitlab/danger/specs1005Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch1006Importing rule todos at /builds/gitlab-org/gitlab/danger/todos1007Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/type_label1008Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css1009Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation1010Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/z_add_labels1011Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/z_retry_link1012Results:1013Warnings:1014- [ ] This merge request does not refer to an existing milestone.1015- [ ] Backporting to older releases requires an [exception request process](https://docs.gitlab.com/ee/policy/maintenance.html#backporting-to-older-releases)1016- [ ] **The `e2e:package-and-test-ee` job needs to succeed or have approval from a Software Engineer in Test.**1017Read the "QA e2e:package-and-test-ee" section for more details.1018Markdown:1019## Pipeline Changes1020This merge request contains changes to the pipeline configuration for the GitLab project.1021Please consider the effect of the changes in this merge request on the following:1022- Effects on different [pipeline types](https://docs.gitlab.com/ee/development/pipelines/index.html#pipelines-types-for-merge-requests)1023- Effects on non-canonical projects:1024 - `gitlab-foss`1025 - `security`1026 - `dev`1027 - personal forks1028- Effects on [pipeline performance](https://about.gitlab.com/handbook/engineering/quality/performance-indicators/#average-merge-request-pipeline-duration-for-gitlab)1029Please consider communicating these changes to the broader team following the [communication guideline for pipeline changes](https://about.gitlab.com/handbook/engineering/quality/engineering-productivity/#pipeline-changes)1030## QA `e2e:package-and-test-ee`1031**@dat.tang.gitlab, the `package-and-test` job must complete before merging this merge request.***1032If there are failures on the `package-and-test` pipeline, ping your team's associated Software Engineer in Test (SET) to confirm1033the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the `#test-platform` Slack channel.1034**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/6669091054) that generated this comment.**1036Not uploading cache ruby-gems-debian-bookworm-ruby-3.1-17 due to policy1037Not uploading cache node-modules-bookworm-test-17 due to policy1039Job succeeded