danger-review
Passed Started
by
@nickleonard
Nick Leonard
1Running with gitlab-runner 16.11.0~pre.21.gaa21be2d (aa21be2d)2 on blue-6.shared-gitlab-org.runners-manager.gitlab.com/default SvV6b8rzM, system ID: s_5d6e1be0ca3a3 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_IMPROVED_URL_MASKING:true6Dialing instance https://www.googleapis.com/compute/v1/projects/gitlab-r-saas-l-m-amd64-org-6/zones/us-east1-d/instances/blue-default-7b4bf5389c7362e7...7Instance https://www.googleapis.com/compute/v1/projects/gitlab-r-saas-l-m-amd64-org-6/zones/us-east1-d/instances/blue-default-7b4bf5389c7362e7 connected8Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 ...9Authenticating with credentials from job payload (GitLab Registry)10Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 ...11Using docker image sha256:68c28b617bffe2a886c7cc55876bd2ffe9dc0450f41e86898c5245c6247e92ee for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14@sha256:80a1e9bcb7ece8797ca1d1e1cad6ca2664ece80bda1d4d2575b247f5c91af96d ...13Running on runner-svv6b8rzm-project-278964-concurrent-88 via runners-manager-shared-gitlab-org-blue-6...15Fetching changes with git depth set to 20...16Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/17Created fresh repository.18remote: Enumerating objects: 152504, done. 19remote: Counting objects: 100% (152504/152504), done. 20remote: Compressing objects: 100% (106448/106448), done. 21remote: Total 152504 (delta 66053), reused 99696 (delta 39850), pack-reused 0 22Receiving objects: 100% (152504/152504), 130.84 MiB | 27.32 MiB/s, done.23Resolving deltas: 100% (66053/66053), done.25 * [new ref] refs/pipelines/1248288917 -> refs/pipelines/124828891726Checking out 6ba0dc82 as detached HEAD (ref is refs/merge-requests/144819/merge)...27Skipping Git submodules setup28$ git remote set-url origin "${CI_REPOSITORY_URL}"30Checking cache for ruby-gems-debian-bookworm-ruby-3.1-17...31Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-debian-bookworm-ruby-3.1-17 32Successfully extracted cache33Checking cache for node-modules-debian-bookworm-test-17...34Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-debian-bookworm-test-17 35Successfully extracted cache37Using docker image sha256:68c28b617bffe2a886c7cc55876bd2ffe9dc0450f41e86898c5245c6247e92ee for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14@sha256:80a1e9bcb7ece8797ca1d1e1cad6ca2664ece80bda1d4d2575b247f5c91af96d ...38$ source scripts/utils.sh39$ bundle_install_script "--with danger"717$ yarn_install_script772$ if [[ "$CI_MERGE_REQUEST_PROJECT_URL" != "$CI_MERGE_REQUEST_SOURCE_PROJECT_URL" || -z "${DANGER_GITLAB_API_TOKEN}" ]]; then # collapsed multi-line command773$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command774Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/analytics_instrumentation.rb775Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/bulk_database_actions.rb776Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/change_column_default.rb777Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/ci_templates.rb778Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/clickhouse.rb779Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb780Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb781Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database.rb782Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb783Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb784Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/experiments.rb785Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb786Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/gitlab_schema_validation.rb787Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/ignored_model_columns.rb788Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/master_pipeline_status.rb789Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/model_validations.rb790Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb791Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb792Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/required_stops.rb793Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/rubocop.rb794Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/saas_feature.rb795Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb796Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb797Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb798Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb799Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/todos.rb800Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation801Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture802Importing rule bulk_database_actions at /builds/gitlab-org/gitlab/danger/bulk_database_actions803Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates804Importing rule change_column_default at /builds/gitlab-org/gitlab/danger/change_column_default805Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/changelog806Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/changes_size807Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config808Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables809Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates810Importing rule clickhouse at /builds/gitlab-org/gitlab/danger/clickhouse811Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/commit_messages812Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/commits_counter813Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files814Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success815Importing rule database at /builds/gitlab-org/gitlab/danger/database816Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam817Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation818Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies819Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint820Importing rule experiments at /builds/gitlab-org/gitlab/danger/experiments821Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag822Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly823Importing rule gitlab_schema_validation at /builds/gitlab-org/gitlab/danger/gitlab_schema_validation824Importing rule ignored_model_columns at /builds/gitlab-org/gitlab/danger/ignored_model_columns825Importing rule master_pipeline_status at /builds/gitlab-org/gitlab/danger/master_pipeline_status826Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/metadata827Importing rule model_validations at /builds/gitlab-org/gitlab/danger/model_validations828Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion829Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline830Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier831Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector832Importing rule required_stops at /builds/gitlab-org/gitlab/danger/required_stops833Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette834Importing rule rubocop at /builds/gitlab-org/gitlab/danger/rubocop835Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems836Importing rule saas_feature at /builds/gitlab-org/gitlab/danger/saas_feature837Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args838Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues839Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels840Importing rule specs at /builds/gitlab-org/gitlab/danger/specs841Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch842Importing rule todos at /builds/gitlab-org/gitlab/danger/todos843Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/type_label844Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css845Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation846Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/z_add_labels847Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/z_retry_link848Results:849Warnings:850- [ ] This MR has a Changelog commit for EE, but no code changes in `ee/`. Consider removing the `EE: true` trailer from your commits.851- [ ] fae8e1aeb75968f51c4bbdd84783fa56b746217b: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).852- [ ] ~"feature::addition" and ~"feature::enhancement" merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the [Technical Writer counterpart](https://handbook.gitlab.com/handbook/product/ux/technical-writing/#assignments).853For more information, see:854- The Handbook page on [merge request types](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification).855- The [definition of done](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#definition-of-done) documentation.856- [ ] This merge request contains lines with testid selectors. Please ensure `e2e:package-and-test` job is run.857Markdown:858### `testid` selectors859The following changed lines in this MR contain `testid` selectors:860#### `app/assets/javascripts/work_items/components/work_item_description_rendered.vue`861```shell862- data-testid="work-item-description"863+ data-testid="work-item-description"864+ data-testid="show-all-btn"865```866If the `e2e:package-and-test` job in the `qa` stage has run automatically, please ensure the tests are passing.867If the job has not run, please start the `manual:e2e-test-pipeline-generate` job in the `prepare` stage and ensure the tests in `follow-up:e2e:package-and-test-ee` pipeline are passing.868For the list of known failures please refer to [the latest pipeline triage issue](https://gitlab.com/gitlab-org/quality/pipeline-triage/-/issues).869If your changes are under a feature flag, please check our [Testing with feature flags](https://docs.gitlab.com/ee/development/testing_guide/end_to_end/feature_flags.html#automatic-test-execution-when-a-feature-flag-definition-changes) documentation for instructions.870## Reviewer roulette871| Category | Reviewer | Maintainer |872| -------- | -------- | ---------- |873| ~"frontend" | `@andr3` [{width=12}](https://gitlab.com/andr3) {width=12} (UTC+1, 6 hours ahead of author) | `@vitallium` [{width=12}](https://gitlab.com/vitallium) {width=12} (UTC+2, 7 hours ahead of author) |874**Please check reviewer's status!**875-  Reviewer is available!876-  Reviewer is unavailable!877Please refer to [documentation page](https://docs.gitlab.com/ee/development/code_review.html#reviewer-roulette)878for guidance on how you can benefit from the Reviewer Roulette, or use the879[GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/)880to find other available reviewers.881**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/6597628127) that generated this comment.**883Not uploading cache ruby-gems-debian-bookworm-ruby-3.1-17 due to policy884Not uploading cache node-modules-debian-bookworm-test-17 due to policy886Job succeeded 
