Skip to content
Snippets Groups Projects

bundle-size-review

Passed Started by
Nick Leonard
@nickleonard
1Running with gitlab-runner 16.11.0~pre.21.gaa21be2d (aa21be2d)
2 on blue-1.shared-gitlab-org.runners-manager.gitlab.com/default KzYhZxBv, system ID: s_e6befde69e26
3 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_IMPROVED_URL_MASKING:true
4 Resolving secrets 00:00
5 Preparing the "docker+machine" executor 00:21
6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images:danger ...
7Authenticating with credentials from job payload (GitLab Registry)
8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images:danger ...
9Using docker image sha256:650031dad1a45546f5530a245af8d3c4144cec868d0da0cbb6478f69c0c849ad for registry.gitlab.com/gitlab-org/gitlab-build-images:danger with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:e1210444273a7904dead65824233ccf9935ec95341f21a18c5ae254b9e0decf0 ...
10 Preparing environment 00:05
11Running on runner-kzyhzxbv-project-278964-concurrent-0 via runner-kzyhzxbv-shared-gitlab-org-1712776898-2bc88212...
12 Getting source from Git repository 00:28
13Fetching changes with git depth set to 20...
14Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/
15Created fresh repository.
16remote: Enumerating objects: 152504, done.
17remote: Counting objects: 100% (152504/152504), done.
18remote: Compressing objects: 100% (106448/106448), done.
19remote: Total 152504 (delta 66053), reused 99696 (delta 39850), pack-reused 0
20Receiving objects: 100% (152504/152504), 130.84 MiB | 29.67 MiB/s, done.
21Resolving deltas: 100% (66053/66053), done.
22From https://us-east1-c.ci-gateway.int.gprd.gitlab.net:8989/gitlab-org/gitlab
23 * [new ref] refs/pipelines/1248288917 -> refs/pipelines/1248288917
24Checking out 6ba0dc82 as detached HEAD (ref is refs/merge-requests/144819/merge)...
25Skipping Git submodules setup
26$ git remote set-url origin "${CI_REPOSITORY_URL}"
27 Restoring cache 00:32
28Checking cache for ruby-gems-debian-bookworm-ruby-3.1-17...
29cache.zip is up to date
30Successfully extracted cache
31Checking cache for node-modules-debian-bookworm-test-17...
32Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-debian-bookworm-test-17
33Successfully extracted cache
34Checking cache for assets-tmp-debian-bookworm-ruby-3.1-node-test-v1-17...
35Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/assets-tmp-debian-bookworm-ruby-3.1-node-test-v1-17
36Successfully extracted cache
37 Executing "step_script" stage of the job script 16:48
38Using docker image sha256:650031dad1a45546f5530a245af8d3c4144cec868d0da0cbb6478f69c0c849ad for registry.gitlab.com/gitlab-org/gitlab-build-images:danger with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:e1210444273a7904dead65824233ccf9935ec95341f21a18c5ae254b9e0decf0 ...
39$ echo $FOSS_ONLY
40$ [ "$FOSS_ONLY" = "1" ] && rm -rf ee/ qa/spec/ee/ qa/qa/specs/features/ee/ qa/qa/ee/ qa/qa/ee.rb
41$ export GOPATH=$CI_PROJECT_DIR/.go
42$ mkdir -p $GOPATH
43$ source scripts/utils.sh
44$ yarn_install_script
45 Installing Yarn packages 00:26
99$ scripts/bundle_size_review
100In a merge request, setting COMMIT_SHA to $CI_MERGE_REQUEST_SOURCE_BRANCH_SHA
101$ yarn run webpack-prod > bundle-size-review/webpack-output.log
102`isModuleDeclaration` has been deprecated, please migrate to `isImportOrExportDeclaration`
103 at isModuleDeclaration (/builds/gitlab-org/gitlab/node_modules/@babel/types/lib/validators/generated/index.js:2748:35)
104 at PluginPass.Program (/builds/gitlab-org/gitlab/node_modules/babel-plugin-lodash/lib/index.js:102:44)
105`isModuleDeclaration` has been deprecated, please migrate to `isImportOrExportDeclaration`
106 at isModuleDeclaration (/builds/gitlab-org/gitlab/node_modules/@babel/types/lib/validators/generated/index.js:2748:35)
107 at PluginPass.Program (/builds/gitlab-org/gitlab/node_modules/babel-plugin-lodash/lib/index.js:102:44)
108[BABEL] Note: The code generator has deoptimised the styling of /builds/gitlab-org/gitlab/node_modules/swagger-ui-dist/swagger-ui-bundle.js as it exceeds the max of 500KB.
109Warning: fragment with name MilestoneFragment already exists.
110graphql-tag enforces all fragment names across your application to be unique; read more about
111this in the docs: http://dev.apollodata.com/core/fragments.html#unique-names
112Warning: fragment with name MilestoneFragment already exists.
113graphql-tag enforces all fragment names across your application to be unique; read more about
114this in the docs: http://dev.apollodata.com/core/fragments.html#unique-names
115Warning: fragment with name Issue already exists.
116graphql-tag enforces all fragment names across your application to be unique; read more about
117this in the docs: http://dev.apollodata.com/core/fragments.html#unique-names
118Warning: fragment with name AuditEventStreamingHeaderFragment already exists.
119graphql-tag enforces all fragment names across your application to be unique; read more about
120this in the docs: http://dev.apollodata.com/core/fragments.html#unique-names
121Warning: fragment with name WorkItemWidgets already exists.
122graphql-tag enforces all fragment names across your application to be unique; read more about
123this in the docs: http://dev.apollodata.com/core/fragments.html#unique-names
124Warning: fragment with name BoardListFragment already exists.
125graphql-tag enforces all fragment names across your application to be unique; read more about
126this in the docs: http://dev.apollodata.com/core/fragments.html#unique-names
127Warning: fragment with name BaseEpic already exists.
128graphql-tag enforces all fragment names across your application to be unique; read more about
129this in the docs: http://dev.apollodata.com/core/fragments.html#unique-names
130Warning: fragment with name Label already exists.
131graphql-tag enforces all fragment names across your application to be unique; read more about
132this in the docs: http://dev.apollodata.com/core/fragments.html#unique-names
133Warning: fragment with name IssueFragment already exists.
134graphql-tag enforces all fragment names across your application to be unique; read more about
135this in the docs: http://dev.apollodata.com/core/fragments.html#unique-names
136Warning: fragment with name Project already exists.
137graphql-tag enforces all fragment names across your application to be unique; read more about
138this in the docs: http://dev.apollodata.com/core/fragments.html#unique-names
139Warning: fragment with name Group already exists.
140graphql-tag enforces all fragment names across your application to be unique; read more about
141this in the docs: http://dev.apollodata.com/core/fragments.html#unique-names
142Warning: fragment with name OrganizationFragment already exists.
143graphql-tag enforces all fragment names across your application to be unique; read more about
144this in the docs: http://dev.apollodata.com/core/fragments.html#unique-names
145Warning: fragment with name ContactFragment already exists.
146graphql-tag enforces all fragment names across your application to be unique; read more about
147this in the docs: http://dev.apollodata.com/core/fragments.html#unique-names
148==> 'yarn run webpack-prod > bundle-size-review/webpack-output.log' succeeded in 934 seconds.
149yarn global v1.22.17
150[1/4] Resolving packages...
151warning https://gitlab.com/gitlab-org/frontend/playground/webpack-memory-metrics.git > axios@0.19.2: Critical security vulnerability fixed in v0.21.1. For more information, see https://github.com/axios/axios/pull/3410
152[2/4] Fetching packages...
153[3/4] Linking dependencies...
154[4/4] Building fresh packages...
155success Installed "webpack-memory-metrics@1.0.0" with binaries:
156 - webpack-compare-reports
157 - webpack-entry-point-analyser
158Done in 10.37s.
159$ webpack-entry-point-analyser --from-file ./webpack-report/stats.json --json ./bundle-size-review/analysis.json --sha f48e0af27832fa6e2ee6f61695a1ebc5ba261e93
160Start reading gargantuan JSON: /builds/gitlab-org/gitlab/webpack-report/stats.json
161Found key errors
162Found key warnings
163Found key version
164Found key hash
165Found key time
166Found key builtAt
167Found key publicPath
168Found key outputPath
169Found key assetsByChunkName
170Found key assets
171Found key filteredAssets
172Found key entrypoints
173Found key namedChunkGroups
174Found key chunks
175Found key modules
176Found key filteredModules
177Found key logging
178Found key children
179Finished reading /builds/gitlab-org/gitlab/webpack-report/stats.json
180ENV variable $CI_PROJECT_ID is set to: 278964 (gitlab-org/gitlab), using this as the project now
181==> 'webpack-entry-point-analyser --from-file ./webpack-report/stats.json --json ./bundle-size-review/analysis.json --sha f48e0af27832fa6e2ee6f61695a1ebc5ba261e93' succeeded in 29 seconds.
182$ webpack-compare-reports --job 6597627912 --to-file ./bundle-size-review/analysis.json --html ./bundle-size-review/comparison.html --markdown ./bundle-size-review/comparison.md
183ENV variable $CI_PROJECT_ID is set to: 278964 (gitlab-org/gitlab), using this as the project now
184Running with a diff threshold of 1 KB or 2% increase
185Read data for commit f48e0af27832fa6e2ee6f61695a1ebc5ba261e93 from ./bundle-size-review/analysis.json
186Receiving data for job 6597627912.
187It seems like you are running the analysis on a merged pipeline
188Comparing results of fcea9ca73d141cde171d7dcc8cb30cae72878eef (master) to f48e0af27832fa6e2ee6f61695a1ebc5ba261e93 (refs/merge-requests/144819/merge)
189Parent commit from master seems to be: fcea9ca73d141cde171d7dcc8cb30cae72878eef
190Retrieving commit mapping
191Let's gather more info around fcea9ca73d141cde171d7dcc8cb30cae72878eef
192Downloading data for b90d27caa829c66fd2f2b45aace7ca94098b87a9
193Analysis result:
194- 1 entry points with significant growth
195- 503 with minor changes
196Successfully written to ./bundle-size-review/comparison.html
197Successfully written to ./bundle-size-review/comparison.md
198==> 'webpack-compare-reports --job 6597627912 --to-file ./bundle-size-review/analysis.json --html ./bundle-size-review/comparison.html --markdown ./bundle-size-review/comparison.md' succeeded in 2 seconds.
199$ danger --dangerfile=danger/Dangerfile-bundle_size --fail-on-errors=true --verbose --danger_id=bundle-size-review-0cd138
200Results:
201Markdown:
202## Bundle size analysis [beta]
203This compares changes in bundle size for entry points between the commits
204fcea9ca73d141cde171d7dcc8cb30cae72878eef and f48e0af27832fa6e2ee6f61695a1ebc5ba261e93
205### :sparkles: Special assets
206| Entrypoint / Name | Size before | Size after | Diff | Diff in percent |
207| --- | --- | --- | --- | --- |
208| average | 4.32 MB | 4.32 MB | +1.46 KB | 0.0 % |
209| mainChunk | 3.31 MB | 3.31 MB | - | 0.0 % |
210### :fearful: Significant Growth: 1
211<details>
212<summary>Expand</summary>
213
214| Entrypoint / Name | Size before | Size after | Diff | Diff in percent |
215| --- | --- | --- | --- | --- |
216| pages.organizations.projects.edit | 3.04 KB | 727.81 KB | +724.77 KB | 23848.5 % |
217</details>
218- - -
219Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%).
220If you write new or extend existing features, this is expected and there is nothing to worry about.
221**Please consider pinging** someone from the FE Foundations (`@leipert`, `@markrian`, `@pgascouvaillancourt`, `@sdejonge` or `@thutterer`) for review, if you are unsure about the size increase.
222<p>
223 <strong>Note:</strong>
224 We do not have exact data for fcea9ca73d141cde171d7dcc8cb30cae72878eef.
225 So we have used data from: b90d27caa829c66fd2f2b45aace7ca94098b87a9.<br/>
226 The target commit was too new, so we used the latest commit from master we have info on.<br/>
227It might help to rerun the <code>bundle-size-review</code> job<br/>
228This might mean that you have a few false positives in this report.
229If something unrelated to your code changes is reported, you can check <a href="https://gitlab.com/gitlab-org/gitlab/-/compare/b90d27caa829c66fd2f2b45aace7ca94098b87a9...fcea9ca73d141cde171d7dcc8cb30cae72878eef">this comparison</a> in order to see if they caused this change.
230</p>
231Please look at the [full report](https://gitlab.com/gitlab-org/gitlab/-/jobs/6597627912/artifacts/file/bundle-size-review/comparison.html) for more details
232- - -
233[Read more](https://gitlab.com/gitlab-org/frontend/playground/webpack-memory-metrics/-/blob/master/doc/report.md) about how this report works.
234
235==> 'danger --dangerfile=danger/Dangerfile-bundle_size --fail-on-errors=true --verbose --danger_id=bundle-size-review-0cd138' succeeded in 5 seconds.
236 Saving cache for successful job 00:01
237Not uploading cache ruby-gems-debian-bookworm-ruby-3.1-17 due to policy
238Not uploading cache node-modules-debian-bookworm-test-17 due to policy
239Not uploading cache assets-tmp-debian-bookworm-ruby-3.1-node-test-v1-17 due to policy
240 Uploading artifacts for successful job 00:05
241Uploading artifacts...
242bundle-size-review/: found 6 matching artifact files and directories
243WARNING: Upload request redirected location=https://gitlab.com/api/v4/jobs/6597627912/artifacts?artifact_format=zip&artifact_type=archive&expire_in=31d new-url=https://gitlab.com
244WARNING: Retrying... context=artifacts-uploader error=request redirected
245Uploading artifacts as "archive" to coordinator... 201 Created id=6597627912 responseStatus=201 Created token=glcbt-65
246 Cleaning up project directory and file based variables 00:00
247Job succeeded