danger-review
Passed Started
by
@dmishunov
Denys Mishunov
1Running with gitlab-runner 16.11.0~pre.21.gaa21be2d (aa21be2d)2 on blue-3.private.runners-manager.gitlab.com/gitlab.com/gitlab-org 6io2xoDD, system ID: s_8f94f77602233 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:4d97a6e6b48a500f28599f739761ccb23dc0b775b23fe71357e1f48df9074e52 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14@sha256:56b23cca550b55e86db3c2471a1223d2b3a97ddff9a4bf6bd246dcef3ec64284 ...11Running on runner-6io2xodd-project-278964-concurrent-0 via runner-6io2xodd-private-1712650897-80d2d17a...13Fetching changes with git depth set to 20...14Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/15Created fresh repository.16remote: Enumerating objects: 149845, done. 17remote: Counting objects: 100% (149845/149845), done. 18remote: Compressing objects: 100% (103322/103322), done. 19remote: Total 149845 (delta 65248), reused 98732 (delta 40635), pack-reused 0 20Receiving objects: 100% (149845/149845), 129.52 MiB | 26.55 MiB/s, done.21Resolving deltas: 100% (65248/65248), done.23 * [new ref] refs/pipelines/1245507034 -> refs/pipelines/124550703424Checking out b0bb326e as detached HEAD (ref is refs/merge-requests/148631/merge)...25Skipping Git submodules setup26$ git remote set-url origin "${CI_REPOSITORY_URL}"28Checking cache for ruby-gems-debian-bookworm-ruby-3.1-17...29Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-debian-bookworm-ruby-3.1-17 30Successfully extracted cache31Checking cache for node-modules-debian-bookworm-test-17...32Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-debian-bookworm-test-17 33Successfully extracted cache35Using docker image sha256:4d97a6e6b48a500f28599f739761ccb23dc0b775b23fe71357e1f48df9074e52 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14@sha256:56b23cca550b55e86db3c2471a1223d2b3a97ddff9a4bf6bd246dcef3ec64284 ...36$ source scripts/utils.sh37$ bundle_install_script "--with danger"715$ yarn_install_script770$ if [[ "$CI_MERGE_REQUEST_PROJECT_URL" != "$CI_MERGE_REQUEST_SOURCE_PROJECT_URL" || -z "${DANGER_GITLAB_API_TOKEN}" ]]; then # collapsed multi-line command771$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command772Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/analytics_instrumentation.rb773Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/bulk_database_actions.rb774Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/change_column_default.rb775Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/ci_templates.rb776Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/clickhouse.rb777Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb778Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb779Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database.rb780Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb781Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb782Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/experiments.rb783Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb784Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/gitlab_schema_validation.rb785Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/ignored_model_columns.rb786Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/master_pipeline_status.rb787Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/model_validations.rb788Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb789Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb790Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/required_stops.rb791Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/rubocop.rb792Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/saas_feature.rb793Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb794Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb795Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb796Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb797Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/todos.rb798Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation799Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture800Importing rule bulk_database_actions at /builds/gitlab-org/gitlab/danger/bulk_database_actions801Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates802Importing rule change_column_default at /builds/gitlab-org/gitlab/danger/change_column_default803Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/changelog804Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/changes_size805Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config806Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables807Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates808Importing rule clickhouse at /builds/gitlab-org/gitlab/danger/clickhouse809Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/commit_messages810Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/commits_counter811Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files812Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success813Importing rule database at /builds/gitlab-org/gitlab/danger/database814Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam815Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation816Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies817Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint818Importing rule experiments at /builds/gitlab-org/gitlab/danger/experiments819Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag820Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly821Importing rule gitlab_schema_validation at /builds/gitlab-org/gitlab/danger/gitlab_schema_validation822Importing rule ignored_model_columns at /builds/gitlab-org/gitlab/danger/ignored_model_columns823Importing rule master_pipeline_status at /builds/gitlab-org/gitlab/danger/master_pipeline_status824Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/metadata825Importing rule model_validations at /builds/gitlab-org/gitlab/danger/model_validations826Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion827Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline828Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier829Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector830Importing rule required_stops at /builds/gitlab-org/gitlab/danger/required_stops831Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette832Importing rule rubocop at /builds/gitlab-org/gitlab/danger/rubocop833Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems834Importing rule saas_feature at /builds/gitlab-org/gitlab/danger/saas_feature835Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args836Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues837Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels838Importing rule specs at /builds/gitlab-org/gitlab/danger/specs839Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch840Importing rule todos at /builds/gitlab-org/gitlab/danger/todos841Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/type_label842Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css843Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation844Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/z_add_labels845Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/z_retry_link846Results:847Warnings:848- [ ] This merge request contains lines with testid selectors. Please ensure `e2e:package-and-test` job is run.849- [ ] You've made some app changes, but didn't add any tests.850That's OK as long as you're refactoring existing code,851but please consider adding any of the ~"maintenance::pipelines", ~"maintenance::refactor", ~"maintenance::workflow", ~"documentation", ~"QA" labels.852Messages:853- [ ] This merge request includes changes to Vue files that have both CE and EE versions.854Markdown:855## Vue `<template>` in CE and EE856Some Vue files in CE have a counterpart in EE.857(For example, `path/to/file.vue` and `ee/path/to/file.vue`.)858When run in the context of CE, the `<template>` of the CE Vue file is used.859When run in the context of EE, the `<template>` of the EE Vue file is used.860It's easy to accidentally make a change to a CE `<template>` that _should_861appear in both CE and EE without making the change in both places.862When this happens, the change only takes effect in CE.863The following Vue files were changed as part of this merge request that864include both a CE and EE version of the file:865* `app/assets/javascripts/vue_merge_request_widget/components/approvals/approvals.vue`866If you made a change to the `<template>` of any of these Vue files that867should be visible in both CE and EE, please ensure you have made your868change to both versions of the file.869### A better alternative870An even _better_ alternative is to refactor this component to only use871a single template for both CE and EE. More info on this approach here:873### `testid` selectors874The following changed lines in this MR contain `testid` selectors:875#### `app/assets/javascripts/vue_merge_request_widget/components/approvals/approvals_summary.vue`876```shell877- <div data-testid="approvals-summary-content">878+ data-testid="approvals-summary-content"879```880If the `e2e:package-and-test` job in the `qa` stage has run automatically, please ensure the tests are passing.881If the job has not run, please start the `manual:e2e-test-pipeline-generate` job in the `prepare` stage and ensure the tests in `follow-up:e2e:package-and-test-ee` pipeline are passing.882For the list of known failures please refer to [the latest pipeline triage issue](https://gitlab.com/gitlab-org/quality/pipeline-triage/-/issues).883If your changes are under a feature flag, please check our [Testing with feature flags](https://docs.gitlab.com/ee/development/testing_guide/end_to_end/feature_flags.html#automatic-test-execution-when-a-feature-flag-definition-changes) documentation for instructions.884## Reviewer roulette885| Category | Reviewer | Maintainer |886| -------- | -------- | ---------- |887| ~"frontend" | `@dzubova` [](https://gitlab.com/dzubova)  (UTC+2, same timezone as author) | `@fguibert` [](https://gitlab.com/fguibert)  (UTC+10, 8 hours ahead of author) |888| ~UX | `@pedroms` [](https://gitlab.com/pedroms)  (UTC+1, 1 hour behind author) | Maintainer review is optional for ~UX |889**Please check reviewer's status!**890-  Reviewer is available!891-  Reviewer is unavailable!892Please refer to [documentation page](https://docs.gitlab.com/ee/development/code_review.html#reviewer-roulette)893for guidance on how you can benefit from the Reviewer Roulette, or use the894[GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/)895to find other available reviewers.896**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/6579787536) that generated this comment.**898Not uploading cache ruby-gems-debian-bookworm-ruby-3.1-17 due to policy899Not uploading cache node-modules-debian-bookworm-test-17 due to policy901Job succeeded