danger-review
Passed Started
by
@johnmason

John Mason
1Running with gitlab-runner 16.11.0~pre.21.gaa21be2d (aa21be2d)2 on blue-6.private.runners-manager.gitlab.com/gitlab.com/gitlab-org mKJTFBei, system ID: s_90a66139ec063 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:4d97a6e6b48a500f28599f739761ccb23dc0b775b23fe71357e1f48df9074e52 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14@sha256:56b23cca550b55e86db3c2471a1223d2b3a97ddff9a4bf6bd246dcef3ec64284 ...11Running on runner-mkjtfbei-project-278964-concurrent-0 via runner-mkjtfbei-private-1712193671-6ceac3c9...13Fetching changes with git depth set to 20...14Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/15Created fresh repository.16remote: Enumerating objects: 97916, done. 17remote: Counting objects: 100% (97916/97916), done. 18remote: Compressing objects: 100% (79535/79535), done. 19remote: Total 97916 (delta 22735), reused 61470 (delta 13755), pack-reused 0 20Receiving objects: 100% (97916/97916), 111.95 MiB | 24.66 MiB/s, done.21Resolving deltas: 100% (22735/22735), done.23 * [new ref] refs/pipelines/1239361260 -> refs/pipelines/123936126024remote: Enumerating objects: 3, done. 25remote: Counting objects: 100% (3/3), done. 26remote: Compressing objects: 100% (3/3), done. 27remote: Total 3 (delta 0), reused 3 (delta 0), pack-reused 0 28 * [new tag] v16.10.0-ee -> v16.10.0-ee29 * [new tag] v16.10.0-rc42-ee -> v16.10.0-rc42-ee30 * [new tag] v16.10.1-ee -> v16.10.1-ee31Checking out 97d0c0e1 as detached HEAD (ref is refs/merge-requests/147942/merge)...32Skipping Git submodules setup33$ git remote set-url origin "${CI_REPOSITORY_URL}"35Checking cache for ruby-gems-debian-bookworm-ruby-3.1-17...36Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-debian-bookworm-ruby-3.1-17 37Successfully extracted cache38Checking cache for node-modules-debian-bookworm-test-17...39Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-debian-bookworm-test-17 40Successfully extracted cache42Using docker image sha256:4d97a6e6b48a500f28599f739761ccb23dc0b775b23fe71357e1f48df9074e52 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14@sha256:56b23cca550b55e86db3c2471a1223d2b3a97ddff9a4bf6bd246dcef3ec64284 ...43$ source scripts/utils.sh44$ bundle_install_script "--with danger"747$ yarn_install_script822$ if [[ "$CI_MERGE_REQUEST_PROJECT_URL" != "$CI_MERGE_REQUEST_SOURCE_PROJECT_URL" || -z "${DANGER_GITLAB_API_TOKEN}" ]]; then # collapsed multi-line command823$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command824Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/analytics_instrumentation.rb825Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/bulk_database_actions.rb826Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/change_column_default.rb827Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/clickhouse.rb828Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb829Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb830Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database.rb831Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb832Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb833Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/experiments.rb834Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb835Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/gitlab_schema_validation.rb836Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/ignored_model_columns.rb837Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/model_validations.rb838Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb839Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb840Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/required_stops.rb841Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/rubocop.rb842Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/saas_feature.rb843Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb844Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb845Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb846Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb847Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/todos.rb848Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation849Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture850Importing rule bulk_database_actions at /builds/gitlab-org/gitlab/danger/bulk_database_actions851Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates852Importing rule change_column_default at /builds/gitlab-org/gitlab/danger/change_column_default853Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/changelog854/builds/gitlab-org/gitlab/danger/saas_feature/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::SEE_DOC855/builds/gitlab-org/gitlab/danger/feature_flag/Dangerfile:3: warning: previous definition of SEE_DOC was here856/builds/gitlab-org/gitlab/danger/saas_feature/Dangerfile:5: warning: already initialized constant Danger::Dangerfile::SUGGEST_MR_COMMENT857/builds/gitlab-org/gitlab/danger/feature_flag/Dangerfile:9: warning: previous definition of SUGGEST_MR_COMMENT was here858Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/changes_size859Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config860Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables861Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates862Importing rule clickhouse at /builds/gitlab-org/gitlab/danger/clickhouse863Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/commit_messages864Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/commits_counter865Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files866Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success867Importing rule database at /builds/gitlab-org/gitlab/danger/database868Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam869Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation870Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies871Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint872Importing rule experiments at /builds/gitlab-org/gitlab/danger/experiments873Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag874Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly875Importing rule gitlab_schema_validation at /builds/gitlab-org/gitlab/danger/gitlab_schema_validation876Importing rule ignored_model_columns at /builds/gitlab-org/gitlab/danger/ignored_model_columns877Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/metadata878Importing rule model_validations at /builds/gitlab-org/gitlab/danger/model_validations879Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion880Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline881Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier882Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector883Importing rule required_stops at /builds/gitlab-org/gitlab/danger/required_stops884Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette885Importing rule rubocop at /builds/gitlab-org/gitlab/danger/rubocop886Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems887Importing rule saas_feature at /builds/gitlab-org/gitlab/danger/saas_feature888Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args889Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues890Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels891Importing rule specs at /builds/gitlab-org/gitlab/danger/specs892Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch893Importing rule todos at /builds/gitlab-org/gitlab/danger/todos894Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/type_label895Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css896Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation897Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/z_add_labels898Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/z_retry_link899Results:900Warnings:901- [ ] **The `e2e:package-and-test-ee` job needs to succeed or have approval from a Software Engineer in Test.**902Read the "QA e2e:package-and-test-ee" section for more details.903Messages:904- [ ] **[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html)**:905If this merge request needs a changelog entry, add the `Changelog` trailer to the commit message you want to add to the changelog.906If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.907Markdown:908## Reviewer roulette909| Category | Reviewer | Maintainer |910| -------- | -------- | ---------- |911| ~"backend" | `@rkumar555` [](https://gitlab.com/rkumar555)  (UTC+2, same timezone as author) | `@jprovaznik` [](https://gitlab.com/jprovaznik)  (UTC+2, same timezone as author) |912**Please check reviewer's status!**913-  Reviewer is available!914-  Reviewer is unavailable!915Please refer to [documentation page](https://docs.gitlab.com/ee/development/code_review.html#reviewer-roulette)916for guidance on how you can benefit from the Reviewer Roulette, or use the917[GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/)918to find other available reviewers.919## QA `e2e:package-and-test-ee`920**@dgruzd, the `package-and-test` job must complete before merging this merge request.***921If there are failures on the `package-and-test` pipeline, ping your team's associated Software Engineer in Test (SET) to confirm922the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the `#test-platform` Slack channel.923**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/6543829077) that generated this comment.**925Not uploading cache ruby-gems-debian-bookworm-ruby-3.1-17 due to policy926Not uploading cache node-modules-debian-bookworm-test-17 due to policy928Job succeeded