danger-review
Passed Started
by
@j.seto
Jerry Seto
1Running with gitlab-runner 16.11.0~pre.21.gaa21be2d (aa21be2d)2 on blue-4.shared-gitlab-org.runners-manager.gitlab.com/default 8cwZ3F43, system ID: s_df0f7e24ca8b3 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:4d97a6e6b48a500f28599f739761ccb23dc0b775b23fe71357e1f48df9074e52 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14@sha256:56b23cca550b55e86db3c2471a1223d2b3a97ddff9a4bf6bd246dcef3ec64284 ...11Running on runner-8cwz3f43-project-278964-concurrent-0 via runner-8cwz3f43-shared-gitlab-org-1712152449-5fdde51f...13Fetching changes with git depth set to 20...14Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/15Created fresh repository.16remote: Enumerating objects: 153590, done. 17remote: Counting objects: 100% (153590/153590), done. 18remote: Compressing objects: 100% (107637/107637), done. 19remote: Total 153590 (delta 67242), reused 99308 (delta 39702), pack-reused 0 20Receiving objects: 100% (153590/153590), 130.81 MiB | 24.63 MiB/s, done.21Resolving deltas: 100% (67242/67242), done.23 * [new ref] refs/pipelines/1238631875 -> refs/pipelines/123863187524Checking out 6f9453fb as detached HEAD (ref is refs/merge-requests/148196/merge)...25Skipping Git submodules setup26$ git remote set-url origin "${CI_REPOSITORY_URL}"28Checking cache for ruby-gems-debian-bookworm-ruby-3.1-17...29Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-debian-bookworm-ruby-3.1-17 30Successfully extracted cache31Checking cache for node-modules-debian-bookworm-test-17...32Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-debian-bookworm-test-17 33Successfully extracted cache35Using docker image sha256:4d97a6e6b48a500f28599f739761ccb23dc0b775b23fe71357e1f48df9074e52 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14@sha256:56b23cca550b55e86db3c2471a1223d2b3a97ddff9a4bf6bd246dcef3ec64284 ...36$ source scripts/utils.sh37$ bundle_install_script "--with danger"715$ yarn_install_script770$ if [[ "$CI_MERGE_REQUEST_PROJECT_URL" != "$CI_MERGE_REQUEST_SOURCE_PROJECT_URL" || -z "${DANGER_GITLAB_API_TOKEN}" ]]; then # collapsed multi-line command772 * branch mjang-proposed-lfs-doc-change -> FETCH_HEAD773$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command774Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/analytics_instrumentation.rb775Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/bulk_database_actions.rb776Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/change_column_default.rb777Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/ci_templates.rb778Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/clickhouse.rb779Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb780Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb781Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database.rb782Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb783Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb784Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/experiments.rb785Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb786Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/gitlab_schema_validation.rb787Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/ignored_model_columns.rb788Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/model_validations.rb789Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb790Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb791Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/required_stops.rb792Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/rubocop.rb793Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/saas_feature.rb794Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb795Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb796Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb797Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb798Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/todos.rb799Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation800Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture801Importing rule bulk_database_actions at /builds/gitlab-org/gitlab/danger/bulk_database_actions802Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates803Importing rule change_column_default at /builds/gitlab-org/gitlab/danger/change_column_default804Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/changelog805Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/changes_size806Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config807Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables808Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates809Importing rule clickhouse at /builds/gitlab-org/gitlab/danger/clickhouse810Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/commit_messages811/builds/gitlab-org/gitlab/danger/saas_feature/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::SEE_DOC812/builds/gitlab-org/gitlab/danger/feature_flag/Dangerfile:3: warning: previous definition of SEE_DOC was here813/builds/gitlab-org/gitlab/danger/saas_feature/Dangerfile:5: warning: already initialized constant Danger::Dangerfile::SUGGEST_MR_COMMENT814/builds/gitlab-org/gitlab/danger/feature_flag/Dangerfile:9: warning: previous definition of SUGGEST_MR_COMMENT was here815Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/commits_counter816Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files817Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success818Importing rule database at /builds/gitlab-org/gitlab/danger/database819Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam820Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation821Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies822Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint823Importing rule experiments at /builds/gitlab-org/gitlab/danger/experiments824Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag825Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly826Importing rule gitlab_schema_validation at /builds/gitlab-org/gitlab/danger/gitlab_schema_validation827Importing rule ignored_model_columns at /builds/gitlab-org/gitlab/danger/ignored_model_columns828Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/metadata829Importing rule model_validations at /builds/gitlab-org/gitlab/danger/model_validations830Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion831Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline832Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier833Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector834Importing rule required_stops at /builds/gitlab-org/gitlab/danger/required_stops835Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette836Importing rule rubocop at /builds/gitlab-org/gitlab/danger/rubocop837Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems838Importing rule saas_feature at /builds/gitlab-org/gitlab/danger/saas_feature839Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args840Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues841Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels842Importing rule specs at /builds/gitlab-org/gitlab/danger/specs843Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch844Importing rule todos at /builds/gitlab-org/gitlab/danger/todos845Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/type_label846Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css847Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation848Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/z_add_labels849Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/z_retry_link850Results:851Warnings:852- [ ] d02992728be9f62f27da03353380ce9ccb783ec7: The commit subject must contain at least 3 words. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).853Messages:854- [ ] This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is **recommended**. Reviews can happen after you merge.855Markdown:856## Documentation review857The following files require a review from a technical writer:858* `doc/topics/git/lfs/index.md` ([Link to current live version](https://docs.gitlab.com/ee/topics/git/lfs/))859The review does not need to block merging this merge request. See the:860- [Metadata for the `*.md` files](https://docs.gitlab.com/ee/development/documentation/#metadata) that you've changed. The first few lines of each `*.md` file identify the stage and group most closely associated with your docs change.861- The [Technical Writer assigned](https://handbook.gitlab.com/handbook/product/ux/technical-writing/#assignments) for that stage and group.862- [Documentation workflows](https://docs.gitlab.com/ee/development/documentation/workflow.html) for information on when to assign a merge request for review.863**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/6539053434) that generated this comment.**865Not uploading cache ruby-gems-debian-bookworm-ruby-3.1-17 due to policy866Not uploading cache node-modules-debian-bookworm-test-17 due to policy868Job succeeded