danger-review
Passed Started
by
@vyaklushin

Vasilii Iakliushin
1Running with gitlab-runner 16.9.1 (782c6ecb)2 on green-2.shared-gitlab-org.runners-manager.gitlab.com/default 8zCxmpPt, system ID: s_130a96ce9e653 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:fc7435a87025ef82fcd7c3a7df1e52121e8a88ab05430c94ba7ad5920fecc0d0 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14@sha256:c129fa1214137f01be7f1412c5233ac179604d32d9d852cbe06113596fb24504 ...11Running on runner-8zcxmppt-project-278964-concurrent-0 via runner-8zcxmppt-shared-gitlab-org-1709704540-de65d05b...13Fetching changes with git depth set to 20...14Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/15Created fresh repository.16remote: Enumerating objects: 163446, done. 17remote: Counting objects: 100% (163446/163446), done. 18remote: Compressing objects: 100% (108949/108949), done. 19remote: Total 163446 (delta 76321), reused 108650 (delta 48231), pack-reused 0 20Receiving objects: 100% (163446/163446), 127.25 MiB | 22.65 MiB/s, done.21Resolving deltas: 100% (76321/76321), done.23 * [new ref] refs/pipelines/1202927730 -> refs/pipelines/120292773024Checking out 5788aad7 as detached HEAD (ref is refs/merge-requests/138597/merge)...25Skipping Git submodules setup26$ git remote set-url origin "${CI_REPOSITORY_URL}"28Checking cache for ruby-gems-debian-bookworm-ruby-3.1-17...29Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-debian-bookworm-ruby-3.1-17 30Successfully extracted cache31Checking cache for node-modules-debian-bookworm-test-17...32Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-debian-bookworm-test-17 33Successfully extracted cache35Using docker image sha256:fc7435a87025ef82fcd7c3a7df1e52121e8a88ab05430c94ba7ad5920fecc0d0 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14@sha256:c129fa1214137f01be7f1412c5233ac179604d32d9d852cbe06113596fb24504 ...36$ source scripts/utils.sh37$ bundle_install_script "--with danger"715$ yarn_install_script770$ if [[ "$CI_MERGE_REQUEST_PROJECT_URL" != "$CI_MERGE_REQUEST_SOURCE_PROJECT_URL" || -z "${DANGER_GITLAB_API_TOKEN}" ]]; then # collapsed multi-line command771$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command772Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/analytics_instrumentation.rb773Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/bulk_database_actions.rb774Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/change_column_default.rb775Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/clickhouse.rb776Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb777Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb778Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database.rb779Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb780Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb781Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/experiments.rb782Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb783Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/gitlab_schema_validation.rb784Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/ignored_model_columns.rb785Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/model_validations.rb786Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb787Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb788Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/required_stops.rb789Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/rubocop.rb790Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/saas_feature.rb791Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb792Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb793Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb794Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb795Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/todos.rb796Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation797Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture798Importing rule bulk_database_actions at /builds/gitlab-org/gitlab/danger/bulk_database_actions799Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates800Importing rule change_column_default at /builds/gitlab-org/gitlab/danger/change_column_default801Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/changelog802Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/changes_size803Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config804Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables805Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates806Importing rule clickhouse at /builds/gitlab-org/gitlab/danger/clickhouse807Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/commit_messages808Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/commits_counter809Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files810Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success811Importing rule database at /builds/gitlab-org/gitlab/danger/database812Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam813Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation814Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies815Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint816Importing rule experiments at /builds/gitlab-org/gitlab/danger/experiments817Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag818Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly819Importing rule gitlab_schema_validation at /builds/gitlab-org/gitlab/danger/gitlab_schema_validation820Importing rule ignored_model_columns at /builds/gitlab-org/gitlab/danger/ignored_model_columns821Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/metadata822Importing rule model_validations at /builds/gitlab-org/gitlab/danger/model_validations823Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion824Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline825Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier826/builds/gitlab-org/gitlab/danger/saas_feature/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::SEE_DOC827/builds/gitlab-org/gitlab/danger/feature_flag/Dangerfile:3: warning: previous definition of SEE_DOC was here828/builds/gitlab-org/gitlab/danger/saas_feature/Dangerfile:5: warning: already initialized constant Danger::Dangerfile::SUGGEST_MR_COMMENT829/builds/gitlab-org/gitlab/danger/feature_flag/Dangerfile:9: warning: previous definition of SUGGEST_MR_COMMENT was here830Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector831Importing rule required_stops at /builds/gitlab-org/gitlab/danger/required_stops832Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette833Importing rule rubocop at /builds/gitlab-org/gitlab/danger/rubocop834Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems835Importing rule saas_feature at /builds/gitlab-org/gitlab/danger/saas_feature836Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args837Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues838Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels839Importing rule specs at /builds/gitlab-org/gitlab/danger/specs840Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch841Importing rule todos at /builds/gitlab-org/gitlab/danger/todos842Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/type_label843Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css844Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation845Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/z_add_labels846Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/z_retry_link847Results:848Warnings:849- [ ] This MR changes code in `ee/`, but its Changelog commit is missing the [`EE: true` trailer](https://docs.gitlab.com/ee/development/changelog.html#gitlab-enterprise-changes). Consider adding it to your Changelog commits.850- [ ] This merge request contains lines with testid selectors. Please ensure `e2e:package-and-test` job is run.851Markdown:852### `testid` selectors853The following changed lines in this MR contain `testid` selectors:854#### `app/views/projects/milestones/show.html.haml`855```shell856- data: { testid: 'no-issues-alert' }}) do |c|857+ alert_options: { data: { testid: 'all-issues-closed-alert' }},858```859#### `ee/app/views/shared/milestones/_burndown.html.haml`860```shell861+ data: { testid: 'no-issues-and-dates-alert' }}) do |c|862```863If the `e2e:package-and-test` job in the `qa` stage has run automatically, please ensure the tests are passing.864If the job has not run, please start the `trigger-omnibus-and-follow-up-e2e` job in the `qa` stage and ensure the tests in `follow-up-e2e:package-and-test-ee` pipeline are passing.865For the list of known failures please refer to [the latest pipeline triage issue](https://gitlab.com/gitlab-org/quality/pipeline-triage/-/issues).866If your changes are under a feature flag, please check our [Testing with feature flags](https://docs.gitlab.com/ee/development/testing_guide/end_to_end/feature_flags.html#automatic-test-execution-when-a-feature-flag-definition-changes) documentation for instructions.867## Reviewer roulette868| Category | Reviewer | Maintainer |869| -------- | -------- | ---------- |870| ~"backend" | `@eduardobonet` [](https://gitlab.com/eduardobonet)  (UTC+1, same timezone as author) | `@brytannia` [](https://gitlab.com/brytannia)  (UTC+1, same timezone as author) |871| ~"frontend" | `@nradina` [](https://gitlab.com/nradina)  (UTC+1, same timezone as author) | `@elwyn-gitlab` [](https://gitlab.com/elwyn-gitlab)  (UTC+13, 12 hours ahead of author) |872| ~test for `spec/features/*` | `@eduardobonet` [](https://gitlab.com/eduardobonet)  (UTC+1, same timezone as author) | Maintainer review is optional for ~test for `spec/features/*` |873| ~UX | `@katiemacoy` [](https://gitlab.com/katiemacoy)  (UTC+13, 12 hours ahead of author) | Maintainer review is optional for ~UX |874**Please check reviewer's status!**875-  Reviewer is available!876-  Reviewer is unavailable!877Please refer to [documentation page](https://docs.gitlab.com/ee/development/code_review.html#reviewer-roulette)878for guidance on how you can benefit from the Reviewer Roulette, or use the879[GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/)880to find other available reviewers.881ee/spec/features/burndown_charts_spec.rb#L52882```suggestion883 let_it_be(:project) { create(:project, group: group) }884```885Project creations are very slow. To improve test performance, consider using `let_it_be`, `build`, or `build_stubbed` instead.886⚠️ **Warning**: If your test modifies data, `let_it_be` may be unsuitable, and cause state leaks! Use `let_it_be_with_reload` or `let_it_be_with_refind` instead.887Unsure which method to use? See the [testing best practices](https://docs.gitlab.com/ee/development/testing_guide/best_practices.html#optimize-factory-usage)888for background information and alternative options for optimizing factory usage.889If you're concerned about causing state leaks, or if you know `let` or `let!` are the better options, ignore this comment.890([Improve this message?](https://gitlab.com/gitlab-org/gitlab/-/blob/master/tooling/danger/specs/project_factory_suggestion.rb))891**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/6330025013) that generated this comment.**893Not uploading cache ruby-gems-debian-bookworm-ruby-3.1-17 due to policy894Not uploading cache node-modules-debian-bookworm-test-17 due to policy896Job succeeded