danger-review
Passed Started
by
@rkadam3
Rajendra Kadam
1Running with gitlab-runner 16.8.0~beta.67.gb5664e8e (b5664e8e)2 on blue-3.shared-gitlab-org.runners-manager.gitlab.com/default sUrYYgEG, system ID: s_35f98e2af4653 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:fc7435a87025ef82fcd7c3a7df1e52121e8a88ab05430c94ba7ad5920fecc0d0 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14@sha256:c129fa1214137f01be7f1412c5233ac179604d32d9d852cbe06113596fb24504 ...11Running on runner-suryygeg-project-278964-concurrent-0 via runner-suryygeg-shared-gitlab-org-1709550129-f13c71be...13Fetching changes with git depth set to 20...14Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/15Created fresh repository.16remote: Enumerating objects: 155328, done. 17remote: Counting objects: 100% (155328/155328), done. 18remote: Compressing objects: 100% (107889/107889), done. 19remote: Total 155328 (delta 70019), reused 99862 (delta 41421), pack-reused 0 20Receiving objects: 100% (155328/155328), 125.39 MiB | 20.60 MiB/s, done.21Resolving deltas: 100% (70019/70019), done.23 * [new ref] refs/pipelines/1199960153 -> refs/pipelines/119996015324Checking out 457ff24c as detached HEAD (ref is refs/merge-requests/145294/merge)...25Skipping Git submodules setup26$ git remote set-url origin "${CI_REPOSITORY_URL}"28Checking cache for ruby-gems-debian-bookworm-ruby-3.1-17...29cache.zip is up to date 30Successfully extracted cache31Checking cache for node-modules-debian-bookworm-test-17...32Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-debian-bookworm-test-17 33Successfully extracted cache35Using docker image sha256:fc7435a87025ef82fcd7c3a7df1e52121e8a88ab05430c94ba7ad5920fecc0d0 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14@sha256:c129fa1214137f01be7f1412c5233ac179604d32d9d852cbe06113596fb24504 ...36$ source scripts/utils.sh37$ bundle_install_script "--with danger"716$ yarn_install_script771$ if [[ "$CI_MERGE_REQUEST_PROJECT_URL" != "$CI_MERGE_REQUEST_SOURCE_PROJECT_URL" || -z "${DANGER_GITLAB_API_TOKEN}" ]]; then # collapsed multi-line command772$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command773Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/analytics_instrumentation.rb774Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/bulk_database_actions.rb775Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/change_column_default.rb776Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/clickhouse.rb777Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb778Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb779Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database.rb780Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb781Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb782Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/experiments.rb783Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb784Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/gitlab_schema_validation.rb785Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/ignored_model_columns.rb786Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/model_validations.rb787Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb788Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb789Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/required_stops.rb790Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/rubocop.rb791Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/saas_feature.rb792Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb793Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb794Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb795Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb796Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/todos.rb797Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation798Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture799Importing rule bulk_database_actions at /builds/gitlab-org/gitlab/danger/bulk_database_actions800Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates801Importing rule change_column_default at /builds/gitlab-org/gitlab/danger/change_column_default802Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/changelog803Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/changes_size804Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config805Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables806Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates807Importing rule clickhouse at /builds/gitlab-org/gitlab/danger/clickhouse808Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/commit_messages809/builds/gitlab-org/gitlab/danger/saas_feature/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::SEE_DOC810/builds/gitlab-org/gitlab/danger/feature_flag/Dangerfile:3: warning: previous definition of SEE_DOC was here811/builds/gitlab-org/gitlab/danger/saas_feature/Dangerfile:5: warning: already initialized constant Danger::Dangerfile::SUGGEST_MR_COMMENT812/builds/gitlab-org/gitlab/danger/feature_flag/Dangerfile:9: warning: previous definition of SUGGEST_MR_COMMENT was here813Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/commits_counter814Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files815Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success816Importing rule database at /builds/gitlab-org/gitlab/danger/database817Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam818Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation819Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies820Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint821Importing rule experiments at /builds/gitlab-org/gitlab/danger/experiments822Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag823Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly824Importing rule gitlab_schema_validation at /builds/gitlab-org/gitlab/danger/gitlab_schema_validation825Importing rule ignored_model_columns at /builds/gitlab-org/gitlab/danger/ignored_model_columns826Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/metadata827Importing rule model_validations at /builds/gitlab-org/gitlab/danger/model_validations828Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion829Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline830Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier831Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector832Importing rule required_stops at /builds/gitlab-org/gitlab/danger/required_stops833Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette834Importing rule rubocop at /builds/gitlab-org/gitlab/danger/rubocop835Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems836Importing rule saas_feature at /builds/gitlab-org/gitlab/danger/saas_feature837Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args838Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues839Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels840Importing rule specs at /builds/gitlab-org/gitlab/danger/specs841Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch842Importing rule todos at /builds/gitlab-org/gitlab/danger/todos843Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/type_label844Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css845Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation846Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/z_add_labels847Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/z_retry_link848Results:849Warnings:850- [ ] This MR changes code in `ee/`, but its Changelog commit is missing the [`EE: true` trailer](https://docs.gitlab.com/ee/development/changelog.html#gitlab-enterprise-changes). Consider adding it to your Changelog commits.851- [ ] ~"feature::addition" and ~"feature::enhancement" merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the [Technical Writer counterpart](https://handbook.gitlab.com/handbook/product/ux/technical-writing/#assignments).852For more information, see:853- The Handbook page on [merge request types](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification).854- The [definition of done](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#definition-of-done) documentation.855Markdown:856ee/app/models/members/member_role.rb#L27857Did you consider new validations can break existing records?858Please follow the [code quality guidelines about new model validations](https://docs.gitlab.com/ee/development/code_review.html#quality) when adding a new859model validation.860If you're adding the validations to a model with no records you can ignore this warning.861## Reviewer roulette862| Category | Reviewer | Maintainer |863| -------- | -------- | ---------- |864| ~"backend" | `@mc_rocha` [](https://gitlab.com/mc_rocha)  (UTC-5, 6 hours behind author) | `@alejandro` [](https://gitlab.com/alejandro)  (UTC-5, 6 hours behind author) |865| ~"database" | `@huzaifaiftikhar1` [](https://gitlab.com/huzaifaiftikhar1)  (UTC+5.5, 4.5 hours ahead of author) | `@dfrazao-gitlab` [](https://gitlab.com/dfrazao-gitlab)  (UTC+1, same timezone as author) |866| ~"Authorization" | Reviewer review is optional for ~"Authorization" | `@mokhax` [](https://gitlab.com/mokhax)  (UTC-7, 8 hours behind author) |867**Please check reviewer's status!**868-  Reviewer is available!869-  Reviewer is unavailable!870Please refer to [documentation page](https://docs.gitlab.com/ee/development/code_review.html#reviewer-roulette)871for guidance on how you can benefit from the Reviewer Roulette, or use the872[GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/)873to find other available reviewers.874**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/6311413614) that generated this comment.**876Not uploading cache ruby-gems-debian-bookworm-ruby-3.1-17 due to policy877Not uploading cache node-modules-debian-bookworm-test-17 due to policy879Job succeeded 
