danger-review
Passed Started
by
@a_akgun
Alper Akgun
1Running with gitlab-runner 16.8.0~beta.67.gb5664e8e (b5664e8e)2 on blue-2.private.runners-manager.gitlab.com/gitlab.com/gitlab-org QvBVRoXM, system ID: s_49b872f8ccf63 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:2da9ff69af721f2e843977af3fff30c19251b52ac779c79742b680095f026b53 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14@sha256:6b2253621fc67a1033a6eda2566fffedc84a9492a799632fc6be996a3ec6f21e ...11Running on runner-qvbvroxm-project-278964-concurrent-0 via runner-qvbvroxm-private-1709194433-cb73fbcf...13Fetching changes with git depth set to 20...14Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/15Created fresh repository.16remote: Enumerating objects: 154019, done. 17remote: Counting objects: 100% (154019/154019), done. 18remote: Compressing objects: 100% (109102/109102), done. 19remote: Total 154019 (delta 68652), reused 97084 (delta 38804), pack-reused 0 20Receiving objects: 100% (154019/154019), 123.85 MiB | 31.13 MiB/s, done.21Resolving deltas: 100% (68652/68652), done.23 * [new ref] refs/pipelines/1195211514 -> refs/pipelines/119521151424Checking out 31a6b536 as detached HEAD (ref is refs/merge-requests/145975/merge)...25Skipping Git submodules setup26$ git remote set-url origin "${CI_REPOSITORY_URL}"28Checking cache for ruby-gems-debian-bookworm-ruby-3.1-16...29Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-debian-bookworm-ruby-3.1-16 30Successfully extracted cache31Checking cache for node-modules-debian-bookworm-test-16...32Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-debian-bookworm-test-16 33Successfully extracted cache35Using docker image sha256:2da9ff69af721f2e843977af3fff30c19251b52ac779c79742b680095f026b53 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14@sha256:6b2253621fc67a1033a6eda2566fffedc84a9492a799632fc6be996a3ec6f21e ...36$ source scripts/utils.sh37$ bundle_install_script "--with danger"717$ yarn_install_script772$ if [[ "$CI_MERGE_REQUEST_PROJECT_URL" != "$CI_MERGE_REQUEST_SOURCE_PROJECT_URL" || -z "${DANGER_GITLAB_API_TOKEN}" ]]; then # collapsed multi-line command773$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command774Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/analytics_instrumentation.rb775Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/bulk_database_actions.rb776Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/change_column_default.rb777Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/clickhouse.rb778Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb779Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb780Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database.rb781Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb782Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb783Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/experiments.rb784Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb785Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/gitlab_schema_validation.rb786Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/ignored_model_columns.rb787Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/model_validations.rb788Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb789Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb790Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/required_stops.rb791Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/rubocop.rb792Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/saas_feature.rb793Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb794Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb795Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb796Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb797Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/todos.rb798Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation799Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture800Importing rule bulk_database_actions at /builds/gitlab-org/gitlab/danger/bulk_database_actions801Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates802Importing rule change_column_default at /builds/gitlab-org/gitlab/danger/change_column_default803Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/changelog804Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/changes_size805Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config806Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables807Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates808Importing rule clickhouse at /builds/gitlab-org/gitlab/danger/clickhouse809Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/commit_messages810/builds/gitlab-org/gitlab/danger/saas_feature/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::SEE_DOC811/builds/gitlab-org/gitlab/danger/feature_flag/Dangerfile:3: warning: previous definition of SEE_DOC was here812/builds/gitlab-org/gitlab/danger/saas_feature/Dangerfile:5: warning: already initialized constant Danger::Dangerfile::SUGGEST_MR_COMMENT813/builds/gitlab-org/gitlab/danger/feature_flag/Dangerfile:9: warning: previous definition of SUGGEST_MR_COMMENT was here814Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/commits_counter815Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files816Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success817Importing rule database at /builds/gitlab-org/gitlab/danger/database818Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam819Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation820Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies821Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint822Importing rule experiments at /builds/gitlab-org/gitlab/danger/experiments823Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag824Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly825Importing rule gitlab_schema_validation at /builds/gitlab-org/gitlab/danger/gitlab_schema_validation826Importing rule ignored_model_columns at /builds/gitlab-org/gitlab/danger/ignored_model_columns827Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/metadata828Importing rule model_validations at /builds/gitlab-org/gitlab/danger/model_validations829Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion830Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline831Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier832Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector833Importing rule required_stops at /builds/gitlab-org/gitlab/danger/required_stops834Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette835Importing rule rubocop at /builds/gitlab-org/gitlab/danger/rubocop836Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems837Importing rule saas_feature at /builds/gitlab-org/gitlab/danger/saas_feature838Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args839Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues840Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels841Importing rule specs at /builds/gitlab-org/gitlab/danger/specs842Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch843Importing rule todos at /builds/gitlab-org/gitlab/danger/todos844Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/type_label845Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css846Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation847Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/z_add_labels848Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/z_retry_link849Results:850Warnings:851- [ ] 21efb0b173dcef9112ce19ab97ff650925c922e7: The commit subject must start with a capital letter. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).852- [ ] 21efb0b173dcef9112ce19ab97ff650925c922e7: The commit subject and body must be separated by a blank line. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).853- [ ] ~"feature::addition" and ~"feature::enhancement" merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the [Technical Writer counterpart](https://handbook.gitlab.com/handbook/product/ux/technical-writing/#assignments).854For more information, see:855- The Handbook page on [merge request types](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification).856- The [definition of done](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#definition-of-done) documentation.857Messages:858- [ ] **[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html)**:859If this merge request needs a changelog entry, add the `Changelog` trailer to the commit message you want to add to the changelog.860If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.861Markdown:862## Reviewer roulette863| Category | Reviewer | Maintainer |864| -------- | -------- | ---------- |865| ~"backend" | `@partiaga` [](https://gitlab.com/partiaga)  (UTC+11, 11 hours ahead of author) | `@marc_shaw` [](https://gitlab.com/marc_shaw)  (UTC+9, 9 hours ahead of author) |866| ~"database" | `@johnmason` [](https://gitlab.com/johnmason)  (UTC-5, 5 hours behind author) | `@pshutsin` [](https://gitlab.com/pshutsin)  (UTC+1, 1 hour ahead of author) |867**Please check reviewer's status!**868-  Reviewer is available!869-  Reviewer is unavailable!870Please refer to [documentation page](https://docs.gitlab.com/ee/development/code_review.html#reviewer-roulette)871for guidance on how you can benefit from the Reviewer Roulette, or use the872[GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/)873to find other available reviewers.874**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/6285088276) that generated this comment.**876Not uploading cache ruby-gems-debian-bookworm-ruby-3.1-16 due to policy877Not uploading cache node-modules-debian-bookworm-test-16 due to policy879Job succeeded 
