danger-review
Passed Started
by
@eread
Evan Read
1Running with gitlab-runner 16.8.0~beta.67.gb5664e8e (b5664e8e)2 on blue-2.shared-gitlab-org.runners-manager.gitlab.com/default NL4gfoBe, system ID: s_74c3e13161643 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:0704d2ebff510f3d6f608cd8e9064640a9dd041c4e3ac1e1ff2afb5fe22850bc for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14@sha256:bbf2c8a67a31469f488a4541826628901b6eb5c0a4d68147919aca0b98107df6 ...11Running on runner-nl4gfobe-project-278964-concurrent-0 via runner-nl4gfobe-shared-gitlab-org-1708467992-031bb260...13Fetching changes with git depth set to 20...14Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/15Created fresh repository.16remote: Enumerating objects: 150964, done. 17remote: Counting objects: 100% (150964/150964), done. 18remote: Compressing objects: 100% (104221/104221), done. 19remote: Total 150964 (delta 66574), reused 97915 (delta 40904), pack-reused 0 20Receiving objects: 100% (150964/150964), 124.55 MiB | 24.83 MiB/s, done.21Resolving deltas: 100% (66574/66574), done.23 * [new ref] refs/pipelines/1184210529 -> refs/pipelines/118421052924Checking out 0976c816 as detached HEAD (ref is refs/merge-requests/145224/merge)...25Skipping Git submodules setup26$ git remote set-url origin "${CI_REPOSITORY_URL}"28Checking cache for ruby-gems-debian-bookworm-ruby-3.1-16...29cache.zip is up to date 30Successfully extracted cache31Checking cache for node-modules-debian-bookworm-test-16...32Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-debian-bookworm-test-16 33Successfully extracted cache35Using docker image sha256:0704d2ebff510f3d6f608cd8e9064640a9dd041c4e3ac1e1ff2afb5fe22850bc for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14@sha256:bbf2c8a67a31469f488a4541826628901b6eb5c0a4d68147919aca0b98107df6 ...36$ source scripts/utils.sh37$ bundle_install_script "--with danger"717$ yarn_install_script772$ if [[ "$CI_MERGE_REQUEST_PROJECT_URL" != "$CI_MERGE_REQUEST_SOURCE_PROJECT_URL" || -z "${DANGER_GITLAB_API_TOKEN}" ]]; then # collapsed multi-line command773$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command774Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/analytics_instrumentation.rb775Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/bulk_database_actions.rb776Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/change_column_default.rb777Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/clickhouse.rb778Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb779Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb780Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database.rb781Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb782Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb783Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/experiments.rb784Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb785Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/gitlab_schema_validation.rb786Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/ignored_model_columns.rb787Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/model_validations.rb788Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb789Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb790Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/required_stops.rb791Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/rubocop.rb792Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/saas_feature.rb793Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb794Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb795Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb796Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb797Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/todos.rb798Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation799Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture800Importing rule bulk_database_actions at /builds/gitlab-org/gitlab/danger/bulk_database_actions801Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates802Importing rule change_column_default at /builds/gitlab-org/gitlab/danger/change_column_default803Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/changelog804Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/changes_size805/builds/gitlab-org/gitlab/danger/saas_feature/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::SEE_DOC806/builds/gitlab-org/gitlab/danger/feature_flag/Dangerfile:3: warning: previous definition of SEE_DOC was here807/builds/gitlab-org/gitlab/danger/saas_feature/Dangerfile:5: warning: already initialized constant Danger::Dangerfile::SUGGEST_MR_COMMENT808/builds/gitlab-org/gitlab/danger/feature_flag/Dangerfile:9: warning: previous definition of SUGGEST_MR_COMMENT was here809Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config810Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables811Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates812Importing rule clickhouse at /builds/gitlab-org/gitlab/danger/clickhouse813Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/commit_messages814Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/commits_counter815Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files816Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success817Importing rule database at /builds/gitlab-org/gitlab/danger/database818Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam819Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation820Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies821Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint822Importing rule experiments at /builds/gitlab-org/gitlab/danger/experiments823Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag824Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly825Importing rule gitlab_schema_validation at /builds/gitlab-org/gitlab/danger/gitlab_schema_validation826Importing rule ignored_model_columns at /builds/gitlab-org/gitlab/danger/ignored_model_columns827Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/metadata828Importing rule model_validations at /builds/gitlab-org/gitlab/danger/model_validations829Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion830Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline831Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier832Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector833Importing rule required_stops at /builds/gitlab-org/gitlab/danger/required_stops834Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette835Importing rule rubocop at /builds/gitlab-org/gitlab/danger/rubocop836Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems837Importing rule saas_feature at /builds/gitlab-org/gitlab/danger/saas_feature838Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args839Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues840Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels841Importing rule specs at /builds/gitlab-org/gitlab/danger/specs842Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch843Importing rule todos at /builds/gitlab-org/gitlab/danger/todos844Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/type_label845Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css846Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation847Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/z_add_labels848Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/z_retry_link849Results:850Messages:851- [ ] This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is **recommended**. Reviews can happen after you merge.852Markdown:853## Documentation review854The following files require a review from a technical writer:855* `doc/integration/mattermost/index.md` ([Link to current live version](https://docs.gitlab.com/ee/integration/mattermost/))856The review does not need to block merging this merge request. See the:857- [Metadata for the `*.md` files](https://docs.gitlab.com/ee/development/documentation/#metadata) that you've changed. The first few lines of each `*.md` file identify the stage and group most closely associated with your docs change.858- The [Technical Writer assigned](https://handbook.gitlab.com/handbook/product/ux/technical-writing/#assignments) for that stage and group.859- [Documentation workflows](https://docs.gitlab.com/ee/development/documentation/workflow.html) for information on when to assign a merge request for review.860**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/6218694217) that generated this comment.**862Not uploading cache ruby-gems-debian-bookworm-ruby-3.1-16 due to policy863Not uploading cache node-modules-debian-bookworm-test-16 due to policy865Job succeeded