danger-review
Passed Started
by
@eduardosanz
Eduardo Sanz García
1Running with gitlab-runner 16.8.0~beta.67.gb5664e8e (b5664e8e)2 on blue-1.private.runners-manager.gitlab.com/gitlab.com/gitlab-org 1zzGUpzq, system ID: s_fc31da7ae46e3 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:274a25f2fb2e5661168649bf8fd798f877912a5bcab01401c420d226f2ddcbfa for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14@sha256:24f21cc2dde299c0cde8c76091a9ab782811b704b4f5501da85a82c196c48dc9 ...11Running on runner-1zzgupzq-project-278964-concurrent-0 via runner-1zzgupzq-private-1705642747-9f0e488c...13Fetching changes with git depth set to 20...14Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/15Created fresh repository.16remote: Enumerating objects: 167977, done. 17remote: Counting objects: 100% (167977/167977), done. 18remote: Compressing objects: 100% (115062/115062), done. 19remote: Total 167977 (delta 75826), reused 108609 (delta 45888), pack-reused 0 20Receiving objects: 100% (167977/167977), 137.11 MiB | 26.00 MiB/s, done.21Resolving deltas: 100% (75826/75826), done.23 * [new ref] refs/pipelines/1144013766 -> refs/pipelines/114401376624Checking out 2e7af0dc as detached HEAD (ref is refs/merge-requests/140611/merge)...25Skipping Git submodules setup26$ git remote set-url origin "${CI_REPOSITORY_URL}"28Checking cache for ruby-gems-debian-bullseye-ruby-3.1-16...29cache.zip is up to date 30Successfully extracted cache31Checking cache for node-modules-bullseye-test-16...32Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-bullseye-test-16 33Successfully extracted cache35Using docker image sha256:274a25f2fb2e5661168649bf8fd798f877912a5bcab01401c420d226f2ddcbfa for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14@sha256:24f21cc2dde299c0cde8c76091a9ab782811b704b4f5501da85a82c196c48dc9 ...36$ source scripts/utils.sh37$ bundle_install_script "--with danger"719$ yarn_install_script774$ if [[ "$CI_MERGE_REQUEST_PROJECT_URL" != "$CI_MERGE_REQUEST_SOURCE_PROJECT_URL" || -z "${DANGER_GITLAB_API_TOKEN}" ]]; then # collapsed multi-line command776 * branch replace-sass -> FETCH_HEAD777$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command778Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/analytics_instrumentation.rb779Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/bulk_database_actions.rb780Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/change_column_default.rb781Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/clickhouse.rb782Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb783Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb784Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database.rb785Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb786Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb787Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/experiments.rb788Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb789Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/gitlab_schema_validation.rb790Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/ignored_model_columns.rb791Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/model_validations.rb792Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb793Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb794Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/required_stops.rb795Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/rubocop.rb796Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/saas_feature.rb797Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb798Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb799Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb800Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb801Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/todos.rb802Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation803Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture804Importing rule bulk_database_actions at /builds/gitlab-org/gitlab/danger/bulk_database_actions805Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates806Importing rule change_column_default at /builds/gitlab-org/gitlab/danger/change_column_default807Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/changelog808Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/changes_size809Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config810Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables811Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates812Importing rule clickhouse at /builds/gitlab-org/gitlab/danger/clickhouse813Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/commit_messages814/builds/gitlab-org/gitlab/danger/saas_feature/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::SEE_DOC815/builds/gitlab-org/gitlab/danger/feature_flag/Dangerfile:3: warning: previous definition of SEE_DOC was here816/builds/gitlab-org/gitlab/danger/saas_feature/Dangerfile:5: warning: already initialized constant Danger::Dangerfile::SUGGEST_MR_COMMENT817/builds/gitlab-org/gitlab/danger/feature_flag/Dangerfile:9: warning: previous definition of SUGGEST_MR_COMMENT was here818Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/commits_counter819Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files820Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success821Importing rule database at /builds/gitlab-org/gitlab/danger/database822Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam823Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation824Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies825Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint826Importing rule experiments at /builds/gitlab-org/gitlab/danger/experiments827Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag828Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly829Importing rule gitlab_schema_validation at /builds/gitlab-org/gitlab/danger/gitlab_schema_validation830Importing rule ignored_model_columns at /builds/gitlab-org/gitlab/danger/ignored_model_columns831Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/metadata832Importing rule model_validations at /builds/gitlab-org/gitlab/danger/model_validations833Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion834Importing rule pajamas at /builds/gitlab-org/gitlab/danger/pajamas835Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline836Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier837Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector838Importing rule required_stops at /builds/gitlab-org/gitlab/danger/required_stops839Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette840Importing rule rubocop at /builds/gitlab-org/gitlab/danger/rubocop841Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems842Importing rule saas_feature at /builds/gitlab-org/gitlab/danger/saas_feature843Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args844Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues845Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels846Importing rule specs at /builds/gitlab-org/gitlab/danger/specs847Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch848Importing rule todos at /builds/gitlab-org/gitlab/danger/todos849Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/type_label850Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css851Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation852Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/z_add_labels853Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.6.0/lib/danger/rules/z_retry_link854Results:855Warnings:856- [ ] 7f989fb27caee66caa5d0a61973dc19be4991e89: The commit subject must contain at least 3 words. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).857- [ ] 9a0ce5343f26f02d2393b1bc0f5c51b9ef912298: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).858- [ ] 8c781077771b017626d1d2c59090e0cbab593889: The commit subject must contain at least 3 words. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).859- [ ] ~"feature::addition" and ~"feature::enhancement" merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the [Technical Writer counterpart](https://handbook.gitlab.com/handbook/product/ux/technical-writing/#assignments).860For more information, see:861- The Handbook page on [merge request types](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification).862- The [definition of done](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#definition-of-done) documentation.863Messages:864- [ ] This merge request adds or changes files that require a review from the [Database team](https://gitlab.com/groups/gl-database/-/group_members).865Markdown:866This merge request requires a database review. To make sure these867changes are reviewed, take the following steps:8681. Ensure the merge request has ~database and ~"database::review pending" labels.869 If the merge request modifies database files, Danger will do this for you.8701. Prepare your MR for database review according to the871 [docs](https://docs.gitlab.com/ee/development/database_review.html#how-to-prepare-the-merge-request-for-a-database-review).8721. Assign and mention the database reviewer suggested by Reviewer Roulette.873If you no longer require a database review, you can remove this suggestion874by removing the ~database label and re-running the [`danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/5965273868).875## Reviewer roulette876Changes that require review have been detected!877Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:878| Category | Reviewer | Maintainer |879| -------- | -------- | ---------- |880| ~"backend" | `@eduardobonet` [](https://gitlab.com/eduardobonet)  (UTC+1) | `@stanhu` [](https://gitlab.com/stanhu)  (UTC-8) |881| ~"database" | `@tianwenchen` [](https://gitlab.com/tianwenchen)  (UTC+11) | `@tigerwnz` [](https://gitlab.com/tigerwnz)  (UTC+8) |882| ~"frontend" | `@lcallahan` [](https://gitlab.com/lcallahan)  (UTC-7) | `@jerasmus` [](https://gitlab.com/jerasmus)  (UTC+1) |883| ~"Tooling" | Reviewer review is optional for ~"Tooling" | `@ankit.panchal` [](https://gitlab.com/ankit.panchal)  (UTC+5.5) |884**Please check reviewer's status!**885-  Reviewer is available!886-  Reviewer is unavailable!887Feel free to [override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)888if you think someone else would be better-suited889or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/)890to find other available reviewers.891To read more on how to use the reviewer roulette, please take a look at the892[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)893and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).894Please consider assigning a reviewer or maintainer who is a895[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.896Once you've decided who will review this merge request, assign them as a reviewer!897Danger does not automatically notify them for you.898## Rubygems899This merge request adds, or changes a Rubygems dependency. Please review the [Gemfile guidelines](https://docs.gitlab.com/ee/development/gemfile.html).900**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/5965273868) that generated this comment.**902Not uploading cache ruby-gems-debian-bullseye-ruby-3.1-16 due to policy903Not uploading cache node-modules-bullseye-test-16 due to policy905Job succeeded 
